Title: Remove git.util.NullHandler by EliahKagan · Pull Request #1807 · gitpython-developers/GitPython · GitHub
Open Graph Title: Remove git.util.NullHandler by EliahKagan · Pull Request #1807 · gitpython-developers/GitPython
X Title: Remove git.util.NullHandler by EliahKagan · Pull Request #1807 · gitpython-developers/GitPython
Description: This is not related to the issue of when a noop handler should actually be used, so it is independent of #1806. The NullHandler class in git.util was added when merging #300, to allow a noop handler to be used on Python 2.6, since the standard library logging.NullHandler class was added in Python 2.7. When introduced in d1a9a23, the git.util.NullHandler class was also patched into the logging module, but that has no longer been done since 2fced2e (#979), nor does GitPython make other use of it. git/util.py defines __all__, which does not list NullHandler. As NullHandler is not otherwise documented to be public, it is a bug for any code outside GitPython to use it, and removing it is not a breaking change. So there should be no need for a deprecation period or to wait until the next major version of GitPython. For some reason I had not, at first, thought to check if it was in __all__, and assumed it was. The first commit here reflects that mistake, documenting it as deprecated and why the standard library NullHandler is preferable, and having it issue DeprecationWarning when constructed. Although I wouldn't have written that if I'd been paying proper attention, I decided to keep it, since the documented difference between it and logging.NullHandler may be useful to see in the history. However, I'd be happy to rebase to remove that commit and update the other commit's message accordingly, if desired.
Open Graph Description: This is not related to the issue of when a noop handler should actually be used, so it is independent of #1806. The NullHandler class in git.util was added when merging #300, to allow a noop handle...
X Description: This is not related to the issue of when a noop handler should actually be used, so it is independent of #1806. The NullHandler class in git.util was added when merging #300, to allow a noop handle...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1807
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:039d5f56-567d-cee7-ee31-09afa4c03fed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B45A:34EAA:1302DBD:1A6712C:6968AF6D |
| html-safe-nonce | b031a8b27cd47a3c66a0ff4ffeb99a13819d69bd444bfc406a8868939ac4968d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDVBOjM0RUFBOjEzMDJEQkQ6MUE2NzEyQzo2OTY4QUY2RCIsInZpc2l0b3JfaWQiOiIxNTM2OTE2MTQ1NTU1NjgxMTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5062a13d12d30f8ce2359c592bd8d1430225d2df6654c9b1b11017931c07e1ad |
| hovercard-subject-tag | pull_request:1692734759 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1807/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This is not related to the issue of when a noop handler should actually be used, so it is independent of #1806. The NullHandler class in git.util was added when merging #300, to allow a noop handle... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width