Title: Remove test dependency on sumtypes library by EliahKagan · Pull Request #1798 · gitpython-developers/GitPython · GitHub
Open Graph Title: Remove test dependency on sumtypes library by EliahKagan · Pull Request #1798 · gitpython-developers/GitPython
X Title: Remove test dependency on sumtypes library by EliahKagan · Pull Request #1798 · gitpython-developers/GitPython
Description: Fixes #1797 The WinBashStatus class in test_index.py, introduced in #1745, had used the sumtypes library to express the various cases relevant to xfail markings and troubleshooting and, where applicable, to express some associated debugging information. This includes the Inapplicable case, so sumtypes was used on all systems, not just Windows, which also usefully allowed the other cases to be inspected dynamically on any system, and allowed xfail markings to be written without excess complexity. However, that only used a small fragment of sumtypes functionality, which can be expressed with only minor inelegance with explicit data classes. This pull request makes that change and removes sumtypes as a test dependency. Because the sumtypes dependency was apparently causing problems for downstream maintainers (per #1797), I believe this change is justified. I believe the small inelegance of less compact definitions, and of the case classes not having an inheritance relationship to WinBashStatus itself, are the only disadvantages of this changed approach. The actual logic, stored information, and available debugging information is the same, fully useful reprs are still produced, no code change is needed in any of the markings that use WinBashStatus, and the class is still defined on all systems. Nonetheless I have retested the cases locally (since only two of them occur on CI), verifying that they still work and that the same debugging information remains available.
Open Graph Description: Fixes #1797 The WinBashStatus class in test_index.py, introduced in #1745, had used the sumtypes library to express the various cases relevant to xfail markings and troubleshooting and, where appli...
X Description: Fixes #1797 The WinBashStatus class in test_index.py, introduced in #1745, had used the sumtypes library to express the various cases relevant to xfail markings and troubleshooting and, where appli...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1798
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:13d87efd-7250-ac0d-d01d-ad4772ac9b98 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECFA:6345A:615DBE:8813FC:6968CC93 |
| html-safe-nonce | 2c869691f85a150efda38780116359838a7504c49fa6537308c8e3daeccbeece |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0ZBOjYzNDVBOjYxNURCRTo4ODEzRkM6Njk2OENDOTMiLCJ2aXNpdG9yX2lkIjoiMjg3ODg5NTc0MTA5NTk1NTYwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 451f7ff48972710ad12126c0d51f8d55517e00ba8335cb564a9705c199404df5 |
| hovercard-subject-tag | pull_request:1675281767 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1798/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #1797 The WinBashStatus class in test_index.py, introduced in #1745, had used the sumtypes library to express the various cases relevant to xfail markings and troubleshooting and, where appli... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af2d7af0cc84117fa10bf36808605ef68a335c9d8a804b9cdac55f8d77230b00 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc844ab6ee0198cc2e2c142dcb8a5c2a61d48743 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width