René's URL Explorer Experiment


Title: Fix two remaining Windows untrusted search path cases by EliahKagan · Pull Request #1792 · gitpython-developers/GitPython · GitHub

Open Graph Title: Fix two remaining Windows untrusted search path cases by EliahKagan · Pull Request #1792 · gitpython-developers/GitPython

X Title: Fix two remaining Windows untrusted search path cases by EliahKagan · Pull Request #1792 · gitpython-developers/GitPython

Description: GitPython is a python library used to interact with Git repositories. - Fix two remaining Windows untrusted search path cases by EliahKagan · Pull Request #1792 · gitpython-developers/GitPython

Open Graph Description: This fixes CVE-2024-22190. Although #1636 caused GitPython to avoid using an untrusted search path on Windows under the most typical circumstances, it turns out that some cases remained. I believe ...

X Description: This fixes CVE-2024-22190. Although #1636 caused GitPython to avoid using an untrusted search path on Windows under the most typical circumstances, it turns out that some cases remained. I believe ...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1792

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:88306a83-1a91-6a81-8a6c-f75c9c9f7ed0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFC6:2C5AFC:2CCE266:3EF0387:6969349C
html-safe-nonce0afa1e1e8ee7b85d93deefc982a87566e6a60383402f82f3154aa6dc0e9a43e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkM2OjJDNUFGQzoyQ0NFMjY2OjNFRjAzODc6Njk2OTM0OUMiLCJ2aXNpdG9yX2lkIjoiNDE0NzM3ODI2NzEyOTE5NzcyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac171537e73bbd497c9820ec36d5f7ab775e010ba387876ab247899df543fde1d7
hovercard-subject-tagpull_request:1672093385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1792/commits
twitter:imagehttps://opengraph.githubassets.com/4e21626a0eb0ef4294687438846a6293926c1b45c450ab898803a5ec50147a15/gitpython-developers/GitPython/pull/1792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e21626a0eb0ef4294687438846a6293926c1b45c450ab898803a5ec50147a15/gitpython-developers/GitPython/pull/1792
og:image:altThis fixes CVE-2024-22190. Although #1636 caused GitPython to avoid using an untrusted search path on Windows under the most typical circumstances, it turns out that some cases remained. I believe ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEliahKagan
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-cache
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/1792/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1792%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1792%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1792/commits
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1792/commits
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1792/commits
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1792/commits
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1792/commits
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:popenhttps://github.com/EliahKagan/GitPython/tree/popen
Conversationhttps://github.com/gitpython-developers/GitPython/pull/1792
Commits16 (16)https://github.com/gitpython-developers/GitPython/pull/1792/commits
Checkshttps://github.com/gitpython-developers/GitPython/pull/1792/checks
Files changedhttps://github.com/gitpython-developers/GitPython/pull/1792/files
Fix two remaining Windows untrusted search path caseshttps://github.com/gitpython-developers/GitPython/pull/1792/commits#top
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:popenhttps://github.com/EliahKagan/GitPython/tree/popen
Show "not from cwd" test is broken for shell=Truehttps://github.com/gitpython-developers/GitPython/pull/1792/commits/1c65efbe73513028510fe3fb599777a721f8d80c
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
1c65efbhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/1c65efbe73513028510fe3fb599777a721f8d80c
https://github.com/gitpython-developers/GitPython/tree/1c65efbe73513028510fe3fb599777a721f8d80c
Correct the "not from cwd" test and add more caseshttps://github.com/gitpython-developers/GitPython/pull/1792/commits/2b47933fba1e9266edb1bb71163768288bbfd409
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
2b47933https://github.com/gitpython-developers/GitPython/pull/1792/commits/2b47933fba1e9266edb1bb71163768288bbfd409
https://github.com/gitpython-developers/GitPython/tree/2b47933fba1e9266edb1bb71163768288bbfd409
Use SystemRoot instead of WINDIR, to fix toxhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/c1f6c17182d59b9098aeac272dba79d912c5fa42
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
c1f6c17https://github.com/gitpython-developers/GitPython/pull/1792/commits/c1f6c17182d59b9098aeac272dba79d912c5fa42
https://github.com/gitpython-developers/GitPython/tree/c1f6c17182d59b9098aeac272dba79d912c5fa42
Omit CWD in executable search even when shell=Truehttps://github.com/gitpython-developers/GitPython/pull/1792/commits/06bd2c7ee2b9a4169c02ba6f4e3bc34ab674af73
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
06bd2c7https://github.com/gitpython-developers/GitPython/pull/1792/commits/06bd2c7ee2b9a4169c02ba6f4e3bc34ab674af73
https://github.com/gitpython-developers/GitPython/tree/06bd2c7ee2b9a4169c02ba6f4e3bc34ab674af73
Refactor "not from cwd" test for readabilityhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/7da9c3b45a19302b346474ea3fdcda1594c33b08
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
7da9c3bhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/7da9c3b45a19302b346474ea3fdcda1594c33b08
https://github.com/gitpython-developers/GitPython/tree/7da9c3b45a19302b346474ea3fdcda1594c33b08
Further expand "not from cwd" test re: cmd.exehttps://github.com/gitpython-developers/GitPython/pull/1792/commits/865c6e8315e8700737981e8fe43a1ac62eb1423a
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
865c6e8https://github.com/gitpython-developers/GitPython/pull/1792/commits/865c6e8315e8700737981e8fe43a1ac62eb1423a
https://github.com/gitpython-developers/GitPython/tree/865c6e8315e8700737981e8fe43a1ac62eb1423a
Make Git.execute a bit simpler and very slightly more robusthttps://github.com/gitpython-developers/GitPython/pull/1792/commits/d2506c73b6ad59bff1f2f58c4edd15f717012591
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
d2506c7https://github.com/gitpython-developers/GitPython/pull/1792/commits/d2506c73b6ad59bff1f2f58c4edd15f717012591
https://github.com/gitpython-developers/GitPython/tree/d2506c73b6ad59bff1f2f58c4edd15f717012591
Start on test_hook_uses_shell_not_from_cwdhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/61b4ddacc509b67ec809e15d74de1b60a2a28282
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
61b4ddahttps://github.com/gitpython-developers/GitPython/pull/1792/commits/61b4ddacc509b67ec809e15d74de1b60a2a28282
https://github.com/gitpython-developers/GitPython/tree/61b4ddacc509b67ec809e15d74de1b60a2a28282
Omit CWD in search for bash.exe to run hooks on Windowshttps://github.com/gitpython-developers/GitPython/pull/1792/commits/66ff4c177accfb4f21d3eb476381d248d99fd8b5
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
66ff4c1https://github.com/gitpython-developers/GitPython/pull/1792/commits/66ff4c177accfb4f21d3eb476381d248d99fd8b5
https://github.com/gitpython-developers/GitPython/tree/66ff4c177accfb4f21d3eb476381d248d99fd8b5
Extract venv management from test_installationhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/7751436b94d96ce0978b301681b851edd6efed63
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
7751436https://github.com/gitpython-developers/GitPython/pull/1792/commits/7751436b94d96ce0978b301681b851edd6efed63
https://github.com/gitpython-developers/GitPython/tree/7751436b94d96ce0978b301681b851edd6efed63
Cover absent/no-distro bash.exe in hooks "not from cwd" testhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/a42ea0a38c489caf9969836141120d760d3754b4
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
a42ea0ahttps://github.com/gitpython-developers/GitPython/pull/1792/commits/a42ea0a38c489caf9969836141120d760d3754b4
https://github.com/gitpython-developers/GitPython/tree/a42ea0a38c489caf9969836141120d760d3754b4
Avoid spurious "location may have moved" on Windowshttps://github.com/gitpython-developers/GitPython/pull/1792/commits/f44524a9a9c8122b9b98d6e5797e1dfc3211c0b7
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
f44524ahttps://github.com/gitpython-developers/GitPython/pull/1792/commits/f44524a9a9c8122b9b98d6e5797e1dfc3211c0b7
https://github.com/gitpython-developers/GitPython/tree/f44524a9a9c8122b9b98d6e5797e1dfc3211c0b7
Clarify comment in test_hook_uses_shell_not_from_cwdhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/15ebb258d4eebd9bf0f38780570d57e0b968b8de
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
15ebb25https://github.com/gitpython-developers/GitPython/pull/1792/commits/15ebb258d4eebd9bf0f38780570d57e0b968b8de
https://github.com/gitpython-developers/GitPython/tree/15ebb258d4eebd9bf0f38780570d57e0b968b8de
Extract shared logic for using Popen safely on Windowshttps://github.com/gitpython-developers/GitPython/pull/1792/commits/c551e916c7b9e2d623b9d76f3352849a707d9bbe
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
c551e91https://github.com/gitpython-developers/GitPython/pull/1792/commits/c551e916c7b9e2d623b9d76f3352849a707d9bbe
https://github.com/gitpython-developers/GitPython/tree/c551e916c7b9e2d623b9d76f3352849a707d9bbe
Move safer_popen from git.util to git.cmdhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/3eb7c2ab82e6dbe101ff916fca29d539cc2793af
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
3eb7c2ahttps://github.com/gitpython-developers/GitPython/pull/1792/commits/3eb7c2ab82e6dbe101ff916fca29d539cc2793af
https://github.com/gitpython-developers/GitPython/tree/3eb7c2ab82e6dbe101ff916fca29d539cc2793af
Further clarify comment in test_hook_uses_shell_not_from_cwdhttps://github.com/gitpython-developers/GitPython/pull/1792/commits/1f3caa31f1b63908235e341418a0804ed37a320a
https://github.com/EliahKagan
EliahKaganhttps://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
1f3caa3https://github.com/gitpython-developers/GitPython/pull/1792/commits/1f3caa31f1b63908235e341418a0804ed37a320a
https://github.com/gitpython-developers/GitPython/tree/1f3caa31f1b63908235e341418a0804ed37a320a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.