Title: Improve hooks tests by EliahKagan · Pull Request #1777 · gitpython-developers/GitPython · GitHub
Open Graph Title: Improve hooks tests by EliahKagan · Pull Request #1777 · gitpython-developers/GitPython
X Title: Improve hooks tests by EliahKagan · Pull Request #1777 · gitpython-developers/GitPython
Description: This improves the tests of git hooks in test_index.py: f664a0b fixes and adds missing xfail marks for the WinBashStatus.Absent condition. This is a test bug from when I added the xfail marks in #1745. The Absent condition was detected correctly, but not always used, or used properly, in xfail markings. e148647 adds a direct test of run_commit_hook itself. The other tests test specific kinds of hooks. run_commit_hook is public so it's reasonable for it to have its own test, plus I anticipate this will help future work. Their commit messages include some more details, including rationale. I have made sure to test on a Windows system that truly does not have bash.exe (as well testing the WinBashStatus.Wsl case, which CI confirms, and the WinBashStatus.Native case). One might worry that I missed this before due to some further bug, but I believe not. Producing a genuine WslBashStatus.Absent condition on a Windows system that has a system-provided WSL-related bash.exe in System32 (which is searched regardless of what is in the PATH environment variable, as noted in the WinBashStatus.check docstring) is a bit tricky because renaming that file requires one to act as the TrustedInstaller user (as would the worse option of deleting it). At some point while working on #1745, I did not test this when I should have. I believe that is the only reason it was missed, rather than any underlying technical issue.
Open Graph Description: This improves the tests of git hooks in test_index.py: f664a0b fixes and adds missing xfail marks for the WinBashStatus.Absent condition. This is a test bug from when I added the xfail marks in #1...
X Description: This improves the tests of git hooks in test_index.py: f664a0b fixes and adds missing xfail marks for the WinBashStatus.Absent condition. This is a test bug from when I added the xfail marks in #1...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1777
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:c3c7dfea-24da-141b-c570-b5bf2611cccb |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | BC5E:12F8:CD08B8:123CA29:696907F5 |
| html-safe-nonce | 4acaf14bef213771ab70b376264c58d8a50471b254d0be8a5f2dcf2a43ff8c7b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzVFOjEyRjg6Q0QwOEI4OjEyM0NBMjk6Njk2OTA3RjUiLCJ2aXNpdG9yX2lkIjoiMjM4MzQwMDIyMDQ0ODMyNzY2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3a93ceaf6ff0102026328d004e36bf5cfdd4633df268ab9c4e1ec367c62ccba1 |
| hovercard-subject-tag | pull_request:1653275268 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1777/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This improves the tests of git hooks in test_index.py: f664a0b fixes and adds missing xfail marks for the WinBashStatus.Absent condition. This is a test bug from when I added the xfail marks in #1... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ee2210c3e58153aae53400c942f8a7b4bbb43ec4 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width