Title: Run some Windows environment variable tests only on Windows by EliahKagan · Pull Request #1774 · gitpython-developers/GitPython · GitHub
Open Graph Title: Run some Windows environment variable tests only on Windows by EliahKagan · Pull Request #1774 · gitpython-developers/GitPython
X Title: Run some Windows environment variable tests only on Windows by EliahKagan · Pull Request #1774 · gitpython-developers/GitPython
Description: These are a couple changes to simplify and clarify the tests in test_util.py. Use Path.touch instead of Path.write_bytes(b"") in the tests. I guess I had formerly had the idea that pathlib gained Path.touch recently, but that is not at all the case. (This applies to all operating systems, but it is the more minor of the two changes.) Run some tests of Windows-specific environment variables on Windows only, and simplify the tests accordingly. The reason I think this makes sense now, even though it wouldn't have been the best idea when those tests were first introduced, is detailed in the 6a8ed70 message. The latter is one of the changes listed in the "What is not done here?" section of #1745. Or it is part of that--perhaps some of the other tests, more directly concerning rmtree, can also be simplified, I'm not sure. (Right now I'm thinking that will become clearer if it is considered together with further progress toward #790 rather than beforehand.)
Open Graph Description: These are a couple changes to simplify and clarify the tests in test_util.py. Use Path.touch instead of Path.write_bytes(b"") in the tests. I guess I had formerly had the idea that pathl...
X Description: These are a couple changes to simplify and clarify the tests in test_util.py. Use Path.touch instead of Path.write_bytes(b"") in the tests. I guess I had formerly had the idea th...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1774
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:04f9c6e2-4d32-6810-3fcc-881ffe723e37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9122:D042D:5FF875:861DE3:6968CC9E |
| html-safe-nonce | 855a9a9f24ca2ea20d0a11549e8b65c19fbe2a123b81c6ef474057d495e17206 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTIyOkQwNDJEOjVGRjg3NTo4NjFERTM6Njk2OENDOUUiLCJ2aXNpdG9yX2lkIjoiNjMyMTgyMDg3OTM4NTMxNjUxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2f9c134f18d68eaf8c2784a256997fecde83610a31c5c42bdfb7c3d5022af4c0 |
| hovercard-subject-tag | pull_request:1649586365 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1774/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | These are a couple changes to simplify and clarify the tests in test_util.py. Use Path.touch instead of Path.write_bytes(b"") in the tests. I guess I had formerly had the idea that pathl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af2d7af0cc84117fa10bf36808605ef68a335c9d8a804b9cdac55f8d77230b00 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc844ab6ee0198cc2e2c142dcb8a5c2a61d48743 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width