Title: Replace xfail with gc.collect in TestSubmodule.test_rename by EliahKagan · Pull Request #1767 · gitpython-developers/GitPython · GitHub
Open Graph Title: Replace xfail with gc.collect in TestSubmodule.test_rename by EliahKagan · Pull Request #1767 · gitpython-developers/GitPython
X Title: Replace xfail with gc.collect in TestSubmodule.test_rename by EliahKagan · Pull Request #1767 · gitpython-developers/GitPython
Description: In various places in the code, a conditional gc.collect() is used to allow a test to finish its work (and pass). This adds one more such place. It accordingly removes an xfail marking. TestSubmodule.test_rename now passes on all combinations of platform and Python version. Like the xfail condition, running gc.collect() here is conditional, being done only in the specific situation the PermissionError occurs. Besides that it does not always run even on Windows (only in 3.12 and later), this resembles various other conditional and non-conditional gc.collect calls. The situation is a bit odd, but I think that's--albeit by a fairly slight margin--more of a reason to convert the xfail into a gc.collect() than to refrain from doing so. Context #1745 (under "Which versions should we test?"), and also 82c361e, 0b7ee17, and various other less interesting commits, provide further context about this test and the PermissionError on Windows that does not occur prior to 3.12. Because PermissionError error message is about another process having the file open, #790 seems relevant. But this does not happen in a call to git.util.rmtree. One call is enough, now It had previously appeared to me that two calls to gc.collect were required, but I am unable to reproduce that. It may have been specific to how I was running it on my system at that time. The need for only one call may have been brought about by changes to the code in the mean time, but I have tested that only one call appears required even without the changes in #1765. (Perhaps #1753 contributed? I think most likely not, though.)
Open Graph Description: In various places in the code, a conditional gc.collect() is used to allow a test to finish its work (and pass). This adds one more such place. It accordingly removes an xfail marking. TestSubmodul...
X Description: In various places in the code, a conditional gc.collect() is used to allow a test to finish its work (and pass). This adds one more such place. It accordingly removes an xfail marking. TestSubmodul...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1767
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:be60c1dd-764e-f912-76c0-3288132140c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B0E8:28645D:1DDD6B:2A60EF:6968AFC7 |
| html-safe-nonce | f2ac3bec190c11446e4c05875b40eccc86c47566d6f1d33ee956b2518502eb61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEU4OjI4NjQ1RDoxRERENkI6MkE2MEVGOjY5NjhBRkM3IiwidmlzaXRvcl9pZCI6IjI5NTgzMDgzMTIwMDk0NTM1MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f6ee7ffb5515e98ce7fd01db69fe58339463d86c17ccccbea2ffb17c92700ea4 |
| hovercard-subject-tag | pull_request:1640832874 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1767/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | In various places in the code, a conditional gc.collect() is used to allow a test to finish its work (and pass). This adds one more such place. It accordingly removes an xfail marking. TestSubmodul... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width