Title: Extract all "import gc" to module level by EliahKagan · Pull Request #1765 · gitpython-developers/GitPython · GitHub
Open Graph Title: Extract all "import gc" to module level by EliahKagan · Pull Request #1765 · gitpython-developers/GitPython
X Title: Extract all "import gc" to module level by EliahKagan · Pull Request #1765 · gitpython-developers/GitPython
Description: The gc module was already imported at module scope in git/repo/base.py. Although it was moved recently, it is not a new addition. It has been present for about seven years, since f1a82e4 (#555). Importing the top-level git module or any submodule of it runs that import statement: >>> import sys >>> "gc" in sys.modules False >>> import git >>> "gc" in sys.modules True Because the gc module is already imported, reimporting it is fast. Imports that there is no specific reason to do locally should be at module scope. Having them local decreased readability, in part because of how black inserts a black line between them and gc.collect() calls they are imported to allow. An alternative to this change would be to remove the preexisting top-level import gc (there is also another one in the test suite) and replace it with a local import as well. I am unsure if that would affect performance and, if so, whether the effect would be good or bad, since the small delay of the import might potentially be less desirable to an application if it occurs while the work of the application is already in progress. If a gc.collect() call runs as a consequence of a finally block or __del__ method being called during interpreter shutdown, then in (very) rare cases the variable may have been set to None. But this does not appear to have been the intent behind making the imports local. More importantly, a local import should not be expected to succeed, or the imported module usable, in such a situation. Conceptually unrelated to this, it looks like the newly released version of black fails to install on Cygwin in the test-cygwin.yml workflow. I expect failures from that workflow for this reason. Although unrelated, there is of course no rush on this PR, and if that does happen, it would prevent any Cygwin tests from running until a fix or workaround is applied. If that is fixed first, this PR could be rebased. If this problem doesn't happen, then it is resolved or somehow specific to the setup in my fork and on my local machine, in which case probably nothing has to be done about it.
Open Graph Description: The gc module was already imported at module scope in git/repo/base.py. Although it was moved recently, it is not a new addition. It has been present for about seven years, since f1a82e4 (#555). Im...
X Description: The gc module was already imported at module scope in git/repo/base.py. Although it was moved recently, it is not a new addition. It has been present for about seven years, since f1a82e4 (#555). Im...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1765
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:2c4236f6-5e7e-80c3-c271-fa493550fee9 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 93DE:3162C3:C3FC:10AEF:69693BA4 |
| html-safe-nonce | c0079eb2ab1ab622f9bf48dc3aedff0fd82602697291dc251c19f1c41741b257 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0RFOjMxNjJDMzpDM0ZDOjEwQUVGOjY5NjkzQkE0IiwidmlzaXRvcl9pZCI6IjMzNjQxNzc4NTk1Nzg1MTAyNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7838ab24b224ae4858769c6581c2c969c2cc6faf97614d18026c654e7912b68b |
| hovercard-subject-tag | pull_request:1640581401 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1765/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | The gc module was already imported at module scope in git/repo/base.py. Although it was moved recently, it is not a new addition. It has been present for about seven years, since f1a82e4 (#555). Im... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width