Title: Overhaul noqa directives by EliahKagan · Pull Request #1760 · gitpython-developers/GitPython · GitHub
Open Graph Title: Overhaul noqa directives by EliahKagan · Pull Request #1760 · gitpython-developers/GitPython
X Title: Overhaul noqa directives by EliahKagan · Pull Request #1760 · gitpython-developers/GitPython
Description: This includes a few small style improvements I had missed in previous PRs, but consist mostly of improvements to how and where noqa directives are used, and code changes (intended to be non-breaking and uncontroversial) to go along with that. The directives are made more precise. They always give specific errors/warnings to suppress, both where that had been intended but idiosyncrasies of the syntax caused them to be broader, and where nothing had been given before. All noqa directives are now statement-level rather than file-level. Some of those that were no longer needed are removed with no other associated change. Some others are removed together with minimal changes to the code they complained about or to other noqa directives that had been ineffective (such as due to their placement). The commit messages have some more information about the details of the changes.
Open Graph Description: This includes a few small style improvements I had missed in previous PRs, but consist mostly of improvements to how and where noqa directives are used, and code changes (intended to be non-breakin...
X Description: This includes a few small style improvements I had missed in previous PRs, but consist mostly of improvements to how and where noqa directives are used, and code changes (intended to be non-breakin...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1760
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c0c50a16-1b96-98a9-7a0e-c8ae0e0e99e3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC44:12F8:9E6E66:E137D2:69690163 |
| html-safe-nonce | 617617255afef814c6aa9bbc64ca09715b4b67c9e0129cacd68b7f9a6b14c641 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzQ0OjEyRjg6OUU2RTY2OkUxMzdEMjo2OTY5MDE2MyIsInZpc2l0b3JfaWQiOiIyNDI0NzI2NjY2MzUzMzc3NjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7d4cb2f351d3338253893b8ced29c0258918a3a60badb24e7719b39411e23c2f |
| hovercard-subject-tag | pull_request:1636916663 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1760/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This includes a few small style improvements I had missed in previous PRs, but consist mostly of improvements to how and where noqa directives are used, and code changes (intended to be non-breakin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fd1938215b152e2c6a29cf56fec07fd9f91f1203 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width