Title: Document some minor subtleties in test_util.py by EliahKagan · Pull Request #1749 · gitpython-developers/GitPython · GitHub
Open Graph Title: Document some minor subtleties in test_util.py by EliahKagan · Pull Request #1749 · gitpython-developers/GitPython
X Title: Document some minor subtleties in test_util.py by EliahKagan · Pull Request #1749 · gitpython-developers/GitPython
Description: These are a couple of small comment/docstring tweaks in test_util.py that didn't quite make it into #1739: Some of the tests mock chmod functions to better simulate the inability to change permissions on a file, but they don't mock the lchmod variants, at least one of which (the pathlib.Path method) can exists even when calling it is guaranteed to fail. This comments to explain why they are not mocked (it is so we observe such failures). There are a few collections of parameter sets used in the cygpath tests, some of which existed before any recent changes, and another of which was introduced in #1729 to help with precise xfail markings. This adds "docstrings" to those that didn't have them, and converts the comment on the one that did into such a docstring. The impact is minor, but I think this helps with clarity a little bit. The reason I deferred these changes is that I originally had begun by mocking out the lchmod functions. While writing the commit message for that, I realized my reasoning wasn't very good, because it is more important that any exceptions due to platform incompatibility be observed and cause the test to fail, in the event that those functions are ever used (directly or indirectly) in the code under test. That original commit is in the history--it's the first commit here--but the test code changes are undone subsequently. I considered just dropping the commit, but it seems to me that having it in the history may make things a little clearer. (However, I can rebase it out if desired.)
Open Graph Description: These are a couple of small comment/docstring tweaks in test_util.py that didn't quite make it into #1739: Some of the tests mock chmod functions to better simulate the inability to change per...
X Description: These are a couple of small comment/docstring tweaks in test_util.py that didn't quite make it into #1739: Some of the tests mock chmod functions to better simulate the inability to change...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1749
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b8e3abaa-6fcb-c04f-d27f-fa4565e6a3f8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C32:2D44C5:567F6D:785DA5:6968CC55 |
| html-safe-nonce | 3057537c719de76b287c67fc11c4c66dae1ddad10f072089d0ea581e16dc3f5b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzMyOjJENDRDNTo1NjdGNkQ6Nzg1REE1OjY5NjhDQzU1IiwidmlzaXRvcl9pZCI6IjY1NDg5NDQ4NDAyNjE0MjIxNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 985c2246b8c4e4bdbdecf8c1b1b6fe502e370cd4a2a757fb9060e8d188dbef1b |
| hovercard-subject-tag | pull_request:1621146395 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1749/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | These are a couple of small comment/docstring tweaks in test_util.py that didn't quite make it into #1739: Some of the tests mock chmod functions to better simulate the inability to change per... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | af2d7af0cc84117fa10bf36808605ef68a335c9d8a804b9cdac55f8d77230b00 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc844ab6ee0198cc2e2c142dcb8a5c2a61d48743 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width