René's URL Explorer Experiment


Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython · GitHub

Open Graph Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython

X Title: Reorganize test_util and make xfail marks precise by EliahKagan · Pull Request #1729 · gitpython-developers/GitPython

Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spurious XPASS statuses make the information from xfail-marked tests less informative, and the specific problem focused on in #1728. In addition, this also refactors some other recently added tests in test_util.py, to achieve the goals described there. I may soon propose other changes that build on this in other ways, but that is not included here. Basically, this just: Reorganizes the tests in test_util.py, making some of them pure pytest tests. Uses @pytest.mark.parametrize with the marks= argument to apply @pytest.mark.xfail to exactly the cases that currently need it, and no others. Refactors some of the other tests' use of ad-hoc fixtures, removing some code reuse that I had added that was making the code harder rather than easier to maintain, and achieving useful code reuse more cleanly with a custom pytest fixture. This includes two changes to the pytest plugins that are used. Since those affect development dependencies, I list them here with their rationales: Because the parametrized mark supports nesting, generating test cases for the Cartesian product of the specified parameters, I removed the use of subtests for now, and thus also the pytest-subtests development dependency. Subtests, and that plugin, could be brought back in the future if they prove useful for another reason, but right now there are no longer any subtests in the test suite. This is the change I had anticipated in #1700 (comment). I have added and used pytest-mock for some of the new pure pytest tests that had previously used nested with-statements. The pytest-mock plugin provides a mocker fixture that wraps the functionality of unittest.mock but automatically unpatches everything (and in the reverse order in which it was patched) after the test. Since we do not yet have CI for native Windows, I have manually run the test_util.py tests on Windows (on Windows 10, with Python 3.12) to verify that they produce the expected statuses (including no FAIL statuses).

Open Graph Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur...

X Description: Fixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1729

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:abd1dfbf-d56a-ec73-5c09-84b0c1104d1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB8E:22D04:13A7C55:1BD1176:6969016B
html-safe-nonce6b040a5fb232ce2db84ae21fc67f0e41e852981d85bb747b3acd307c92ce7fa5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjhFOjIyRDA0OjEzQTdDNTU6MUJEMTE3Njo2OTY5MDE2QiIsInZpc2l0b3JfaWQiOiI4Mjg1NDg1MzA4NzEwNTUxOTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6ec056363239e6df9c436d3741de07a0313160febff79a9299cfb6fb9cdda4dd
hovercard-subject-tagpull_request:1586314663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1729/files
twitter:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1771172?s=400&v=4
og:image:altFixes #1728 This makes xfail markings precise in the test suite, so that only tests that are expected to fail (and do fail on CI) are marked xfail. This addresses both the general problem that spur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefd1938215b152e2c6a29cf56fec07fd9f91f1203
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/1729/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1729%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1729%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1729/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1729/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1729/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:xfailhttps://github.com/EliahKagan/GitPython/tree/xfail
Conversation 8 https://github.com/gitpython-developers/GitPython/pull/1729
Commits 10 https://github.com/gitpython-developers/GitPython/pull/1729/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/1729/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/1729/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
Reorganize test_util and make xfail marks precise https://github.com/gitpython-developers/GitPython/pull/1729/files#top
Show all changes 10 commits https://github.com/gitpython-developers/GitPython/pull/1729/files
09826f4 Revise test_util comment style EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/09826f4ecf9cacc617627ad54452235d449345fc
e2fa5e2 Pull rmtree tests out of TestUtils class EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/e2fa5e2225fbcdd0f34108f1b9a6b4b1e8653555
c4da058 Pull HIDE_WINDOWS_*_ERRORS tests out of TestUtils EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/c4da058ba99aafd16a01b0692b13bafb833969ac
aa1799f Remove file_not_found_tmpdir fixture for TestRmtree EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/aa1799f0de449c50fb5e35ba0befb4ff2fc6f98c
2fb8c64 Move permission_error_tmpdir skips to test cases EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/2fb8c64a898e4c4bf93febadffa216c8a6ff2411
1dccb8e Pull cygpath and decygpath tests out of TestUtils EliahKagan Oct 24, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/1dccb8e3a90ad2227d0689171526212cd5740451
487bc8a Start making TestCygpath xfail markings granular EliahKagan Oct 25, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/487bc8aa71ebfdfa455c4037d0bbcfd51eb4997c
c3d3d1e Finish making TestCygpath xfail markings granular EliahKagan Oct 25, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/c3d3d1ecd3ce8a2ab547a7f1d94590a676f36d18
7d98f94 Let all TestRmtree tests run on 3.7 EliahKagan Oct 27, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/7d98f94a60b6108709fc1155cd23c3224880ec94
ba5bc45 Better explain the Windows and Unix cases EliahKagan Oct 29, 2023 https://github.com/gitpython-developers/GitPython/pull/1729/commits/ba5bc45b3a570ef628dba97128ce4bfe9856d736
Clear filters https://github.com/gitpython-developers/GitPython/pull/1729/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
pyproject.toml https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
test-requirements.txt https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-fac4c6890301d4de5c3f4266837803d5240c84a3d8b6c735bbc6a64c39d2f94e
test_util.py https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
pyproject.tomlhttps://github.com/gitpython-developers/GitPython/pull/1729/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
View file https://github.com/EliahKagan/GitPython/blob/ba5bc45b3a570ef628dba97128ce4bfe9856d736/pyproject.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1729/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
test-requirements.txthttps://github.com/gitpython-developers/GitPython/pull/1729/files#diff-fac4c6890301d4de5c3f4266837803d5240c84a3d8b6c735bbc6a64c39d2f94e
View file https://github.com/EliahKagan/GitPython/blob/ba5bc45b3a570ef628dba97128ce4bfe9856d736/test-requirements.txt
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1729/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1729/files#diff-fac4c6890301d4de5c3f4266837803d5240c84a3d8b6c735bbc6a64c39d2f94e
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1729/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.