Title: Never modify sys.path by EliahKagan · Pull Request #1720 · gitpython-developers/GitPython · GitHub
Open Graph Title: Never modify sys.path by EliahKagan · Pull Request #1720 · gitpython-developers/GitPython
X Title: Never modify sys.path by EliahKagan · Pull Request #1720 · gitpython-developers/GitPython
Description: Fixes #1717 Main changes This removes the logic that, under some (most) circumstances when not using a version from PyPI, would insert the location of the gitdb git-submodule near the front of sys.path. As noted in #1717, the specific way this was being done was not causing the git-submodule's version of gitdb to actually be used. But it was still modifying sys.path, which this now prevents. Test changes The installation test, which had verified the insertion into sys.path, is modified accordingly, except that for now the check that the very first sys.path entry is undisturbed is kept in place. Because we do not yet have native Windows tests on CI, and it is the sort of test that is likely to reveal OS-specific problems (it had ben broken on Windows in the past), I have verified locally that this test still passes on a native Windows system (though I only tried it with Python 3.12.) Documentation changes Per #1717 (comment), I've also added a subsection at the end of the installation instructions in README.md to explain how the gitdb and smmap dependencies can be installed editably in the uncommon case that using them rather than packages installed from PyPI is desired. This new material in the readme should probably be moved into the documentation in doc/ later, once that documentation is revised and updated. Related I have proposed a roughly corresponding change to gitdb in gitdb#102.
Open Graph Description: Fixes #1717 Main changes This removes the logic that, under some (most) circumstances when not using a version from PyPI, would insert the location of the gitdb git-submodule near the front of sys....
X Description: Fixes #1717 Main changes This removes the logic that, under some (most) circumstances when not using a version from PyPI, would insert the location of the gitdb git-submodule near the front of sys....
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1720
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:110ab738-aa60-3404-007f-12613951effd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E424:301010:7888E0:A5E27A:6968AF94 |
| html-safe-nonce | 193f0cc3bf0b9b245817ddc986af5b84b04249e500d7c9d88c8c291eb0caf4d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDI0OjMwMTAxMDo3ODg4RTA6QTVFMjdBOjY5NjhBRjk0IiwidmlzaXRvcl9pZCI6IjI3OTcxMjc5OTA1MDU5NDI5MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5126f112735a4dbcc1ea3b5bc3b51d7653863bfd822275bdeea1c54f46bda065 |
| hovercard-subject-tag | pull_request:1566421920 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1720/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #1717 Main changes This removes the logic that, under some (most) circumstances when not using a version from PyPI, would insert the location of the gitdb git-submodule near the front of sys.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width