René's URL Explorer Experiment

Title: Fix bugs affecting exception wrapping in rmtree callback by EliahKagan · Pull Request #1700 · gitpython-developers/GitPython · GitHub

Open Graph Title: Fix bugs affecting exception wrapping in rmtree callback by EliahKagan · Pull Request #1700 · gitpython-developers/GitPython

X Title: Fix bugs affecting exception wrapping in rmtree callback by EliahKagan · Pull Request #1700 · gitpython-developers/GitPython

Description: GitPython is a python library used to interact with Git repositories. - Fix bugs affecting exception wrapping in rmtree callback by EliahKagan · Pull Request #1700 · gitpython-developers/GitPython

Open Graph Description: Fixes #1698 Fixes #1699 May close #1571 This takes the approaches I suggested in #1698 and #1699 for those two issues. It also adds tests for both the already-working behavior and the new behavior....

X Description: Fixes #1698 Fixes #1699 May close #1571 This takes the approaches I suggested in #1698 and #1699 for those two issues. It also adds tests for both the already-working behavior and the new behavior....

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1700

X: @github

direct link

Domain: github.com

route-pattern	/:user_id/:repository/pull/:id/commits(.:format)
route-controller	pull_requests
route-action	commits
fetch-nonce	v2:7449d853-b1be-7720-4f32-1edc50717fa7
current-catalog-service-hash	ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id	BF60:A67A9:A8EA6A:E9D8C4:6968B84E
html-safe-nonce	90ad3a9d52327267060930d753519ab8fda39f02963f5bb1b845ac635304d6ab
visitor-payload	eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjYwOkE2N0E5OkE4RUE2QTpFOUQ4QzQ6Njk2OEI4NEUiLCJ2aXNpdG9yX2lkIjoiNjM5NDExNjg0NDEwODE2NzI0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac	1c3392b281f1d2a1e176e13ced1838e0fd4aa29fe3e266a7e9caf324c4377ce8
hovercard-subject-tag	pull_request:1547659758
github-keyboard-shortcuts	repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification	Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url	https://collector.github.com/github/collect
analytics-location	///pull_requests/show/commits
fb:app_id	1401488693436528
apple-itunes-app	app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1700/commits
twitter:image	https://opengraph.githubassets.com/25a30a5bf396f6af416036385e6188f76335d36597b52d031dcd3496834cd126/gitpython-developers/GitPython/pull/1700
twitter:card	summary_large_image
og:image	https://opengraph.githubassets.com/25a30a5bf396f6af416036385e6188f76335d36597b52d031dcd3496834cd126/gitpython-developers/GitPython/pull/1700
og:image:alt	Fixes #1698 Fixes #1699 May close #1571 This takes the approaches I suggested in #1698 and #1699 for those two issues. It also adds tests for both the already-working behavior and the new behavior....
og:image:width	1200
og:image:height	600
og:site_name	GitHub
og:type	object
og:author:username	EliahKagan
hostname	github.com
expected-hostname	github.com
None	fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98
turbo-cache-control	no-cache
go-import	github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id	503709
octolytics-dimension-user_login	gitpython-developers
octolytics-dimension-repository_id	1126087
octolytics-dimension-repository_nwo	gitpython-developers/GitPython
octolytics-dimension-repository_public	true
octolytics-dimension-repository_is_fork	false
octolytics-dimension-repository_network_root_id	1126087
octolytics-dimension-repository_network_root_nwo	gitpython-developers/GitPython
turbo-body-classes	logged-out env-production page-responsive
disable-turbo	false
browser-stats-url	https://api.github.com/_private/browser/stats
browser-errors-url	https://api.github.com/_private/browser/errors
release	3223a6503d318917691422cdadfbe16cd8fb21e5
ui-target	full
theme-color	#1e2327
color-scheme	light dark

Links:

Skip to content	https://github.com/gitpython-developers/GitPython/pull/1700/commits#start-of-content
	https://github.com/
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1700%2Fcommits
GitHub CopilotWrite better code with AI	https://github.com/features/copilot
GitHub SparkBuild and deploy intelligent apps	https://github.com/features/spark
GitHub ModelsManage and compare prompts	https://github.com/features/models
MCP RegistryNewIntegrate external tools	https://github.com/mcp
ActionsAutomate any workflow	https://github.com/features/actions
CodespacesInstant dev environments	https://github.com/features/codespaces
IssuesPlan and track work	https://github.com/features/issues
Code ReviewManage code changes	https://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilities	https://github.com/security/advanced-security
Code securitySecure your code as you build	https://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they start	https://github.com/security/advanced-security/secret-protection
Why GitHub	https://github.com/why-github
Documentation	https://docs.github.com
Blog	https://github.blog
Changelog	https://github.blog/changelog
Marketplace	https://github.com/marketplace
View all features	https://github.com/features
Enterprises	https://github.com/enterprise
Small and medium teams	https://github.com/team
Startups	https://github.com/enterprise/startups
Nonprofits	https://github.com/solutions/industry/nonprofits
App Modernization	https://github.com/solutions/use-case/app-modernization
DevSecOps	https://github.com/solutions/use-case/devsecops
DevOps	https://github.com/solutions/use-case/devops
CI/CD	https://github.com/solutions/use-case/ci-cd
View all use cases	https://github.com/solutions/use-case
Healthcare	https://github.com/solutions/industry/healthcare
Financial services	https://github.com/solutions/industry/financial-services
Manufacturing	https://github.com/solutions/industry/manufacturing
Government	https://github.com/solutions/industry/government
View all industries	https://github.com/solutions/industry
View all solutions	https://github.com/solutions
AI	https://github.com/resources/articles?topic=ai
Software Development	https://github.com/resources/articles?topic=software-development
DevOps	https://github.com/resources/articles?topic=devops
Security	https://github.com/resources/articles?topic=security
View all topics	https://github.com/resources/articles
Customer stories	https://github.com/customer-stories
Events & webinars	https://github.com/resources/events
Ebooks & reports	https://github.com/resources/whitepapers
Business insights	https://github.com/solutions/executive-insights
GitHub Skills	https://skills.github.com
Documentation	https://docs.github.com
Customer support	https://support.github.com
Community forum	https://github.com/orgs/community/discussions
Trust center	https://github.com/trust-center
Partners	https://github.com/partners
GitHub SponsorsFund open source developers	https://github.com/sponsors
Security Lab	https://securitylab.github.com
Maintainer Community	https://maintainers.github.com
Accelerator	https://github.com/accelerator
Archive Program	https://archiveprogram.github.com
Topics	https://github.com/topics
Trending	https://github.com/trending
Collections	https://github.com/collections
Enterprise platformAI-powered developer platform	https://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security features	https://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI features	https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support	https://github.com/premium-support
Pricing	https://github.com/pricing
Search syntax tips	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentation	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1700%2Fcommits
Sign up	https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reload	https://github.com/gitpython-developers/GitPython/pull/1700/commits
Reload	https://github.com/gitpython-developers/GitPython/pull/1700/commits
Reload	https://github.com/gitpython-developers/GitPython/pull/1700/commits
gitpython-developers	https://github.com/gitpython-developers
GitPython	https://github.com/gitpython-developers/GitPython
Please reload this page	https://github.com/gitpython-developers/GitPython/pull/1700/commits
Notifications	https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964	https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k	https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code	https://github.com/gitpython-developers/GitPython
Issues 169	https://github.com/gitpython-developers/GitPython/issues
Pull requests 8	https://github.com/gitpython-developers/GitPython/pulls
Discussions	https://github.com/gitpython-developers/GitPython/discussions
Actions	https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page.	https://github.com/gitpython-developers/GitPython/security
Please reload this page	https://github.com/gitpython-developers/GitPython/pull/1700/commits
Insights	https://github.com/gitpython-developers/GitPython/pulse
Code	https://github.com/gitpython-developers/GitPython
Issues	https://github.com/gitpython-developers/GitPython/issues
Pull requests	https://github.com/gitpython-developers/GitPython/pulls
Discussions	https://github.com/gitpython-developers/GitPython/discussions
Actions	https://github.com/gitpython-developers/GitPython/actions
Security	https://github.com/gitpython-developers/GitPython/security
Insights	https://github.com/gitpython-developers/GitPython/pulse
Byron	https://github.com/Byron
gitpython-developers:main	https://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:untangle-skips	https://github.com/EliahKagan/GitPython/tree/untangle-skips
Conversation	https://github.com/gitpython-developers/GitPython/pull/1700
Commits19 (19)	https://github.com/gitpython-developers/GitPython/pull/1700/commits
Checks	https://github.com/gitpython-developers/GitPython/pull/1700/checks
Files changed	https://github.com/gitpython-developers/GitPython/pull/1700/files
Fix bugs affecting exception wrapping in rmtree callback	https://github.com/gitpython-developers/GitPython/pull/1700/commits#top
Byron	https://github.com/Byron
gitpython-developers:main	https://github.com/gitpython-developers/GitPython/tree/main
EliahKagan:untangle-skips	https://github.com/EliahKagan/GitPython/tree/untangle-skips
Add a missing PermissionError xfail on Windows	https://github.com/gitpython-developers/GitPython/pull/1700/commits/28142630f6c3bfd83dcd654c102235c5c00075e5
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
2814263	https://github.com/gitpython-developers/GitPython/pull/1700/commits/28142630f6c3bfd83dcd654c102235c5c00075e5
	https://github.com/gitpython-developers/GitPython/tree/28142630f6c3bfd83dcd654c102235c5c00075e5
Update "ACTUALLY skipped by" comments	https://github.com/gitpython-developers/GitPython/pull/1700/commits/fba59aa32119e22b1b300fea8959c0abd3c9f863
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
fba59aa	https://github.com/gitpython-developers/GitPython/pull/1700/commits/fba59aa32119e22b1b300fea8959c0abd3c9f863
	https://github.com/gitpython-developers/GitPython/tree/fba59aa32119e22b1b300fea8959c0abd3c9f863
Eliminate duplicate rmtree try-except logic	https://github.com/gitpython-developers/GitPython/pull/1700/commits/5039df3560d321af1746bbecbeb1b2838daf7f91
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
5039df3	https://github.com/gitpython-developers/GitPython/pull/1700/commits/5039df3560d321af1746bbecbeb1b2838daf7f91
	https://github.com/gitpython-developers/GitPython/tree/5039df3560d321af1746bbecbeb1b2838daf7f91
Clean up git.objects.submodule.base imports	https://github.com/gitpython-developers/GitPython/pull/1700/commits/683a3eeba838bb786bb1f334c963deb8e13eed0f
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
683a3ee	https://github.com/gitpython-developers/GitPython/pull/1700/commits/683a3eeba838bb786bb1f334c963deb8e13eed0f
	https://github.com/gitpython-developers/GitPython/tree/683a3eeba838bb786bb1f334c963deb8e13eed0f
Test current expected behavior of git.util.rmtree	https://github.com/gitpython-developers/GitPython/pull/1700/commits/2fe7f3c4a6f9870bb332761740c883a2c2ff2487
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
2fe7f3c	https://github.com/gitpython-developers/GitPython/pull/1700/commits/2fe7f3c4a6f9870bb332761740c883a2c2ff2487
	https://github.com/gitpython-developers/GitPython/tree/2fe7f3c4a6f9870bb332761740c883a2c2ff2487
Test situations git.util.rmtree shouldn't wrap	https://github.com/gitpython-developers/GitPython/pull/1700/commits/d42cd721112d748c35d0abd11ba8dfc71052e864
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
d42cd72	https://github.com/gitpython-developers/GitPython/pull/1700/commits/d42cd721112d748c35d0abd11ba8dfc71052e864
	https://github.com/gitpython-developers/GitPython/tree/d42cd721112d748c35d0abd11ba8dfc71052e864
Fix test bug that assumed staticmethod callability	https://github.com/gitpython-developers/GitPython/pull/1700/commits/2a32e25bbd1cb42878928ef57a57100a17366202
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
2a32e25	https://github.com/gitpython-developers/GitPython/pull/1700/commits/2a32e25bbd1cb42878928ef57a57100a17366202
	https://github.com/gitpython-developers/GitPython/tree/2a32e25bbd1cb42878928ef57a57100a17366202
In rmtree, have onerror catch only PermissionError	https://github.com/gitpython-developers/GitPython/pull/1700/commits/b8e009e8d31e32a2c0e247e0a7dc41ccdd3556e7
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
b8e009e	https://github.com/gitpython-developers/GitPython/pull/1700/commits/b8e009e8d31e32a2c0e247e0a7dc41ccdd3556e7
	https://github.com/gitpython-developers/GitPython/tree/b8e009e8d31e32a2c0e247e0a7dc41ccdd3556e7
Fix onerror callback type hinting, improve style	https://github.com/gitpython-developers/GitPython/pull/1700/commits/ccbb2732efcfa265568f1a535a8b746ed07ed82a
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
ccbb273	https://github.com/gitpython-developers/GitPython/pull/1700/commits/ccbb2732efcfa265568f1a535a8b746ed07ed82a
	https://github.com/gitpython-developers/GitPython/tree/ccbb2732efcfa265568f1a535a8b746ed07ed82a
Use onexc callback where supported	https://github.com/gitpython-developers/GitPython/pull/1700/commits/0b88012471d8021fffe61beb9d058840c0235f5d
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
0b88012	https://github.com/gitpython-developers/GitPython/pull/1700/commits/0b88012471d8021fffe61beb9d058840c0235f5d
	https://github.com/gitpython-developers/GitPython/tree/0b88012471d8021fffe61beb9d058840c0235f5d
Revise and update rmtree docstrings and comments	https://github.com/gitpython-developers/GitPython/pull/1700/commits/7dd59043b44d0f2169304f90da74b1b2f7f2b02e
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
7dd5904	https://github.com/gitpython-developers/GitPython/pull/1700/commits/7dd59043b44d0f2169304f90da74b1b2f7f2b02e
	https://github.com/gitpython-developers/GitPython/tree/7dd59043b44d0f2169304f90da74b1b2f7f2b02e
Clean up test_util, reorganizing for readability	https://github.com/gitpython-developers/GitPython/pull/1700/commits/196cfbeefb5ab0844d37da0b1e010b6ee7cf9041
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
196cfbe	https://github.com/gitpython-developers/GitPython/pull/1700/commits/196cfbeefb5ab0844d37da0b1e010b6ee7cf9041
	https://github.com/gitpython-developers/GitPython/tree/196cfbeefb5ab0844d37da0b1e010b6ee7cf9041
Add initial test_env_vars_for_windows_tests	https://github.com/gitpython-developers/GitPython/pull/1700/commits/100ab989fcba0b1d1bd89b5b4b41ea5014da3d82
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
100ab98	https://github.com/gitpython-developers/GitPython/pull/1700/commits/100ab989fcba0b1d1bd89b5b4b41ea5014da3d82
	https://github.com/gitpython-developers/GitPython/tree/100ab989fcba0b1d1bd89b5b4b41ea5014da3d82
Warn if HIDE_WINDOWS_*_ERRORS set in environment	https://github.com/gitpython-developers/GitPython/pull/1700/commits/7604da185ce12b9ef540aff3255580db02c88268
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
7604da1	https://github.com/gitpython-developers/GitPython/pull/1700/commits/7604da185ce12b9ef540aff3255580db02c88268
	https://github.com/gitpython-developers/GitPython/tree/7604da185ce12b9ef540aff3255580db02c88268
Make HIDE_* attributes always bool	https://github.com/gitpython-developers/GitPython/pull/1700/commits/eb51277e73ca274e3948a3f009168d210dd587ca
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
eb51277	https://github.com/gitpython-developers/GitPython/pull/1700/commits/eb51277e73ca274e3948a3f009168d210dd587ca
	https://github.com/gitpython-developers/GitPython/tree/eb51277e73ca274e3948a3f009168d210dd587ca
Treat false-seeming HIDE_* env var values as false	https://github.com/gitpython-developers/GitPython/pull/1700/commits/333896b4447c56093fa4ae402a3d22491928ce29
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
333896b	https://github.com/gitpython-developers/GitPython/pull/1700/commits/333896b4447c56093fa4ae402a3d22491928ce29
	https://github.com/gitpython-developers/GitPython/tree/333896b4447c56093fa4ae402a3d22491928ce29
Simplify HIDE_* env var test; add missing cases	https://github.com/gitpython-developers/GitPython/pull/1700/commits/c11b36660382c713709b36bbca1da8a1acb3a4ec
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
c11b366	https://github.com/gitpython-developers/GitPython/pull/1700/commits/c11b36660382c713709b36bbca1da8a1acb3a4ec
	https://github.com/gitpython-developers/GitPython/tree/c11b36660382c713709b36bbca1da8a1acb3a4ec
Further cleanup in test_util (on new tests)	https://github.com/gitpython-developers/GitPython/pull/1700/commits/f0e15e8935580a4e4dc4ed6490c9e1b229493e19
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
f0e15e8	https://github.com/gitpython-developers/GitPython/pull/1700/commits/f0e15e8935580a4e4dc4ed6490c9e1b229493e19
	https://github.com/gitpython-developers/GitPython/tree/f0e15e8935580a4e4dc4ed6490c9e1b229493e19
Clarify a test helper docstring	https://github.com/gitpython-developers/GitPython/pull/1700/commits/a9b05ece674578d3417f8969ade17b06ab287ffe
	https://github.com/EliahKagan
EliahKagan	https://github.com/gitpython-developers/GitPython/commits?author=EliahKagan
a9b05ec	https://github.com/gitpython-developers/GitPython/pull/1700/commits/a9b05ece674578d3417f8969ade17b06ab287ffe
	https://github.com/gitpython-developers/GitPython/tree/a9b05ece674578d3417f8969ade17b06ab287ffe
	https://github.com
Terms	https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy	https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security	https://github.com/security
Status	https://www.githubstatus.com/
Community	https://github.community/
Docs	https://docs.github.com/
Contact	https://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.