Title: Fix rollback bug in SymbolicReference.set_reference by EliahKagan · Pull Request #1675 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix rollback bug in SymbolicReference.set_reference by EliahKagan · Pull Request #1675 · gitpython-developers/GitPython
X Title: Fix rollback bug in SymbolicReference.set_reference by EliahKagan · Pull Request #1675 · gitpython-developers/GitPython
Description: Fixes #1669 This fixes the specific bug in SymbolicReference.set_reference where the local call to ldf.rollback is never made. It also refactors, both here and elsewhere, to make try-finally logic clearer and simpler, and in some cases to replace it. This is to prevent such bugs from recurring, or at least make them easier to spot. This cleanup corresponds to try-finally cleanup done in the test suite as part of the larger PR #1673, but none of these changes were necessary to fix flake8 warnings, nor directly related to changes that were necessary for that, and it seemed like including this in that PR would make it broader than would be ideal. As noted in #1669 (comment), the best solution to this, along with much of the rest of what may fall under the current resource leakage limitation, would be to make LockedFD and other classes with __del__ methods into context managers and use them as such (typically with with-statements) throughout GitPython. This does not make that change, as it is only a narrow-bugfix and cleanup PR. From #1669 (comment) I am uncertain if this pull request would be considered to be in good shape without additions or other changes. However, I figured that, by opening it, these extra changes I did in git/ while working on #1673, that I considered useful but not topically suitable for inclusion in #1673, can be reviewed and, if considered valuable, merged with or without refinements.
Open Graph Description: Fixes #1669 This fixes the specific bug in SymbolicReference.set_reference where the local call to ldf.rollback is never made. It also refactors, both here and elsewhere, to make try-finally logic ...
X Description: Fixes #1669 This fixes the specific bug in SymbolicReference.set_reference where the local call to ldf.rollback is never made. It also refactors, both here and elsewhere, to make try-finally logic ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1675
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ee1a53e2-40ef-7824-2b30-c0e3df026460 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F6A:2A545B:C5CA21:10CD306:69687F81 |
| html-safe-nonce | 73bfa01e55f32533d05bb98a27f3668dd710d880fbd1ad87a9d7431916325133 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjZBOjJBNTQ1QjpDNUNBMjE6MTBDRDMwNjo2OTY4N0Y4MSIsInZpc2l0b3JfaWQiOiIyNTE3Mzc0MzMzNjA4Mjk2MzIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 202aff14caa8c20dcb2ce26cf4dab627cb039a101b597da651ae95d7d7dfdb19 |
| hovercard-subject-tag | pull_request:1524662896 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1675/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | Fixes #1669 This fixes the specific bug in SymbolicReference.set_reference where the local call to ldf.rollback is never made. It also refactors, both here and elsewhere, to make try-finally logic ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fef287f17234b4529a4b112a3d47fe8551e32ddd |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width