Title: Omit py_modules in setup by EliahKagan · Pull Request #1665 · gitpython-developers/GitPython · GitHub
Open Graph Title: Omit py_modules in setup by EliahKagan · Pull Request #1665 · gitpython-developers/GitPython
X Title: Omit py_modules in setup by EliahKagan · Pull Request #1665 · gitpython-developers/GitPython
Description: This removes the py_modules keyword argument in the call to setup, and further shortens/simplifies setup.py by removing the newly unused build_py_modules function. The packages keyword argument already covers this, because we have no loose modules that are included in the distribution, and the call to find_packages: Omits everything in test/ because it is directed to do so in the call. Omits the gitdb/ directory (currently existing as a git submodule, not to be confused with Python submodules). This is because the ext/ directory that contains it does not itself directly contain an __init__.py file, so ext/ is not a traditional package, yet ext/ is contained and found inside the directory git/ that is a traditional package, so the ext/ directory is not a namespace package either. Includes all other modules, recursively, because they are all in a recursive traditional package structure under git/ that find_packages recognizes. To verify that this includes the same files in the built wheel and sdist distributions, I have listed the contents of the wheel with unzip -l and the sdist .tar.gz file with tar tf both before and after this change, verifying they list all the same entries before and after.
Open Graph Description: This removes the py_modules keyword argument in the call to setup, and further shortens/simplifies setup.py by removing the newly unused build_py_modules function. The packages keyword argument alr...
X Description: This removes the py_modules keyword argument in the call to setup, and further shortens/simplifies setup.py by removing the newly unused build_py_modules function. The packages keyword argument alr...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1665
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3a77ece7-9af4-7627-3cf2-89f1ba71a05e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DED6:28CDAA:22DADEB:314A4C3:6969141D |
| html-safe-nonce | 0358af9bd33907feb0e55e862f08335c3843df71c8afc943628004480f32e2f7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQ2OjI4Q0RBQToyMkRBREVCOjMxNEE0QzM6Njk2OTE0MUQiLCJ2aXNpdG9yX2lkIjoiMzMwNjQ1MTg1ODQ0Mjc1MzA1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3cdc81c86272ad87ad5bf1e1446bc1a8918aa3d3e0e5e4e6a76838a9d24e0323 |
| hovercard-subject-tag | pull_request:1518828955 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1665/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This removes the py_modules keyword argument in the call to setup, and further shortens/simplifies setup.py by removing the newly unused build_py_modules function. The packages keyword argument alr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | afd5814870f8609d217a32dd3bccc05a5df5f5699df4d458c242e80fdfddcc2e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 572e69339f2401a569f15071214cbbee314ea8bb |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width