Title: Remove spurious executable permissions by EliahKagan · Pull Request #1658 · gitpython-developers/GitPython · GitHub
Open Graph Title: Remove spurious executable permissions by EliahKagan · Pull Request #1658 · gitpython-developers/GitPython
X Title: Remove spurious executable permissions by EliahKagan · Pull Request #1658 · gitpython-developers/GitPython
Description: This unsets the executable bit on test/fixtures/diff_mode_only, which was the only of the fixture files to be marked executable, and which is not a script. This is a minor change, but it didn't really fit in any other PRs I was opening, so I made it its own. The benefit of this change is that it useful to be able to run ls -l to get a sense of what all the files are in a repository that make sense to execute as scripts. This provides useful information in the case of init-tests-after-clone.sh and setup.py, but not in the case of test/fixtures/diff_mode_only, test/fixtures/diff_mode_only seems to have gotten marked as executable during one of several moves. This could happen due to being on a volume that doesn't support Unix-style executable permissions, accessed on a system that otherwise does, depending on how that volume is mounted. (For example, I see this on Windows when accessing the native Windows filesystem from WSL, and on Ubuntu when using an external drive formatted NTFS.) I don't think the +x on that file was ever intended, and removing it doesn't break any tests. In some ways of viewing a permissions-only change, a PR's review tab wrongly claims it is to an "empty file." That is not the case here, even if the GitHub UI claims it: the file is nonempty, I'm just not changing any of its content.
Open Graph Description: This unsets the executable bit on test/fixtures/diff_mode_only, which was the only of the fixture files to be marked executable, and which is not a script. This is a minor change, but it didn't...
X Description: This unsets the executable bit on test/fixtures/diff_mode_only, which was the only of the fixture files to be marked executable, and which is not a script. This is a minor change, but it didn&#...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1658
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7d948e99-97c7-5275-ff16-038fc510ca60 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA72:1AEA34:1127AF9:17CDF9C:6968AF82 |
| html-safe-nonce | 3c88cac2bb48ec3c7a481bb78e8d08f2408d8ab3bbbccb2724ad5e7e9fc42395 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTcyOjFBRUEzNDoxMTI3QUY5OjE3Q0RGOUM6Njk2OEFGODIiLCJ2aXNpdG9yX2lkIjoiMzc3MDc3NzQ2MTM5MzUwMjA4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e739b89d591fdf5a0aa3439d787b6ceeb05ee8891cdc066d3eac6d2f07026e3f |
| hovercard-subject-tag | pull_request:1511394345 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1658/files |
| twitter:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1771172?s=400&v=4 |
| og:image:alt | This unsets the executable bit on test/fixtures/diff_mode_only, which was the only of the fixture files to be marked executable, and which is not a script. This is a minor change, but it didn't... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width