Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython · GitHub
Open Graph Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython
X Title: use tempfile.TemporaryDirectory & fix clone_from_unsafe_protocol tests by obfusk · Pull Request #1531 · gitpython-developers/GitPython
Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol instead of protocol); replaces /tmp/pwn w/ {tmp_file}; clones into tmp_dir / "repo" instead of tmp_dir, since tmp_dir / "pwn" will never exist afterwards otherwise; adds a test w/ ext::sh that actually allows the protocol, to ensure we're not missing anything in the other tests.
Open Graph Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins...
X Description: uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1531
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b4ea1f60-ac8b-75cd-595f-461fb48f665a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B0E0:33A330:860E7B:BAFBE7:696907EF |
| html-safe-nonce | 2394b307521a7cea68af3e5ddd2da4da38d72fd39ed1cab9aebde0b30197c140 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEUwOjMzQTMzMDo4NjBFN0I6QkFGQkU3OjY5NjkwN0VGIiwidmlzaXRvcl9pZCI6IjUxMDU5Mjc2NjgwOTExMjc3OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b9d503376c6f528c27008b308cc5d534619b96e819da291e11b7875ec117d6f1 |
| hovercard-subject-tag | pull_request:1189695271 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1531/files |
| twitter:image | https://avatars.githubusercontent.com/u/1260687?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1260687?s=400&v=4 |
| og:image:alt | uses tempfile.TemporaryDirectory() instead of tempfile.mkdtemp() to not leave temporary files behind (though that still happens in some other tests that are harder to fix); fixes a typo (procol ins... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e6156bd4ef9f2dc8dadf4c49a8f7ed8532186388cef72eda3ccb9f0ab3b8cfca |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ee2210c3e58153aae53400c942f8a7b4bbb43ec4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width