René's URL Explorer Experiment


Title: feat(cmd): add the `strip_newline` flag by toku-sa-n · Pull Request #1423 · gitpython-developers/GitPython · GitHub

Open Graph Title: feat(cmd): add the `strip_newline` flag by toku-sa-n · Pull Request #1423 · gitpython-developers/GitPython

X Title: feat(cmd): add the `strip_newline` flag by toku-sa-n · Pull Request #1423 · gitpython-developers/GitPython

Description: This PR adds the strip_newline flag to the Git.execute method. When this flag is set to True, it will trim the trailing \n. The default value is True for backward compatibility. Setting it to False is helpful for, e.g., the git show output, especially with the binary file, as the missing \n may invalidate the file. Looking at the first some bytes and checking if the output is binary or not is another option to prevent making an invalid binary file. Still, I chose to add a parameter because it is easy to implement, is fully backward compatible, and doesn't add many lines to the source code. Fixes: #1377 By the way, do we need to handle stderr too?

Open Graph Description: This PR adds the strip_newline flag to the Git.execute method. When this flag is set to True, it will trim the trailing \n. The default value is True for backward compatibility. Setting it to False...

X Description: This PR adds the strip_newline flag to the Git.execute method. When this flag is set to True, it will trim the trailing \n. The default value is True for backward compatibility. Setting it to False...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1423

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3452493e-6f4f-de24-72a6-414a2f853f5e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCED4:105924:9DCBC7:D76A89:69695863
html-safe-nonce5569d7c14cb7c1b6e8a49534d0688a2d11d3ea1eef0ab634b0399eddf44d940a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQ0OjEwNTkyNDo5RENCQzc6RDc2QTg5OjY5Njk1ODYzIiwidmlzaXRvcl9pZCI6Ijc4MDUwNzMzMDA4ODk2MjI2MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccb11b570faf26f2e9296ebeadcc3dc3908e9f1b727b89f2ed7a39305d3f237c6
hovercard-subject-tagpull_request:901575636
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1423/files
twitter:imagehttps://avatars.githubusercontent.com/u/42336339?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/42336339?s=400&v=4
og:image:altThis PR adds the strip_newline flag to the Git.execute method. When this flag is set to True, it will trim the trailing \n. The default value is True for backward compatibility. Setting it to False...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9db5f28da7e24035385d7f349f17890cbe016a939ddd7952be0f07b862094f5a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4e59fe66217d3c72925af2a341ae3a8f2b5b5b2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/1423/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1423%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1423%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1423/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1423/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1423/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1423/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1423/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:mainhttps://github.com/gitpython-developers/GitPython/tree/main
toku-sa-n:strip_newline_optionhttps://github.com/toku-sa-n/GitPython/tree/strip_newline_option
Conversation 2 https://github.com/gitpython-developers/GitPython/pull/1423
Commits 5 https://github.com/gitpython-developers/GitPython/pull/1423/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/1423/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/1423/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1423/files
feat(cmd): add the strip_newline flag https://github.com/gitpython-developers/GitPython/pull/1423/files#top
Show all changes 5 commits https://github.com/gitpython-developers/GitPython/pull/1423/files
e4360ae feat(cmd): add the `strip_newline` flag toku-sa-n Apr 6, 2022 https://github.com/gitpython-developers/GitPython/pull/1423/commits/e4360aea32aad11bf3c54b0dc0a6cabb21b5e687
946b64b chore: add me to AUTHORS toku-sa-n Apr 6, 2022 https://github.com/gitpython-developers/GitPython/pull/1423/commits/946b64b62bdc9fb3447b6daf0053b11a2e4c5277
49150e7 chore: `s/strip_newline/&_in_stdout` toku-sa-n Apr 7, 2022 https://github.com/gitpython-developers/GitPython/pull/1423/commits/49150e79c6f7a19a0d61a5ea6864b9ac140264ff
2a50f28 docs: escape with backticks toku-sa-n Apr 7, 2022 https://github.com/gitpython-developers/GitPython/pull/1423/commits/2a50f28fa3571e3d2c4d5ea86f4243f715717269
17b2b12 fix(docs): remove an unexpected blank line toku-sa-n Apr 7, 2022 https://github.com/gitpython-developers/GitPython/pull/1423/commits/17b2b128fb6d6f987b47d60ccb1ab09b8fc238ea
Clear filters https://github.com/gitpython-developers/GitPython/pull/1423/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1423/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1423/files
AUTHORS https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
cmd.py https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
test_repo.py https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
AUTHORShttps://github.com/gitpython-developers/GitPython/pull/1423/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
View file https://github.com/toku-sa-n/GitPython/blob/17b2b128fb6d6f987b47d60ccb1ab09b8fc238ea/AUTHORS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1423/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/toku-sa-n/GitPython/blob/17b2b128fb6d6f987b47d60ccb1ab09b8fc238ea/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1423/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
test/test_repo.pyhttps://github.com/gitpython-developers/GitPython/pull/1423/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
View file https://github.com/toku-sa-n/GitPython/blob/17b2b128fb6d6f987b47d60ccb1ab09b8fc238ea/test/test_repo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1423/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1423/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.