Title: Surface fetch/pull/push kill_after_timeout and reset default to None by sroet · Pull Request #1340 · gitpython-developers/GitPython · GitHub
Open Graph Title: Surface fetch/pull/push kill_after_timeout and reset default to None by sroet · Pull Request #1340 · gitpython-developers/GitPython
X Title: Surface fetch/pull/push kill_after_timeout and reset default to None by sroet · Pull Request #1340 · gitpython-developers/GitPython
Description: (hopefully) closes #1339 This PR does as of e058c4c : renames timeout to kill_after_timeout and set default to None instead of 10 s Surfaces kill_after_timeout to user facing functions (remote. pull/push/fetch) refactor AutoInterrupt so we can ._terminate() the underlying process and grab status codes from terminated processes Add a class variable AutoInterrupt._status_code_if_terminate; if non-zero it overrides any status code from the process in _terminate. This can be used to prevent race conditions in tests, as described in this comment Some history of the commits (while trying a different strategy): aafb300 changes the default timeout to 60 s 1d26515 allows push, pull and fetch keyword timeout that will be propagated down febd4fe alters some tests to use the old 10 s timeout for fetch and pull 4113d01 also alters a test call to pull to add a timeout of 10s c55a8e3 fixes the test suite 7df33f3 sets the default timeout to None if the current default is too lose, users can now give their own timeout
Open Graph Description: (hopefully) closes #1339 This PR does as of e058c4c : renames timeout to kill_after_timeout and set default to None instead of 10 s Surfaces kill_after_timeout to user facing functions (remote. ...
X Description: (hopefully) closes #1339 This PR does as of e058c4c : renames timeout to kill_after_timeout and set default to None instead of 10 s Surfaces kill_after_timeout to user facing functions (remote. ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1340
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:b0452b6f-5690-64dc-7c54-059c0d2d40f4 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A5EA:D449A:2E5F914:3C66A6F:696B7CFE |
| html-safe-nonce | def89502a9d030edf385a6f240caede02f2665b4fc9914ce1592fc1f4d458ee8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUVBOkQ0NDlBOjJFNUY5MTQ6M0M2NkE2Rjo2OTZCN0NGRSIsInZpc2l0b3JfaWQiOiIzMDg1OTg0MDAxNjU4OTQ0NzY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 82155dbf38240667e749eb0df923aabcd3d3064347d6e2182347ec703d0c67e2 |
| hovercard-subject-tag | pull_request:731394201 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1340/checks |
| twitter:image | https://avatars.githubusercontent.com/u/19587267?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19587267?s=400&v=4 |
| og:image:alt | (hopefully) closes #1339 This PR does as of e058c4c : renames timeout to kill_after_timeout and set default to None instead of 10 s Surfaces kill_after_timeout to user facing functions (remote. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width