Title: revert util.expand_path() due to regression by Yobmod · Pull Request #1240 · gitpython-developers/GitPython · GitHub
Open Graph Title: revert util.expand_path() due to regression by Yobmod · Pull Request #1240 · gitpython-developers/GitPython
X Title: revert util.expand_path() due to regression by Yobmod · Pull Request #1240 · gitpython-developers/GitPython
Description: Hopefully to fix #1238. The orginal change (commit 39eb0e6) was attempting to get mypy consistant with expand_path(None), as it doesn't like try except blocks without some type narrowing and expanduser doesn't accept None (triggering the Exception). Added mypy ignores for now, to allow CI to pass. It passes tests either way, so can't be sure, but the traceback points to an overload of cmd.Git.excecute(), wherein cwd = self._working_dir. That leads to Git.init(), where self._working_dir = expand_user(working_dir)
Open Graph Description: Hopefully to fix #1238. The orginal change (commit 39eb0e6) was attempting to get mypy consistant with expand_path(None), as it doesn't like try except blocks without some type narrowing and ex...
X Description: Hopefully to fix #1238. The orginal change (commit 39eb0e6) was attempting to get mypy consistant with expand_path(None), as it doesn't like try except blocks without some type narrowing an...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1240
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9d089015-3fd3-acba-09ac-8d48b54ba2d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84DA:10A5B6:BE43EA:10491F5:6969E8FF |
| html-safe-nonce | adf8f2b8395f12517357b7b580ea08efe6c6347bd97602671cb852155f0dedd2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NERBOjEwQTVCNjpCRTQzRUE6MTA0OTFGNTo2OTY5RThGRiIsInZpc2l0b3JfaWQiOiIyNzA1MTY0ODEwOTI2MTAzMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | db30f09b05bf250f4a8c1f8412b0c41c91f9106a716eeb6cccd3f6fb7072b1b3 |
| hovercard-subject-tag | pull_request:644263799 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1240/files |
| twitter:image | https://avatars.githubusercontent.com/u/22235459?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22235459?s=400&v=4 |
| og:image:alt | Hopefully to fix #1238. The orginal change (commit 39eb0e6) was attempting to get mypy consistant with expand_path(None), as it doesn't like try except blocks without some type narrowing and ex... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width