René's URL Explorer Experiment


Title: Replace password in URI by stars if present to avoid leaking secrets in logs by mickours · Pull Request #1198 · gitpython-developers/GitPython · GitHub

Open Graph Title: Replace password in URI by stars if present to avoid leaking secrets in logs by mickours · Pull Request #1198 · gitpython-developers/GitPython

X Title: Replace password in URI by stars if present to avoid leaking secrets in logs by mickours · Pull Request #1198 · gitpython-developers/GitPython

Description: Currently, if you use a git URI containing a password like https://username:pass@git.example.com/project and an exception occurs during a git clone the password is printed in the logs. It also happen when the logging is at debug level. To avoid secrets to leak in the logs, this patch replace the password by a fix amount of stars (******).

Open Graph Description: Currently, if you use a git URI containing a password like https://username:pass@git.example.com/project and an exception occurs during a git clone the password is printed in the logs. It also happ...

X Description: Currently, if you use a git URI containing a password like https://username:pass@git.example.com/project and an exception occurs during a git clone the password is printed in the logs. It also happ...

Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1198

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0a249b6f-b9a2-9b73-c1c0-cfa478400bce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9344:189C33:283697D:349567F:696B6474
html-safe-noncebc4d862e05d0c3cfae56b8e53097cfc1e377f967d6ccb098f5850038de770f78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzQ0OjE4OUMzMzoyODM2OTdEOjM0OTU2N0Y6Njk2QjY0NzQiLCJ2aXNpdG9yX2lkIjoiNjY5MDcxMDc3NTcxNTgxNjU2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac39f620843fab01e3c1ebee42f03be1cc2c472b3a5e37db2956aba2b3767f9301
hovercard-subject-tagpull_request:591444202
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1198/files
twitter:imagehttps://avatars.githubusercontent.com/u/837312?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/837312?s=400&v=4
og:image:altCurrently, if you use a git URI containing a password like https://username:pass@git.example.com/project and an exception occurs during a git clone the password is printed in the logs. It also happ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/pull/1198/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1198%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fpull%2F1198%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1198/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1198/files
Reloadhttps://github.com/gitpython-developers/GitPython/pull/1198/files
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgitpython-developers%2FGitPython%2Fissues%2Fnew%2Fchoose
Byronhttps://github.com/Byron
gitpython-developers:masterhttps://github.com/gitpython-developers/GitPython/tree/master
RyaxTech:replace-password-in-uri-by-starshttps://github.com/RyaxTech/GitPython/tree/replace-password-in-uri-by-stars
Conversation 21 https://github.com/gitpython-developers/GitPython/pull/1198
Commits 8 https://github.com/gitpython-developers/GitPython/pull/1198/commits
Checks 0 https://github.com/gitpython-developers/GitPython/pull/1198/checks
Files changed https://github.com/gitpython-developers/GitPython/pull/1198/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
Replace password in URI by stars if present to avoid leaking secrets in logs https://github.com/gitpython-developers/GitPython/pull/1198/files#top
Show all changes 8 commits https://github.com/gitpython-developers/GitPython/pull/1198/files
3a4fc6a Replace password in URI by stars if present + test mickours Mar 11, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/3a4fc6abfb3b39237f557372262ac79f45b6a9fa
1d43a75 Use format instead of f-string mickours Mar 12, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/1d43a751e578e859e03350f198bca77244ba53b5
b650c4f Better assert message mickours Mar 12, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/b650c4f28bda658d1f3471882520698ef7fb3af6
f7180d5 Use urllib instead of custom parsing mickours Mar 15, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/f7180d50f785ec28963e12e647d269650ad89b31
f7968d1 Put remove password in the utils and use it also in cmd.execute mickours Mar 15, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/f7968d136276607115907267b3be89c3ff9acd03
50cbafc Add more test and remove password also from error logs mickours Mar 15, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/50cbafc690e5692a16148dbde9de680be70ddbd1
ffddedf Use copy and not inplace remove password + working case test mickours Mar 16, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/ffddedf5467df993b7a42fbd15afacb901bca6d7
d283c83 Use continue instead of raising error mickours Mar 18, 2021 https://github.com/gitpython-developers/GitPython/pull/1198/commits/d283c83c43f5e52a1a14e55b35ffe85a780615d8
Clear filters https://github.com/gitpython-developers/GitPython/pull/1198/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
cmd.py https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
base.py https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
util.py https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test_repo.py https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
test_util.py https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
git/cmd.pyhttps://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
View file https://github.com/RyaxTech/GitPython/blob/d283c83c43f5e52a1a14e55b35ffe85a780615d8/git/cmd.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1198/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-35a18a749eb4d6efad45e56e78a9554926be5526e2ba2159b44311e718450e88
git/repo/base.pyhttps://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
View file https://github.com/RyaxTech/GitPython/blob/d283c83c43f5e52a1a14e55b35ffe85a780615d8/git/repo/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1198/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-3cc1aaf2f1e2bc1341d3f71ceec44b2762b981280b4d162e26327bd558721fe1
git/util.pyhttps://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
View file https://github.com/RyaxTech/GitPython/blob/d283c83c43f5e52a1a14e55b35ffe85a780615d8/git/util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1198/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-cb13395ac36dd593e722ec548880a091f39732af5c934880144d1a95de67944e
test/test_repo.pyhttps://github.com/gitpython-developers/GitPython/pull/1198/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
View file https://github.com/RyaxTech/GitPython/blob/d283c83c43f5e52a1a14e55b35ffe85a780615d8/test/test_repo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1198/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
Byronhttps://github.com/Byron
Mar 17, 2021https://github.com/gitpython-developers/GitPython/pull/1198/files#r595839244
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
mickourshttps://github.com/mickours
Mar 18, 2021https://github.com/gitpython-developers/GitPython/pull/1198/files#r597002223
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
Byronhttps://github.com/Byron
Mar 19, 2021https://github.com/gitpython-developers/GitPython/pull/1198/files#r597594419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gitpython-developers/GitPython/pull/1198/files
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-f50d635cf31b095a03b42fc1a73681a9c4025bbeb58b81e72588ba37e00cff87
test/test_util.pyhttps://github.com/gitpython-developers/GitPython/pull/1198/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
View file https://github.com/RyaxTech/GitPython/blob/d283c83c43f5e52a1a14e55b35ffe85a780615d8/test/test_util.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gitpython-developers/GitPython/pull/1198/{{ revealButtonHref }}
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com/gitpython-developers/GitPython/pull/1198/files#diff-62b93f19eeb2c5ff6e26eaccf3f63ee6641e87f3a6ccfc2ffb0dec86925ae245
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.