Title: Add initial types to repo/fun.py by Yobmod · Pull Request #1192 · gitpython-developers/GitPython · GitHub
Open Graph Title: Add initial types to repo/fun.py by Yobmod · Pull Request #1192 · gitpython-developers/GitPython
X Title: Add initial types to repo/fun.py by Yobmod · Pull Request #1192 · gitpython-developers/GitPython
Description: Hi, This adds types to base.py and fun.py. All annotations are consistant according to both mypy and pyright (but will need refining once whole lib is typed). I've used an alias (TBD, 'to be determined') for Any to show places where I was unsure of the type, but i'm sure it should be more specific than Any. i've avoided changing any runtime code as much as possible, except: i've used Union[str, os._pathlike] to annotate path arguments. Where this showed errors due to use of string-only methods, i've then wrapped the arg in str() within the function. This should mean they are all compatible with pathlib.Paths and pathlib.Purepaths, but that will require tests writing before its official. Adding typeguards: e.g. where git_dir is initialised as None, then assigned later to a string, mypy showed places that needed to be checked that it was actually a string and not still None. This could probably be improved by initializing as "" instead but it touched too much code. changed Except (OSError, IOError) to just Except OSError, as typechecking says it was redundant for python 3. Separate tuple unpacking to seperate lines to provide specific types (unpacked tuples cant be typed yet)
Open Graph Description: Hi, This adds types to base.py and fun.py. All annotations are consistant according to both mypy and pyright (but will need refining once whole lib is typed). I've used an alias (TBD, '...
X Description: Hi, This adds types to base.py and fun.py. All annotations are consistant according to both mypy and pyright (but will need refining once whole lib is typed). I've used an alias (TBD, &...
Opengraph URL: https://github.com/gitpython-developers/GitPython/pull/1192
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2352f961-a0f1-df0b-1d6d-4a9011f70662 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8BA:2A7108:2FE2DA:424816:696A1EAF |
| html-safe-nonce | 3b5eeec69553792e3a66eeb8d8d5bf94109bcc4d19da029072ba43e55e50cdf6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJBOjJBNzEwODoyRkUyREE6NDI0ODE2OjY5NkExRUFGIiwidmlzaXRvcl9pZCI6IjU2Njg5NDkzNzc1MzExMjU0MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bacebd348d524f74665a42e25d02ccbe6f2454a4d9f12f83d4ec35a6f9a07403 |
| hovercard-subject-tag | pull_request:585035918 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/gitpython-developers/GitPython/pull/1192/files |
| twitter:image | https://avatars.githubusercontent.com/u/22235459?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22235459?s=400&v=4 |
| og:image:alt | Hi, This adds types to base.py and fun.py. All annotations are consistant according to both mypy and pyright (but will need refining once whole lib is typed). I've used an alias (TBD, '... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width