René's URL Explorer Experiment


Title: Remove unittest code from non-test code · Issue #790 · gitpython-developers/GitPython · GitHub

Open Graph Title: Remove unittest code from non-test code · Issue #790 · gitpython-developers/GitPython

X Title: Remove unittest code from non-test code · Issue #790 · gitpython-developers/GitPython

Description: I see these imports of unittest in GitPython/git/objects/submodule/base.py Line 6 in a8591a0 from unittest import SkipTest GitPython/git/util.py Line 17 in f3265bd from unittest import SkipTest I generally think that test code should not...

Open Graph Description: I see these imports of unittest in GitPython/git/objects/submodule/base.py Line 6 in a8591a0 from unittest import SkipTest GitPython/git/util.py Line 17 in f3265bd from unittest import SkipTest I g...

X Description: I see these imports of unittest in GitPython/git/objects/submodule/base.py Line 6 in a8591a0 from unittest import SkipTest GitPython/git/util.py Line 17 in f3265bd from unittest import SkipTest I g...

Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/790

X: @github

direct link

Domain: github.com

Hey, it has json ld scripts: 
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove unittest code from non-test code","articleBody":"I see these imports of unittest in\r\n- https://github.com/gitpython-developers/GitPython/blob/a8591a094a768d73e6efb5a698f74d354c989291/git/objects/submodule/base.py#L6\r\n- https://github.com/gitpython-developers/GitPython/blob/f3265bd8beb017890699d093586126ff8af4a3fe/git/util.py#L17\r\n\r\nI generally think that test code should not be built into the business logic. Is there a reason why using a skipIf decorator is insufficient?","author":{"url":"https://github.com/mwatts15","@type":"Person","name":"mwatts15"},"datePublished":"2018-08-23T02:33:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/790/GitPython/issues/790"}
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:291d96a2-fd6a-86a6-2080-570cb9de3665
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB956:31E362:E9EDE4:13A4814:6969A0F4
html-safe-noncec129483e69191473cde1863f75d29fd16f67985fa04d58b33c6ecf59a481ad55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTU2OjMxRTM2MjpFOUVERTQ6MTNBNDgxNDo2OTY5QTBGNCIsInZpc2l0b3JfaWQiOiI5OTc0MjAzODE0NzI2NjE3NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfc81860f9bce3bff0a681805f6fc7b0e591fcc78e74e1d2daa4f6a6a1a9eca01
hovercard-subject-tagissue:353198060
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/790/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2f6edf1ec83ddeac3f1cb6d6cceadf558a51b137c3b80637f5b67031c4eea943/gitpython-developers/GitPython/issues/790
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f6edf1ec83ddeac3f1cb6d6cceadf558a51b137c3b80637f5b67031c4eea943/gitpython-developers/GitPython/issues/790
og:image:altI see these imports of unittest in GitPython/git/objects/submodule/base.py Line 6 in a8591a0 from unittest import SkipTest GitPython/git/util.py Line 17 in f3265bd from unittest import SkipTest I g...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemwatts15
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/issues/790#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fissues%2F790
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fissues%2F790
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/issues/790
Reloadhttps://github.com/gitpython-developers/GitPython/issues/790
Reloadhttps://github.com/gitpython-developers/GitPython/issues/790
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/issues/790
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/issues/790
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
New issuehttps://github.com/login?return_to=https://github.com/gitpython-developers/GitPython/issues/790
New issuehttps://github.com/login?return_to=https://github.com/gitpython-developers/GitPython/issues/790
Remove unittest code from non-test codehttps://github.com/gitpython-developers/GitPython/issues/790#top
acknowledgedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22acknowledged%22
https://github.com/mwatts15
https://github.com/mwatts15
mwatts15https://github.com/mwatts15
on Aug 23, 2018https://github.com/gitpython-developers/GitPython/issues/790#issue-353198060
GitPython/git/objects/submodule/base.pyhttps://github.com/gitpython-developers/GitPython/blob/a8591a094a768d73e6efb5a698f74d354c989291/git/objects/submodule/base.py#L6
a8591a0https://github.com/gitpython-developers/GitPython/commit/a8591a094a768d73e6efb5a698f74d354c989291
GitPython/git/util.pyhttps://github.com/gitpython-developers/GitPython/blob/f3265bd8beb017890699d093586126ff8af4a3fe/git/util.py#L17
f3265bdhttps://github.com/gitpython-developers/GitPython/commit/f3265bd8beb017890699d093586126ff8af4a3fe
acknowledgedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22acknowledged%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.