Title: Timeout error message should be a bytes string · Issue #625 · gitpython-developers/GitPython · GitHub
Open Graph Title: Timeout error message should be a bytes string · Issue #625 · gitpython-developers/GitPython
X Title: Timeout error message should be a bytes string · Issue #625 · gitpython-developers/GitPython
Description: At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a b"..." bytes string and not a regular string. You can see right afterwards in the endswith call that t...
Open Graph Description: At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a b"..." bytes string and not a regular string. You can see righ...
X Description: At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a b"..." bytes string and not a regular string. You ca...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/625
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Timeout error message should be a bytes string","articleBody":"At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a `b\"...\"` bytes string and not a regular string. You can see right afterwards in the endswith call that the string is expected to be a bytes string.\r\n\r\n````\r\n stderr_value = 'Timeout: the command \"%s\" did not complete in %d ' \\\r\n 'secs.' % (\" \".join(command), kill_after_timeout)\r\n ....\r\n if stderr_value.endswith(b\"\\n\"):\r\n stderr_value = stderr_value[:-1]\r\n````\r\n\r\nSo it should be:\r\n\r\n````\r\n stderr_value = b'Timeout: the command \"%s\" did not complete in %d ' \\\r\n b'secs.' % (\" \".join(command), kill_after_timeout)\r\n````","author":{"url":"https://github.com/JoshData","@type":"Person","name":"JoshData"},"datePublished":"2017-05-06T19:22:21Z","url":"https://github.com/gitpython-developers/GitPython/issues/625"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:57e846d2-5101-688f-7871-b153b7d08779 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C61E:19378D:C52C01:10E37D0:6B00B063 |
| html-safe-nonce | 371c3ab7fe517d45e4d174b619a5c8cfd70334872f65efefce73407330250133 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjFFOjE5Mzc4RDpDNTJDMDE6MTBFMzdEMDo2QjAwQjA2MyIsInZpc2l0b3JfaWQiOiI4OTQxNTM0MTUwMDg3NzE2OTYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 73cbd88fca0fe9816c705781543948862037b7b891e57cb9e10ca9f7713a169a |
| hovercard-subject-tag | issue:226797070 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/625/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6e55e7408d039572985462daa7e1cdbe133ee357697f07c2df41b754a5982bb6/gitpython-developers/GitPython/issues/625 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e55e7408d039572985462daa7e1cdbe133ee357697f07c2df41b754a5982bb6/gitpython-developers/GitPython/issues/625 |
| og:image:alt | At https://github.com/gitpython-developers/GitPython/blob/master/git/cmd.py#L650, I think the error message about timeouts should be a b"..." bytes string and not a regular string. You can see righ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoshData |
| hostname | github.com |
| expected-hostname | github.com |
| None | c0dd5f5d6f515a591019ecd66df2c4eab3379c2d3b0777568a90d8c7ae10b79e |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 729d8cda69b3d267995675dfbf89ff27ccf61bf6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width