Title: Fix "known" Windows errored test cases · Issue #525 · gitpython-developers/GitPython · GitHub
Open Graph Title: Fix "known" Windows errored test cases · Issue #525 · gitpython-developers/GitPython
X Title: Fix "known" Windows errored test cases · Issue #525 · gitpython-developers/GitPython
Description: Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok. Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS variable so that we get an ALL GREEN response; th...
Open Graph Description: Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok. Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS variable ...
X Description: Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok. Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/525
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix \"known\" Windows errored test cases","articleBody":"Currently, _Windows_ TestCases on Appveyor established on #519 are [\"artifically\" ok](https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.199).\nBecause in the code, the Test Cases known to fail on have been marked with the [`HIDE_WINDOWS_KNOWN_ERRORS`](https://github.com/gitpython-developers/GitPython/blob/master/git/test/lib/helper.py#L38) variable so that we get an ALL GREEN response; that way we can _detect when new commits break additional TCs on Windows_.\n\nCurrently there are 10 failing TCs (search them with the above var-name), and you can view the errors in this Appveyor job:\n\n https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.196\n\nThe errors are mostly related to 2 issues:\n1. **Unicode:** for those with reading time, I would suggest these 2 contradictory sources: \n - problem: [Everything you did not want to know about Unicode in Python 3](http://lucumr.pocoo.org/2014/5/12/everything-about-unicode/)\n - solution: [PEP 383 -- Non-decodable Bytes in System Character Interfaces](https://www.python.org/dev/peps/pep-0383/) - so using text-mode \n2. **Leaked resources:** these are (possibly memmory-mapped) files that are not deallocated (and hence, not deleted afterwards). Unfortunately, dealing with them might mean that you have to jump projects, as some are inherited from the library projects [_smmp_](https://github.com/gitpython-developers/smmap) and (mostly) [_gitdb_](https://github.com/gitpython-developers/gitfb).\n\nIn order to reproduce the failed TCs on your PC, change locally [`git/test/lib/helper.py:#L38`](https://github.com/gitpython-developers/GitPython/blob/master/git/test/lib/helper.py#L38) from this:\n\n``` python\n HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', True)\n```\n\ninto this:\n\n``` python\n HIDE_WINDOWS_KNOWN_ERRORS = os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', False)\n```\n\nThis issue is about not forgetting these TCs - _asking for help to fix them_.\n","author":{"url":"https://github.com/ankostis","@type":"Person","name":"ankostis"},"datePublished":"2016-10-03T02:33:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/525/GitPython/issues/525"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:69c53481-0603-bbcd-7532-d57a7f2c082a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DF18:39A40D:1921C8:2359F9:6968D43A |
| html-safe-nonce | dcf633ccd294f3a4a81015db656b47c59f0c3e0099b868aeb9a8e6dcf7fa6122 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjE4OjM5QTQwRDoxOTIxQzg6MjM1OUY5OjY5NjhENDNBIiwidmlzaXRvcl9pZCI6IjYwNzU0OTI5MTcxMzc5NTM4NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cdfa339bc6355f55759206afe33a8eb6c3fb926be3b949abce40b458d7378939 |
| hovercard-subject-tag | issue:180553043 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/525/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d4f34defe1899ad969af92726258ecc8e5ff9163cba69f85b61c5c7175be9064/gitpython-developers/GitPython/issues/525 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d4f34defe1899ad969af92726258ecc8e5ff9163cba69f85b61c5c7175be9064/gitpython-developers/GitPython/issues/525 |
| og:image:alt | Currently, Windows TestCases on Appveyor established on #519 are "artifically" ok. Because in the code, the Test Cases known to fail on have been marked with the HIDE_WINDOWS_KNOWN_ERRORS variable ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ankostis |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3c4e9f2fc1db52c609205138be6a397cfde4574cb54d53015014de30dd49f27e |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fb1ea11f8c37dd4dd50347cca70d89824e93788 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width