René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Sorting in TreeModifier.set_done() seems to be inconsistent with git's own sorting -\u003e breaks repository","articleBody":"git enforces tree objects to be sorted by name. GitPython enables users to sort their tree's by calling TreeModifier.set_done(), see:\nhttps://github.com/gitpython-developers/GitPython/blob/master/git/objects/tree.py#L45\n\nThis sorting somehow seems to be inconsistent with git's own sorting mechanism, which means adding a tree might break the git repository. This means \"git fsck\" will throw errors and some remotes (gitlab for example) will no accept the commit. Anyways this bug leaves the git object store in an broken state which cannot be fixed easily, especially if there is much history after the broken commit/tree. I had to delete multiple branches from projects I manage because of their broken state so far.\n\nAbout the problem itself:\n\nGitPython uses core Python functions to sort the file list. This looks correct, but has one major difference to what git itself does. If you have two files beginning with the same chars (for example \"file\" and \"file.second\") their ordering will differ:\n\nWhat git does:\n1) \"file.second\"\n2) \"file\"\n\nWhat GitPython does:\n1) \"file\"\n2) \"file.second\"\n\nWe found this problem using fabdeploit for deployments using git, which allows us to add/removed files to/from the git repository. This way tree's will be modified which means sorting is essential.\n\nPlease fix this. ;-)\n","author":{"url":"https://github.com/ddanier","@type":"Person","name":"ddanier"},"datePublished":"2015-12-08T08:46:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/369/GitPython/issues/369"}