René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Wrong type annotation on `Index.commit` for `parent_commits`","articleBody":"With `GitPython==3.1.42` one can observe following annotation of `parent_commits` argument to `IndexFile.commit` ([1]):\r\n\r\n```\r\n...\r\nparent_commits: Union[Commit_ish, None] = None,\r\n...\r\n```\r\n\r\nwhich is obviously not correct, because that argument just passed unmodified downwards to `Commit.create_from_tree`, which has following annotation instead ([2]):\r\n\r\n```\r\nparent_commits: Union[None, List[\"Commit\"]] = None\r\n```\r\n\r\nThat leads to nasty Mypy warnings when one's trying to use `IndexFile.commit` with anything different than `None`.\r\n\r\n---\r\n[1] - https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/index/base.py#L1080\r\n[2] - https://github.com/gitpython-developers/GitPython/blob/3.1.42/git/objects/commit.py#L506\r\n\r\n","author":{"url":"https://github.com/mshonichev","@type":"Person","name":"mshonichev"},"datePublished":"2024-03-12T12:22:12.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1866/GitPython/issues/1866"}