Title: Note in GitCmdObjectDB should be removed or updated · Issue #1849 · gitpython-developers/GitPython · GitHub
Open Graph Title: Note in GitCmdObjectDB should be removed or updated · Issue #1849 · gitpython-developers/GitPython
X Title: Note in GitCmdObjectDB should be removed or updated · Issue #1849 · gitpython-developers/GitPython
Description: Somewhat similar to #1845, the git.db.GitCmdObjectDB docstring contains this note: GitPython/git/db.py Lines 34 to 35 in 87b8035 :note: For now, we use the git command to do all the lookup, just until we have packs and the other implemen...
Open Graph Description: Somewhat similar to #1845, the git.db.GitCmdObjectDB docstring contains this note: GitPython/git/db.py Lines 34 to 35 in 87b8035 :note: For now, we use the git command to do all the lookup, just un...
X Description: Somewhat similar to #1845, the git.db.GitCmdObjectDB docstring contains this note: GitPython/git/db.py Lines 34 to 35 in 87b8035 :note: For now, we use the git command to do all the lookup, just un...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1849
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Note in GitCmdObjectDB should be removed or updated","articleBody":"Somewhat similar to #1845, the `git.db.GitCmdObjectDB` docstring contains this note:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/87b8035c733018d6e8c097f79b61ad19a987f0d4/git/db.py#L34-L35\r\n\r\nI think that note can simply be removed now, since as far as I know, it does not correspond to a current goal and is not needed to understand the code or how to use it. But I am not confident of this, because I am not sure exactly *what* it is actually referring to. If more features were implemented, would this have been:\r\n\r\n- A change to `GitCmdObjectDB` itself?\r\n- Switching back from `GitCmdObjectDB` to `GitDB`?\r\n- A combination of the two, or something else related?\r\n\r\nThat only needs to be answered if it affects what should happen in that docstring (or elsewhere), which is why I've made this an issue rather than a discussion question.\r\n\r\nI plan to remove it in a forthcoming PR with a number of other docstring revisions, but I'm opening this in case my understanding is mistaken.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2024-02-29T05:37:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1849/GitPython/issues/1849"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:59cb8681-ec73-f79e-7a47-b1b2709d61a0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B686:29543D:3B9CA91:3C54F3D:69685F90 |
| html-safe-nonce | 2cd6efe26ad87fa51f7a6a7c715a9124a0e4a5518a0998a9da2e1ee7bbaf12d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjg2OjI5NTQzRDozQjlDQTkxOjNDNTRGM0Q6Njk2ODVGOTAiLCJ2aXNpdG9yX2lkIjoiMTM1MzM2NzU2NDYzNzc4NzIiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | e74bbcb17daa8c5aa6b83b9ca121f977d8227f97efb95a8e28f3cb21ee4f9f2a |
| hovercard-subject-tag | issue:2160427672 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1849/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c1d032d24f4057a1d47d141e5aaeac19cb6593bec6bcaeef4e1c1a4d8d9f6dc1/gitpython-developers/GitPython/issues/1849 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c1d032d24f4057a1d47d141e5aaeac19cb6593bec6bcaeef4e1c1a4d8d9f6dc1/gitpython-developers/GitPython/issues/1849 |
| og:image:alt | Somewhat similar to #1845, the git.db.GitCmdObjectDB docstring contains this note: GitPython/git/db.py Lines 34 to 35 in 87b8035 :note: For now, we use the git command to do all the lookup, just un... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EliahKagan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fef287f17234b4529a4b112a3d47fe8551e32ddd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width