Title: Note in post_clear_cache docstring may be out of date · Issue #1847 · gitpython-developers/GitPython · GitHub
Open Graph Title: Note in post_clear_cache docstring may be out of date · Issue #1847 · gitpython-developers/GitPython
X Title: Note in post_clear_cache docstring may be out of date · Issue #1847 · gitpython-developers/GitPython
Description: The git.index.util.post_clear_cache decorator has this note in its docstring: GitPython/git/index/util.py Lines 72 to 74 in fe1934c :note: This decorator will not be required once all functions are implemented natively which in fact is p...
Open Graph Description: The git.index.util.post_clear_cache decorator has this note in its docstring: GitPython/git/index/util.py Lines 72 to 74 in fe1934c :note: This decorator will not be required once all functions are...
X Description: The git.index.util.post_clear_cache decorator has this note in its docstring: GitPython/git/index/util.py Lines 72 to 74 in fe1934c :note: This decorator will not be required once all functions are...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1847
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Note in post_clear_cache docstring may be out of date","articleBody":"The `git.index.util.post_clear_cache` decorator has this note in its docstring:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/fe1934c5c90e617d49a38a6c36b1eb17dea47013/git/index/util.py#L72-L74\r\n\r\nThis decorator is applied to the `merge_tree`, `move`, and `remove` methods of `git.index.IndexFile` (and nowhere else).\r\n\r\nAs such, that note in the decorator's docstring suggests an intended design direction for the `IndexFile` implementation in GitPython: that, if performance considerations permit, it should eventually make little to no use of `git` commands, unlike GitPython as a whole.\r\n\r\nBy now, my guess is that the intended direction is known, and my (somewhat less certain) guess is that this goal may have been abandoned, becuase:\r\n\r\n- GitPython is considered to be in maintenance mode (per [the README](https://github.com/gitpython-developers/GitPython?tab=readme-ov-file#development-status)).\r\n- [In a review comment](https://github.com/gitpython-developers/GitPython/pull/1770#discussion_r1425130807), if I understood correctly, you have expressed the hope that `IndexFile` is not heavily used, due to not having reached some of its original design goals.\r\n\r\n*However*, there is also now a longer-term vision for GitPython, beyond maintaining the current feature set, articulated in https://github.com/Byron/gitoxide/discussions/1074 under \"GitPython…\".\r\n\r\nIf in the future the `IndexFile` implementation will be rewritten to use gitoxide's (future) Python bindings, then this docstring note is actually of *greater* relevance than before. But then it should still be updated to no longer characterize the aspiration to implement all of `IndexFile` without git subprocess calls as infeasible for performance reasons. And possibly even to mention gitoxide?\r\n\r\nBecause of that, I'm unsure if this note should be removed or updated (if, if updated, then how), or simply left as-is for the time being.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2024-02-26T18:02:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/1847/GitPython/issues/1847"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7364f572-616a-cb04-45ec-99ba681dbb6b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 951E:18F0FE:106BC92:16B09A2:6968ADD9 |
| html-safe-nonce | 83bae13fc46cee70097f3f950249cc262d474ee4f75ec3c13cfe8d0cb9816638 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTFFOjE4RjBGRToxMDZCQzkyOjE2QjA5QTI6Njk2OEFERDkiLCJ2aXNpdG9yX2lkIjoiNjg2MTAxNDg5NjI0NjA0MjA3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 36f3cd6ddd1e5c08da2b046f1952f35960ed693d67033ace69e490e60c55bd91 |
| hovercard-subject-tag | issue:2154788624 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1847/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c1d032d24f4057a1d47d141e5aaeac19cb6593bec6bcaeef4e1c1a4d8d9f6dc1/gitpython-developers/GitPython/issues/1847 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c1d032d24f4057a1d47d141e5aaeac19cb6593bec6bcaeef4e1c1a4d8d9f6dc1/gitpython-developers/GitPython/issues/1847 |
| og:image:alt | The git.index.util.post_clear_cache decorator has this note in its docstring: GitPython/git/index/util.py Lines 72 to 74 in fe1934c :note: This decorator will not be required once all functions are... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EliahKagan |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width