Title: Unclear rationale for pipe usage in `output_stream` doc · Issue #1845 · gitpython-developers/GitPython · GitHub
Open Graph Title: Unclear rationale for pipe usage in `output_stream` doc · Issue #1845 · gitpython-developers/GitPython
X Title: Unclear rationale for pipe usage in `output_stream` doc · Issue #1845 · gitpython-developers/GitPython
Description: The Git.execute method docstring includes this in the description of its output_stream parameter: GitPython/git/cmd.py Lines 990 to 991 in 1e044ea This feature only has any effect if `as_process` is False. Processes will always be create...
Open Graph Description: The Git.execute method docstring includes this in the description of its output_stream parameter: GitPython/git/cmd.py Lines 990 to 991 in 1e044ea This feature only has any effect if `as_process` i...
X Description: The Git.execute method docstring includes this in the description of its output_stream parameter: GitPython/git/cmd.py Lines 990 to 991 in 1e044ea This feature only has any effect if `as_process` i...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1845
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unclear rationale for pipe usage in `output_stream` doc","articleBody":"The `Git.execute` method docstring includes this in the description of its `output_stream` parameter:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/1e044ead62ea8ae31c879680a8645a0a301053ab/git/cmd.py#L990-L991\r\n\r\nI think this is referring to the `subprocess` module, which could be clarified by changing `subprocess` to `` :mod:`subprocess` ``. But I'm not sure what issues this is referring to, or what information it seeks to impart to the reader.\r\n\r\nTo be clear, I'm not arguing that `output_stream` shouldn't use a pipe. Instead, I think this part of the docstring should be clarified (and I am unsure how to do so).\r\n\r\nIf this intends to be general, and vagueness is acceptable, yet it is considered better to have this \"due to\" clause than simply remove it, *and the issue really is in `subprocess` itself*, then it could be changed to:\r\n\r\n```rst\r\ndue to limitations of :mod:`subprocess`\r\n```\r\n\r\nBut I hope something more specific can be said.\r\n\r\nThe full context is:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/1e044ead62ea8ae31c879680a8645a0a301053ab/git/cmd.py#L987-L994","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2024-02-24T18:40:27.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/1845/GitPython/issues/1845"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4b56c0f4-6840-baed-3516-557f22f5a0ac |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D35E:1F7E80:3A24D27:3AE355C:69685F81 |
| html-safe-nonce | 3ac9817361a702bd9ebc57cd5acd791de99eed403f4a6b89d55b6a9e670d295c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzVFOjFGN0U4MDozQTI0RDI3OjNBRTM1NUM6Njk2ODVGODEiLCJ2aXNpdG9yX2lkIjoiNTAwODgzMDA0NTM1MDI4OTI4MSIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9 |
| visitor-hmac | 5e04ba06fc5fa1cdf2d12ecdf8b49ea545f873a8e721bdb1e936189f4f99ccb8 |
| hovercard-subject-tag | issue:2152439268 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1845/issue_layout |
| twitter:image | https://opengraph.githubassets.com/afe4c9556831435acea4690247580138ae6ec8644950291c3badbdf2543f48ac/gitpython-developers/GitPython/issues/1845 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/afe4c9556831435acea4690247580138ae6ec8644950291c3badbdf2543f48ac/gitpython-developers/GitPython/issues/1845 |
| og:image:alt | The Git.execute method docstring includes this in the description of its output_stream parameter: GitPython/git/cmd.py Lines 990 to 991 in 1e044ea This feature only has any effect if `as_process` i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EliahKagan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 50f46dc2d6192249fd8ebf20e76c800f4f2596d4a5f3ab63dd63a754df154f54 |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fef287f17234b4529a4b112a3d47fe8551e32ddd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width