René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Git.version_info can drop intermediate fields unexpectedly","articleBody":"The `version_info` attribute of `Git` instances drops non-numeric fields, even if they appear before a field that is kept:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/afa575454f85b34800460881cc9c3cd7fe78c8e3/git/cmd.py#L822\r\n\r\nIf a non-numeric field is followed by a numeric field, the effect is to make it look like the field that was actually non-numeric has the value of the subsequent field:\r\n\r\n```text\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (main $=)$ cat \u003efake-git \u003c\u003c'EOF'\r\n\u003e #!/bin/sh\r\n\u003e printf 'git version 1.2a.3 (totally fake)\\n'\r\n\u003e EOF\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (main $%=)$ chmod +x fake-git\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (main $%=)$ python\r\nPython 3.12.1 (main, Dec 10 2023, 15:07:36) [GCC 11.4.0] on linux\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n\u003e\u003e\u003e import git\r\n\u003e\u003e\u003e git.refresh('fake-git')\r\n\u003e\u003e\u003e git.Git().version_info\r\n(1, 3)\r\n```\r\n\r\n(As shown, partially numeric fields that do not wholly parse to a number are non-numeric for this purpose.)\r\n\r\nI think this should either be changed to stop before the first non-numeric field, or kept as it is but with this behavior documented explicitly to reduce confusion. In the latter case, the rationale should be given. The rationale may just be backward compatibility, though I am not sure if that is a sufficient reason to keep this behavior, since it seems unexpected in the cases where it makes a difference. There may be other alternatives that I haven't thought of.\r\n\r\nI think this is a minor issue, since such versions may be rare or nonexistent. `git` version numbers that have a non-numeric field followed by a numeric field are common, such as 2.43.0.windows.1 on Windows. However, GitPython only looks at the first four fields, so the trailing 1 in 2.43.0.windows.1 is not wrongly presented as the field that follows the 0.\r\n\r\nFrom the comments, it looks like this situation was specifically envisioned, suggesting that the exact current behavior may be intended:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/afa575454f85b34800460881cc9c3cd7fe78c8e3/git/cmd.py#L816\r\n\r\nHowever, it seems more likely to me that it was done this way to preserve earlier logic while fixing a specific bug. The `if n.isdigit()` filter was added in 6a61110 (#195).\r\n\r\nFull current code for context:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/afa575454f85b34800460881cc9c3cd7fe78c8e3/git/cmd.py#L814-L826\r\n\r\nThis may make sense to fix at the same time as #1829 and/or #1830, I'm not sure.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2024-02-20T20:48:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/1833/GitPython/issues/1833"}