René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TestGit.test_refresh changes Git.GIT_PYTHON_GIT_EXECUTABLE for other tests","articleBody":"In `test_git.py`, `TestGit.test_refresh` tests the behavior of `git.refresh` when called with bad (nonexistent) and good (existing and usable) explicit `path` arguments.\r\n\r\n- With the bad path, there could only be a lasting change to `Git.GIT_PYTHON_GIT_EXECUTABLE` or other global state due to a bug in `git.refresh`, or in `git.cmd.Git.refresh` or some other code `git.refresh` uses.\r\n- **But with the good path, it remains set as `Git.GIT_PYTHON_GIT_EXECUTABLE`**, and tests that run after `test_refresh` use that instead of the original value that (when tests are run normally in an environment that supports them) is usually `\"git\"`.\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/307f1987596a99fb7b7192d8a5308a0df736ca7b/test/test_git.py#L309-L316\r\n\r\n```text\r\n\u003e\u003e\u003e from git import Git\r\n\u003e\u003e\u003e from test.test_git import TestGit\r\n\u003e\u003e\u003e t = TestGit()\r\n\u003e\u003e\u003e Git.GIT_PYTHON_GIT_EXECUTABLE\r\n'git'\r\n\u003e\u003e\u003e t.test_refresh()\r\n\u003e\u003e\u003e Git.GIT_PYTHON_GIT_EXECUTABLE\r\n'C:\\\\Users\\\\ek\\\\scoop\\\\shims\\\\git.exe'\r\n```\r\n\r\n(That was run on Windows, but the effect is not specific to Windows.)\r\n\r\nAlthough the good-path code can be simplified in the way it finds the absolute path it tests, that is not the cause of this.\r\n\r\n**In the absence of bugs in the code under test**, this change to `Git.GIT_PYTHON_GIT_EXECUTABLE` between some tests and others should make no difference on most working test systems, because both the old and new paths should both work and typically run the same `git` installation. However, if there are bugs related to this attribute that the test suite should reveal or that otherwise interact with tests, then I think this may lead to inaccurate or less useful results, or complicate troubleshooting.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2024-01-25T09:12:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1811/GitPython/issues/1811"}