René's URL Explorer Experiment


Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython · GitHub

Open Graph Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython

X Title: Unclear why fun.py (and others?) shouldn't have a module docstring · Issue #1733 · gitpython-developers/GitPython

Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementation and make it more versatile. # NOTE: Au...

Open Graph Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio...

X Description: While working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio...

Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1733

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unclear why fun.py (and others?) shouldn't have a module docstring","articleBody":"While working on #1725 I noticed the `git.index.fun` module has this comment at the top:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/d5fc6e5337011d54fd2f3ff5aac71dbb38e43ee6/git/index/fun.py#L1-L2\r\n\r\nActually, that exact comment is due to my revision in that PR, but it's revised from:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/add46d9daa7664628ba3512297a2401981694c98/git/index/fun.py#L1-L3\r\n\r\nThis was introduced in 9ccd777, at which time an existing module docstring was converted to a comment instead. Various other module docstrings were also converted to comments. But some modules today do have docstrings. Running `make -C doc html` seems to work fine; I ran it a number of times on Ubuntu and Windows while working on that PR and since.\r\n\r\nI didn't want to assume it was okay to turn that back into a docstring. But either it (and any other top of module comments) should be turned into docstrings, *or* the reason they should not be should be made clearer (and any module docstrings causing problems fixed or converted back to comments).","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2023-11-04T22:19:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/1733/GitPython/issues/1733"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:22235329-2d4f-ef04-e626-535b4000e1d5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBE2C:10C19:3AB428:53ACBE:6968B4EA
html-safe-nonce718ea1734aebaf1fff82d6700a8584636e469dbec9f4614da82e887a76535d34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTJDOjEwQzE5OjNBQjQyODo1M0FDQkU6Njk2OEI0RUEiLCJ2aXNpdG9yX2lkIjoiODc3NzY2Njc1NTI4MzE3MDUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb03159e5212d365d6dc10ac1923c45a4de37d82fd93292a9c4c84d8a2c7d737
hovercard-subject-tagissue:1977532946
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1733/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b85bac128132604b3354cfae87526fff4e7bdc836b2c5f64d77dea9136dd1557/gitpython-developers/GitPython/issues/1733
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b85bac128132604b3354cfae87526fff4e7bdc836b2c5f64d77dea9136dd1557/gitpython-developers/GitPython/issues/1733
og:image:altWhile working on #1725 I noticed the git.index.fun module has this comment at the top: GitPython/git/index/fun.py Lines 1 to 2 in d5fc6e5 # Standalone functions to accompany the index implementatio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEliahKagan
hostnamegithub.com
expected-hostnamegithub.com
Nonefdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98
turbo-cache-controlno-preview
go-importgithub.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git
octolytics-dimension-user_id503709
octolytics-dimension-user_logingitpython-developers
octolytics-dimension-repository_id1126087
octolytics-dimension-repository_nwogitpython-developers/GitPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1126087
octolytics-dimension-repository_network_root_nwogitpython-developers/GitPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3223a6503d318917691422cdadfbe16cd8fb21e5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gitpython-developers/GitPython/issues/1733#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fissues%2F1733
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgitpython-developers%2FGitPython%2Fissues%2F1733
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=gitpython-developers%2FGitPython
Reloadhttps://github.com/gitpython-developers/GitPython/issues/1733
Reloadhttps://github.com/gitpython-developers/GitPython/issues/1733
Reloadhttps://github.com/gitpython-developers/GitPython/issues/1733
gitpython-developers https://github.com/gitpython-developers
GitPythonhttps://github.com/gitpython-developers/GitPython
Please reload this pagehttps://github.com/gitpython-developers/GitPython/issues/1733
Notifications https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Fork 964 https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Star 5k https://github.com/login?return_to=%2Fgitpython-developers%2FGitPython
Code https://github.com/gitpython-developers/GitPython
Issues 169 https://github.com/gitpython-developers/GitPython/issues
Pull requests 8 https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/gitpython-developers/GitPython/security
Please reload this pagehttps://github.com/gitpython-developers/GitPython/issues/1733
Insights https://github.com/gitpython-developers/GitPython/pulse
Code https://github.com/gitpython-developers/GitPython
Issues https://github.com/gitpython-developers/GitPython/issues
Pull requests https://github.com/gitpython-developers/GitPython/pulls
Discussions https://github.com/gitpython-developers/GitPython/discussions
Actions https://github.com/gitpython-developers/GitPython/actions
Security https://github.com/gitpython-developers/GitPython/security
Insights https://github.com/gitpython-developers/GitPython/pulse
New issuehttps://github.com/login?return_to=https://github.com/gitpython-developers/GitPython/issues/1733
New issuehttps://github.com/login?return_to=https://github.com/gitpython-developers/GitPython/issues/1733
#1735https://github.com/gitpython-developers/GitPython/pull/1735
Unclear why fun.py (and others?) shouldn't have a module docstringhttps://github.com/gitpython-developers/GitPython/issues/1733#top
#1735https://github.com/gitpython-developers/GitPython/pull/1735
acknowledgedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22acknowledged%22
help wantedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22help%20wanted%22
https://github.com/EliahKagan
https://github.com/EliahKagan
EliahKaganhttps://github.com/EliahKagan
on Nov 4, 2023https://github.com/gitpython-developers/GitPython/issues/1733#issue-1977532946
#1725https://github.com/gitpython-developers/GitPython/pull/1725
GitPython/git/index/fun.pyhttps://github.com/gitpython-developers/GitPython/blob/d5fc6e5337011d54fd2f3ff5aac71dbb38e43ee6/git/index/fun.py#L1-L2
d5fc6e5https://github.com/gitpython-developers/GitPython/commit/d5fc6e5337011d54fd2f3ff5aac71dbb38e43ee6
GitPython/git/index/fun.pyhttps://github.com/gitpython-developers/GitPython/blob/add46d9daa7664628ba3512297a2401981694c98/git/index/fun.py#L1-L3
add46d9https://github.com/gitpython-developers/GitPython/commit/add46d9daa7664628ba3512297a2401981694c98
9ccd777https://github.com/gitpython-developers/GitPython/commit/9ccd777c386704911734ae4c33a922a5682ac6c8
acknowledgedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22acknowledged%22
help wantedhttps://github.com/gitpython-developers/GitPython/issues?q=state%3Aopen%20label%3A%22help%20wanted%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.