Title: 3.1.38 meant to fix #1656 but there is no supporting gitdb release · Issue #1716 · gitpython-developers/GitPython · GitHub
Open Graph Title: 3.1.38 meant to fix #1656 but there is no supporting gitdb release · Issue #1716 · gitpython-developers/GitPython
X Title: 3.1.38 meant to fix #1656 but there is no supporting gitdb release · Issue #1716 · gitpython-developers/GitPython
Description: To support #1659 here in GitPython, gitdb received #98, and the GitPython repository's submodule reference to gitdb was updated in #1704 (and #1705). Thus #1656 might be1 fixed when developing against the cloned GitPython repository with...
Open Graph Description: To support #1659 here in GitPython, gitdb received #98, and the GitPython repository's submodule reference to gitdb was updated in #1704 (and #1705). Thus #1656 might be1 fixed when developing agai...
X Description: To support #1659 here in GitPython, gitdb received #98, and the GitPython repository's submodule reference to gitdb was updated in #1704 (and #1705). Thus #1656 might be1 fixed when developing ...
Opengraph URL: https://github.com/gitpython-developers/GitPython/issues/1716
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"3.1.38 meant to fix #1656 but there is no supporting gitdb release","articleBody":"To support #1659 here in GitPython, gitdb received [#98](https://github.com/gitpython-developers/gitdb/pull/98), and the GitPython repository's submodule reference to gitdb was updated in #1704 (and #1705). Thus #1656 *might* be\u003csup\u003e**1**\u003c/sup\u003e fixed when developing against the cloned GitPython repository with its gitdb submodule.\r\n\r\n[With the intention](https://github.com/gitpython-developers/GitPython/pull/1659#issuecomment-1765731586) of fixing #1656 in the far more common case of using GitPython via PyPI packages, GitPython 3.1.38 was released. But no new release of gitdb was ever made. Since the fix depends on changes to gitdb, it seems unlikely that 3.1.38 really fixes #1656.\r\n\r\nI think it might be possible to make further refinements to `__all__` and surrounding code, slightly enhancing #1659. However, since 3.1.38 was already released, it seems to me that such things can wait, and that it's reasonable to make a gitdb release (bumping the version in its [`setup.py`](https://github.com/gitpython-developers/gitdb/blob/6a2270635842c4287ae14d94fdc3f9e1ddd0527a/setup.py#L10) and [`gitdb/__init__.py`](https://github.com/gitpython-developers/gitdb/blob/6a2270635842c4287ae14d94fdc3f9e1ddd0527a/gitdb/__init__.py#L31), or changing the [current approach](https://github.com/gitpython-developers/gitdb/blob/6a2270635842c4287ae14d94fdc3f9e1ddd0527a/setup.py#L3-L5) and bumping it in just one place), and to include a dependency bump requiring it the next GitPython release (which could be the same release that ships #1715, if the timing works out).\r\n\r\nI'd be pleased to open pull requests to help with this issue, either following this plan or another one, if that would be helpful.\r\n\r\n---\r\n\r\n\u003csup\u003e**1**\u003c/sup\u003e I had originally said it was likely fixed when developing against the cloned GitPython. However, that is probably not the case. First, most type checkers probably wouldn't understand how that version is added to `sys.path`, and it is probably good design of them not to (since they are *static* checkers). Second, as documented in #1717, it turns out this is never actually happening.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2023-10-18T15:30:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":11},"url":"https://github.com/1716/GitPython/issues/1716"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:930e02a4-a755-280a-8b87-d4e5c7406e13 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 86E8:345462:4D1F4D:6604A5:696923FF |
| html-safe-nonce | 8e260405b42ae6e0f86a31fec9ccd4ac10f6d02799c4a1da0ae48a3486e1b56a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkU4OjM0NTQ2Mjo0RDFGNEQ6NjYwNEE1OjY5NjkyM0ZGIiwidmlzaXRvcl9pZCI6Ijg2MDg2MDMyMTAyODY0NDE0NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 78b9bfa68f78feff9721a881cb3c79cae49bade5c417178bd364104ebce20943 |
| hovercard-subject-tag | issue:1950035723 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gitpython-developers/GitPython/1716/issue_layout |
| twitter:image | https://opengraph.githubassets.com/12c8d20eb7251a967dd49d4f4d0d6e4f46d36d5f766c460d4953f809ad849955/gitpython-developers/GitPython/issues/1716 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12c8d20eb7251a967dd49d4f4d0d6e4f46d36d5f766c460d4953f809ad849955/gitpython-developers/GitPython/issues/1716 |
| og:image:alt | To support #1659 here in GitPython, gitdb received #98, and the GitPython repository's submodule reference to gitdb was updated in #1704 (and #1705). Thus #1656 might be1 fixed when developing agai... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | EliahKagan |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d |
| turbo-cache-control | no-preview |
| go-import | github.com/gitpython-developers/GitPython git https://github.com/gitpython-developers/GitPython.git |
| octolytics-dimension-user_id | 503709 |
| octolytics-dimension-user_login | gitpython-developers |
| octolytics-dimension-repository_id | 1126087 |
| octolytics-dimension-repository_nwo | gitpython-developers/GitPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1126087 |
| octolytics-dimension-repository_network_root_nwo | gitpython-developers/GitPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d69ac0477df0f87da03b8b06cebd187012d7a930 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width