René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"flake8 pre-commit config incompatible with 3.12","articleBody":"The configuration for `flake8` in `.pre-commit-config.yaml`--specifically that version 6.0.0 is used--is incompatible with Python 3.12, producing an incorrect \"E231 missing whitespace after ':'\" error:\r\n\r\n```text\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (scripts)$ pre-commit run --all-files\r\nflake8...................................................................Failed\r\n- hook id: flake8\r\n- exit code: 1\r\n\r\ngit/cmd.py:479:34: E231 missing whitespace after ':'\r\n                f\"The `{protocol}::` protocol looks suspicious, use `allow_unsafe_protocols=True` to allow it.\"\r\n                                 ^\r\ngit/cmd.py:479:35: E231 missing whitespace after ':'\r\n                f\"The `{protocol}::` protocol looks suspicious, use `allow_unsafe_protocols=True` to allow it.\"\r\n                                  ^\r\ngit/refs/log.py:247:67: E226 missing whitespace around arithmetic operator\r\n                    raise IndexError(f\"Index file ended at line {i+1}, before given index was reached\")\r\n                                                                  ^\r\n1     E226 missing whitespace around arithmetic operator\r\n2     E231 missing whitespace after ':'\r\n3\r\n\r\ncheck for merge conflicts................................................Passed\r\ncheck toml...............................................................Passed\r\ncheck yaml...............................................................Passed\r\n```\r\n\r\nIt also reports E226, which also happens only on Python 3.12, but appears intentional. But that's easy to fix (the simplest way being to add the spaces it wants, which also more resembles the overall style for the `+` operator in this project).\r\n\r\nThe wrong `:` error (false positive E231) happens because `flake8` 6.0.0 depends on `pycodestyle` 2.10.\\*, which implements that check (E231) and has a parsing bug specific to Python 3.12. This was fixed in https://github.com/PyCQA/pycodestyle/pull/1148.\r\n\r\nUpgrading to `flake8` 6.1.0 gets the fix, since that version of `flake8`, currently the latest, [depends on](https://flake8.pycqa.org/en/latest/release-notes/6.1.0.html) `pycodestyle` 2.11.\\*, [which has it](https://pycodestyle.pycqa.org/en/latest/developer.html#changes):\r\n\r\n```text\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (scripts)$ pre-commit autoupdate\r\n[https://github.com/PyCQA/flake8] updating 6.0.0 -\u003e 6.1.0\r\n[https://github.com/pre-commit/pre-commit-hooks] already up to date!\r\n(.venv) ek@Glub:~/repos-wsl/GitPython (scripts *)$ pre-commit run --all-files\r\n[INFO] Installing environment for https://github.com/PyCQA/flake8.\r\n[INFO] Once installed this environment will be reused.\r\n[INFO] This may take a few minutes...\r\nflake8...................................................................Failed\r\n- hook id: flake8\r\n- exit code: 1\r\n\r\ngit/objects/submodule/base.py:1406:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`\r\n            if type(sm) != git.objects.submodule.base.Submodule:\r\n               ^\r\ngit/refs/log.py:247:67: E226 missing whitespace around arithmetic operator\r\n                    raise IndexError(f\"Index file ended at line {i+1}, before given index was reached\")\r\n                                                                  ^\r\ngit/util.py:1139:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`\r\n            if type(base) == IterableClassWatcher:\r\n               ^\r\n1     E226 missing whitespace around arithmetic operator\r\n2     E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`\r\n3\r\n\r\ncheck for merge conflicts................................................Passed\r\ncheck toml...............................................................Passed\r\ncheck yaml...............................................................Passed\r\n```\r\n\r\nHowever, that reports E721 about the use of `==` to compare to a `type` object. So I think it makes sense for a fix for this to be part of a larger change that also fixes the new problems found by `flake8`, also bumps versions on the listed `flake8` plugins (other than the default ones like `pycodestyle`) and fixes new warnings from that, and possibly addresses other style issues and/or expands the scope of `flake8` checks to cover the test suite. (The benefit of the latter is that it could reveal areas where the checks ought to be configured differently.) I plan to open such a PR shortly.","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2023-09-21T08:28:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1670/GitPython/issues/1670"}