René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"\"make [force_]release\" attempts upload even if build fails","articleBody":"The `force_release` target in `Makefile` (which is also used by the `release` target after it attempts to check some things separate from this issue) had previously stopped after a failed attempt to build. But since #1654 it runs `twine` to attempt the upload whether or not the build succeeded.\r\n\r\nThe problem is that a command of the form `a || b` succeeds when `a` succeeds, but also when `a` fails but `b` succeeds:\r\n\r\nhttps://github.com/gitpython-developers/GitPython/blob/25597cbc05c7e478efc77bacd0f441962dbf87d5/Makefile#L20\r\n\r\nSo that command fails only in the rare case that `echo` fails to write to standard output.\r\n\r\nBut the message about how using a virtual environment may remedy a build failure is valuable and should not be removed. Instead, the logic can be adjusted to make sure the command fails if it gets that far.\r\n\r\nThere are some other improvements I'd like to propose to `Makefile`, and I think it will be convenient to include a fix for this with them. But I wanted to open an issue for this, because I think this behavior is unexpected and could cause confusion while making a release if it is not anticipated (if the next release is made before it is fixed and something keeps the build command from succeeding).","author":{"url":"https://github.com/EliahKagan","@type":"Person","name":"EliahKagan"},"datePublished":"2023-09-13T12:47:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1660/GitPython/issues/1660"}