René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't use assert to enforce interface constraints","articleBody":"``` py\r\n# sscce.py\r\n\r\nimport git\r\n\r\ngit.Repo(\".\").tags[None]\r\n```\r\n``` console\r\n$ git init\r\nInitialized empty Git repository in /tmp/tmp.Xoz9gZndOi/.git/\r\n$ venv/bin/python sscce.py\r\nTraceback (most recent call last):\r\n  File \"sscce.py\", line 5, in \u003cmodule\u003e\r\n    git.Repo(\".\").tags[None]\r\n  File \"/tmp/tmp.Xoz9gZndOi/venv/lib/python3.8/site-packages/git/util.py\", line 1087, in __getitem__\r\n    assert isinstance(index, (int, str, slice)), \"Index of IterableList should be an int or str\"\r\nAssertionError: Index of IterableList should be an int or str\r\n```\r\nhttps://github.com/gitpython-developers/GitPython/blob/c84dde218ef896a9b9af4f825ce222a6eb39291e/git/util.py#L1087\r\n`assert` should not be used in product code because it can be ignored with `-O`:\r\n``` console\r\n$ venv/bin/python -O sscce.py\r\nTraceback (most recent call last):\r\n  File \"sscce.py\", line 5, in \u003cmodule\u003e\r\n    git.Repo(\".\").tags[None]\r\n  File \"/tmp/tmp.Xoz9gZndOi/venv/lib/python3.8/site-packages/git/util.py\", line 1095, in __getitem__\r\n    return getattr(self, index)\r\nTypeError: getattr(): attribute name must be string\r\n```\r\n(In fact, that behavior is probably _better_ since a `TypeError` is more semantically meaningful.)\r\n\r\n[`bandit`](https://pypi.org/project/bandit/) can catch this kind of thing:\r\n``` console\r\n$ venv/bin/bandit venv/lib/python3.8/site-packages/git/util.py\r\n...\r\n\u003e\u003e Issue: [B101:assert_used] Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.\r\n   Severity: Low   Confidence: High\r\n   CWE: CWE-703 (https://cwe.mitre.org/data/definitions/703.html)\r\n   Location: venv/lib/python3.8/site-packages/git/util.py:1087:8\r\n   More Info: https://bandit.readthedocs.io/en/1.7.4/plugins/b101_assert_used.html\r\n1086\r\n1087            assert isinstance(index, (int, str, slice)), \"Index of IterableList should be an int or str\"\r\n1088\r\n1089            if isinstance(index, int):\r\n...\r\n```","author":{"url":"https://github.com/tucked","@type":"Person","name":"tucked"},"datePublished":"2023-02-05T19:39:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1552/GitPython/issues/1552"}