René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests fail due to security vulnerability fix in git 2.38.1","articleBody":"Hello,\r\nDue to a change made in Git to address a security vulnerability, some tests are failing.\r\n\r\nSee here for a description of the change:\r\n\r\nhttps://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253\r\n\r\nThese are the failing tests:\r\n\r\n- test_list_only_valid_submodules\r\n- test_git_submodules_and_add_sm_with_new_commit\r\n\r\nThe fail signature is the same in both cases:\r\n\r\n    cmdline: git submodule add /[redacted]/GitPython/git/ext/gitdb/gitdb/ext/smmap module\r\n    stderr: 'Cloning into '/tmp/test_list_only_valid_submoduleshv3nprno/parent/module'...\r\n    fatal: transport 'file' not allowed\r\n    fatal: clone of '/[redacted]/GitPython/git/ext/gitdb/gitdb/ext/smmap' into submodule path '/tmp/test_list_only_valid_submoduleshv3nprno/parent/module' failed'\r\n\r\nHere is a blog post discussing this issue affecting others:\r\n\r\nhttps://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html\r\n\r\nI have fixed this locally by changing the submodule add command in each test from:\r\n\r\n    repo.git.submodule(\"add\", self._small_repo_url(), \"module\")\r\n\r\nto \r\n\r\n    repo.git.submodule(\"add\", Git.polish_url(\"https://github.com/gitpython-developers/smmap.git\"), \"module\")\r\n\r\nIf this is an acceptable fix I can provide it in a pull request.","author":{"url":"https://github.com/Lightborne","@type":"Person","name":"Lightborne"},"datePublished":"2023-01-21T18:31:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/1544/GitPython/issues/1544"}