René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Problem when checking for ignored files","articleBody":"Hello,\r\nI stumbled on an issue that i think calls for an update to the GitPython's `ignored` function.\r\n\r\nI have a script that performs certain format checks on all files in a repository.  Simple things like removing trailing whitespace.  This script is written to only run on files that have been added to the repository, and it is written to not run on any untracked or ignored files.\r\n\r\nMy script generates a list of all the files in the workspace, and then it removes untracked and ignored files from that list.  something like this\r\n    \r\n    self.file_list # all the files in the repo\r\n    self.ignored_files = repo.ignored(self.file_list) # should return all ignored files \r\n\r\nOur company's working environment requires us to run several tools within the workspace that holds the repo.  These tools all put their output into directories that we have ignored with `.gitignore`.  But some of these tools create symbolic links within these directories.\r\n\r\nNow, GitPython's implementation of `repo.ignored` is basically a wrapper around git's built in `check-ignore` sub-command.  When you try to check if a file behind a symbolic link is ignored using this sub-command, git throws a fatal error:\r\n\r\n    # This is the good case - git correctly tells me that both of these are ignored.\r\n    git check-ignore ignore_file.txt ignore/target/ignore.txt \r\n    ignore_file.txt\r\n    ignore/target/ignore.txt\r\n\r\n    # This is the bad case - git simply bails with a fatal error\r\n    git check-ignore ignore_file.txt ignore/link/ignore.txt \r\n    fatal: pathspec 'ignore/link/ignore.txt' is beyond a symbolic link\r\n\r\nGitPython's `repo.ignored` implementation does not catch this fatal error.  What it does is return an empty list.  \r\n\r\nSo my script was failing because it was trying to format_check a bunch of stuff that was buried in an ignored directory!\r\n\r\nI think what needs to happen is that the `repo.ignored` function needs to be enhanced to raise an exception when git throws this fatal error.  Then, I could trap that exception and parse my file list, removing any entries that are hidden behind symbolic links.","author":{"url":"https://github.com/Lightborne","@type":"Person","name":"Lightborne"},"datePublished":"2023-01-20T20:02:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/1543/GitPython/issues/1543"}