René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Library leaves dangling processes after use","articleBody":"Hi, I've faced a problem on Windows with file/directory removal with `shutil.rmtree()`. The problem, by itself, is not new and already has known solutions, including `git.util.rmtree()`. However, just using this function was not enough in my case and I started to dig deeper - there was an error about an open file handle. I discovered there were extra child `git` processes hanging in the process tree, but, unexpectedly, it was happening after all the library objects were removed:\r\n![image](https://user-images.githubusercontent.com/13832349/131838938-b2c962ef-ca7c-4621-b4f5-71c9601f1fee.png)\r\n\r\nThen I tried to catch and trace `Popen` calls from the library and found out this function:\r\nhttps://github.com/gitpython-developers/GitPython/blob/5b3669e24a8ce7f3f482de86fcf95620db643467/git/cmd.py#L1190-L1199\r\n\r\nFrom comments and names, it looks like such persistent behavior is intended. There is also the `AutoInterrupt` class here:\r\nhttps://github.com/gitpython-developers/GitPython/blob/5b3669e24a8ce7f3f482de86fcf95620db643467/git/cmd.py#L367-L373\r\n\r\nreturned from:\r\nhttps://github.com/gitpython-developers/GitPython/blob/5b3669e24a8ce7f3f482de86fcf95620db643467/git/cmd.py#L841\r\n\r\nThe class comment indicates that the process should be killed when the object goes out of scope. To me, it looks like an attempt to imitate [the RAII C++ idiom](https://en.cppreference.com/w/cpp/language/raii). Unfortunately, in Python it does not work this way because of garbage collector and the scoping rules. That is, an object that has no references can be removed in any time after it lost its last reference. The \"pythonic\" way to deal with this behavior is using a context manager (which this class is *not*). \r\n\r\nMy suggestion is to collect these processes and manage them on a library/repo level, or wrap this in a context manager (which is better than just calling `wait()` manually in case of exceptions). BTW, probably, the process created is not reused after the first call.\r\n\r\n``` python\r\nimport git\r\nr = git.Repo.init('test_repo') \r\nr.index.commit('aa')   \r\ndel r\r\n```\r\nUpd: I see there is an undocumented `repo.close()`, which can help, but can have undesired side-effects because of a forced gc call.","author":{"url":"https://github.com/zhiltsov-max","@type":"Person","name":"zhiltsov-max"},"datePublished":"2021-09-02T12:08:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/1333/GitPython/issues/1333"}