René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Signed commits not parsed correctly","articleBody":"The `_deserialize` method of the `Commit` object (objects/commit.py:407) doesn't handle signed commits properly, see this example of a raw formatted git commit object (taken from the rails repository, where I discovered this bug):\n\n```\ncommit 31735bd39127784019893e4860b2c9807293da25\ntree 9c028a6346b49abfed31d8927d47980994f3b73d\nparent 1f633c78ea7ff13a8f35d64e8172b774dd662667\nauthor Miguel Herranz \u003cmiguel@ipglider.org\u003e 1345231220 +0200\ncommitter Miguel Herranz \u003cmiguel@ipglider.org\u003e 1345231220 +0200\ngpgsig -----BEGIN PGP SIGNATURE-----\n Version: GnuPG v1.4.12 (Darwin)\n\n iQIcBAABAgAGBQJQLpm/AAoJEJPQ5hNIfbMZ5KAP/2lFh7WMNR8c1tyQOXW518/k\n 92mr1YsdD4dSePLflKvloZe6ITfb6btcSd/nAnbdBubRiuqlpCGSmMUzZrafNXpF\n WD5zAPQude75KJl3Rar6nBCLzpNm4a3sAQdLvDLgjCA823+qAzLbk7xWCt+0oaal\n qJK5SJDwtyF+PXS8T+WPhuIERjNE3CkPG7NCFR4Atg1aiSMBkfY35FS0JpSXNqW0\n VZcHjAZR8oC7YuipwkoEKatjC/lwQfRKM+LdI2qP/1f05EVJaDAZGpQShyrVNgLt\n hlaZLL880XyNdzuP986J19RbuG69+GWbL2Q0DZItrxbUo7JqDes0uIDh/c2xlwDt\n QFISJ9Xieogo2FKDIFD2rc8jiHYiMx3OUs6QOTz6YXfAUdEoVInrv32Tm0E+IiHq\n Y5xxlBiNOsHd448Om6cB7sliwbdc5ic9UYrWibqgzEjdiyoY3uRnyS6r19ISjod+\n +C5aYZr3uWz7xzW6hY+VWi9pM9xxkdYZEN1vBiGrm3hH9b2cm9M1roRrMoCz0Kjy\n xgZSSnp+Dft2Sw61DJHxf7t8oaOW7J7ZWjkD6mM66Kx7IpKzvzfReSYjLQtQNcNt\n 8NHVUySPkC3/gpdlyzGOSu0xRvH1eq2eBJrKetlNN9XAEZAutQ+symdmfNY7L/Mj\n JcwMU0pcsI9X8NXBUMoK\n =GOBp\n -----END PGP SIGNATURE-----\n\n    Update to activerecord-deprecated_finders on generator\n```\n\nAs you see there may be a gpgsig line after the committer which is then followed by the actual signature. GitPython doesn't recognise this and will interpret it as the encoding line. The `enc` variable is then set to '-----BEGIN PGP SIGNATURE-----', which is of course not valid and will cause an exception on line 443.\n\nTo reproduce the problem first clone the rails repository, and then run this code:\n\n```\nfrom git import *\nrepo = Repo(\"../rails\")\nrepo.commit(\"31735bd39127784019893e4860b2c9807293da25\").author\n```\n","author":{"url":"https://github.com/ArnoVanLumig","@type":"Person","name":"ArnoVanLumig"},"datePublished":"2014-01-11T18:39:55.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/132/GitPython/issues/132"}