René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"stacktrace; `pump stream` fails when commit diff is on a file with a colon in the name","articleBody":"Hi\r\n\r\nWe use this code to check whether a git repo contains only \"new\" files or whether a file was modified:\r\n```\r\ndef git_check_added_only(repo: Repo):\r\n    prev_commit = repo.commit(\"HEAD~1\")\r\n    head_commit = repo.head.commit\r\n    modified_files = list(prev_commit.diff(head_commit).iter_change_type(\"M\"))\r\n    if len(modified_files) \u003e 0:\r\n        ...\r\n```\r\n\r\nWhen running this on repos with only csv data, it's fine. \r\n\r\nHowever when running this on repos with binary files in it, like `.xlxs`, we blow in  a stack trace like this; but because it's threaded I am not sure which exact line above is internally causing this \"pump\"\r\n\r\n```\r\nb\"ERROR:git.cmd:Pumping 'stdout' of cmd(['git', 'diff-tree', '8fd339d63f824428d215be363817d637ffae3430', 'ca2fecd4f638c81af31ef7e1a22d48b68a55d746', '-r', '--abbrev=40', '--full-index', '-M', '--raw', '-z', '--no-color']) failed due to: ValueError('not enough values to unpack (expected 5, got 4)')\\n\"\r\nb'Exception in thread Thread-25:\\n'\r\nb'Traceback (most recent call last):\\n'\r\nb'  File \"/home/mypackage/.local/lib/python3.7/site-packages/git/cmd.py\", line 83, in pump_stream\\n'\r\nb'    handler(line)\\n'\r\nb'  File \"/home/mypackage/.local/lib/python3.7/site-packages/git/diff.py\", line 488, in handle_diff_line\\n'\r\nb'    old_mode, new_mode, a_blob_id, b_blob_id, _change_type = meta.split(None, 4)\\n'\r\nb'ValueError: not enough values to unpack (expected 5, got 4)\\n'\r\nb'\\n'\r\nb'The above exception was the direct cause of the following exception:\\n'\r\nb'\\n'\r\nb'Traceback (most recent call last):\\n'\r\nb'  File \"/usr/local/lib/python3.7/threading.py\", line 926, in _bootstrap_inner\\n'\r\nb'    self.run()\\n'\r\nb'  File \"/usr/local/lib/python3.7/threading.py\", line 870, in run\\n'\r\nb'    self._target(*self._args, **self._kwargs)\\n'\r\nb'  File \"/home/mypackage/.local/lib/python3.7/site-packages/git/cmd.py\", line 86, in pump_stream\\n'\r\nb\"    raise CommandError(['\u003c%s-pump\u003e' % name] + cmdline, ex) from ex\\n\"\r\nb\"git.exc.CommandError: Cmd('\u003cstdout-pump\u003e') failed due to: ValueError('not enough values to unpack (expected 5, got 4)')\\n\"\r\nb'  cmdline: \u003cstdout-pump\u003e git diff-tree 8fd339d63f824428d215be363817d637ffae3430 ca2fecd4f638c81af31ef7e1a22d48b68a55d746 -r --abbrev=40 --full-index -M --raw -z --no-color\\n'\r\nb'\\n'\r\n```\r\n\r\nNear that line of code I see https://github.com/gitpython-developers/GitPython/blob/main/git/diff.py#L498\r\n\r\n```\r\n        # handles\r\n        # :100644 100644 687099101... 37c5e30c8... M    .gitignore\r\n```\r\n\r\nI do not know how to get to this output on my git terminal. I was going to try to make a test case here seeing if this looks different for binary files (basically make a PDF or an excel file, then edit it, then commit it; but reading the log doesnt show such a format)\r\n\r\nWe do not pin the version of `gitpython` and we rebuild this docker container fairly often so this should be running with the latest version in pypi (488 on your master branch does not coorespond to that line of code; however you've had commits to master since the pypi release)","author":{"url":"https://github.com/tommyjcarpenter","@type":"Person","name":"tommyjcarpenter"},"datePublished":"2021-04-12T18:43:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/1210/GitPython/issues/1210"}