Title: Rethink token scanning · Issue #86 · githubtraining/security · GitHub
Open Graph Title: Rethink token scanning · Issue #86 · githubtraining/security
X Title: Rethink token scanning · Issue #86 · githubtraining/security
Description: Based on @gregose's feedback in #81: Another item would be to have someone commit an access token and have it revoked with the credential scanning feature... but thats a bit tricky to implement in a safe way. I'm not sure what we could d...
Open Graph Description: Based on @gregose's feedback in #81: Another item would be to have someone commit an access token and have it revoked with the credential scanning feature... but thats a bit tricky to implement in ...
X Description: Based on @gregose's feedback in #81: Another item would be to have someone commit an access token and have it revoked with the credential scanning feature... but thats a bit tricky to implement...
Opengraph URL: https://github.com/githubtraining/security/issues/86
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Rethink token scanning ","articleBody":"Based on @gregose's feedback in #81: \r\n\r\n\u003e Another item would be to have someone commit an access token and have it revoked with the credential scanning feature... but thats a bit tricky to implement in a safe way. I'm not sure what we could do there. Maybe a dummy token we could scan for? @ptoomey3 (not part of this org yet) may have some ideas.\r\n\r\nThis is something we started with, but took out. The possible benefits would be: \r\n- Raise awareness of token scanning as a feature \r\n- Let people know they shouldn't be committing tokens \r\n\r\nThe reasons we decided to take them out are: \r\n- For the flow to happen as a step, we would actually ask them to commit a token, which ultimately isn't a behavior we want users to do. In general, if a user shouldn't do it in every day life, we don't want them to practice it during a course\r\n- When the token is added to a repository, the user who added the token isn't notified at all. The notifications (from what I understand) all take place on the other end, so that the service provider who owns that token will be the one notified, and the token can be revoked. To a user, it would be anticlimactic and we wouldn't see anything happen in reaction to that commit immediately\r\n\r\nThis is definitely still not a perfect case, because I think we could do a better job of talking about token scanning and tokens in general. Maybe some different verbage around the `.gitignore`? Or, if I've misunderstood how the alerts would be sent when a token is committed, maybe we should rethink this completely? I still worry about instructing a user to commit a dummy token, but we could have the bot do it, and have the user fix it. ","author":{"url":"https://github.com/brianamarie","@type":"Person","name":"brianamarie"},"datePublished":"2018-10-11T06:51:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/86/security/issues/86"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:890ba3dd-c227-cb28-ae6a-cda11bf5ad08 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8CD2:BCEAA:E135D2:134558D:6A62CD98 |
| html-safe-nonce | 6d1b4e71abac435f6ab44cc614e949475936b89bf3e22e4c7e1fd82e23142537 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0QyOkJDRUFBOkUxMzVEMjoxMzQ1NThEOjZBNjJDRDk4IiwidmlzaXRvcl9pZCI6IjU3NDIyNjY2NTk3MjM0NjQwODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8a8f43e16d3639cb093759602056065d351e0120cf3a308f2d8ee81623ab88e0 |
| hovercard-subject-tag | issue:368976550 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/githubtraining/security/86/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fb3bf95a6ecc71e32a9d397d95db4d41665dca072093a6527e83b3e213e36634/githubtraining/security/issues/86 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fb3bf95a6ecc71e32a9d397d95db4d41665dca072093a6527e83b3e213e36634/githubtraining/security/issues/86 |
| og:image:alt | Based on @gregose's feedback in #81: Another item would be to have someone commit an access token and have it revoked with the credential scanning feature... but thats a bit tricky to implement in ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | brianamarie |
| hostname | github.com |
| expected-hostname | github.com |
| None | df33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd |
| turbo-cache-control | no-preview |
| go-import | github.com/githubtraining/security git https://github.com/githubtraining/security.git |
| octolytics-dimension-user_id | 2036237 |
| octolytics-dimension-user_login | githubtraining |
| octolytics-dimension-repository_id | 146712073 |
| octolytics-dimension-repository_nwo | githubtraining/security |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 146712073 |
| octolytics-dimension-repository_network_root_nwo | githubtraining/security |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d41cd1bdb290013455c0ac430fa755621733f5eb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width