Title: Who should merge a PR? · Issue #1 · githubflow/githubflow.github.io · GitHub
Open Graph Title: Who should merge a PR? · Issue #1 · githubflow/githubflow.github.io
X Title: Who should merge a PR? · Issue #1 · githubflow/githubflow.github.io
Description: A developer pushes his code, opens a PR. His peers review it and approve the changes. Everybody has push access so anyone could merge it. Merging the PR to master would immediately deploy (if the tests pass). Who should merge the PR and ...
Open Graph Description: A developer pushes his code, opens a PR. His peers review it and approve the changes. Everybody has push access so anyone could merge it. Merging the PR to master would immediately deploy (if the t...
X Description: A developer pushes his code, opens a PR. His peers review it and approve the changes. Everybody has push access so anyone could merge it. Merging the PR to master would immediately deploy (if the t...
Opengraph URL: https://github.com/githubflow/githubflow.github.io/issues/1
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Who should merge a PR?","articleBody":"- A developer pushes his code, opens a PR.\n- His peers review it and approve the changes.\n- Everybody has push access so anyone could merge it.\n- Merging the PR to master would immediately deploy (if the tests pass).\n\nWho should merge the PR and therefore approve not only the changes, but the deployment at this moment as well?\n\nSide notes:\n- We do not use feature flags (yet).\n- Sometimes we need to deploy a feature only after certain event/time despite the feature being complete.\n- We don't want `master` (for deployments), `develop` (to base new work) and feature branches, just a simple structure of `master` and feature branches.\n","author":{"url":"https://github.com/hkdobrev","@type":"Person","name":"hkdobrev"},"datePublished":"2013-12-14T01:18:59Z","url":"https://github.com/githubflow/githubflow.github.io/issues/1"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a178e300-6e44-1670-52d1-e96ec0ca9c37 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EAA6:20E383:55B0FB:756DC3:6AFC105E |
| html-safe-nonce | 5761ae307680de3c22d87680a846b5f2c52b64bd4182aad0c0905e676b8d1bb2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUE2OjIwRTM4Mzo1NUIwRkI6NzU2REMzOjZBRkMxMDVFIiwidmlzaXRvcl9pZCI6IjMzNjgwMzgwOTQ2MDYxNzYzNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9f979d9f36e161301e911da8cfd52f83c727c9bef3e8b91b604bb3dae3c743b1 |
| hovercard-subject-tag | issue:24282927 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/githubflow/githubflow.github.io/1/issue_layout |
| twitter:image | https://opengraph.githubassets.com/2f2df510dd8720381a5f1c9bc2946650cda0f1c23d7c1d75939d0936a0d2fde5/githubflow/githubflow.github.io/issues/1 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2f2df510dd8720381a5f1c9bc2946650cda0f1c23d7c1d75939d0936a0d2fde5/githubflow/githubflow.github.io/issues/1 |
| og:image:alt | A developer pushes his code, opens a PR. His peers review it and approve the changes. Everybody has push access so anyone could merge it. Merging the PR to master would immediately deploy (if the t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hkdobrev |
| hostname | github.com |
| expected-hostname | github.com |
| None | fa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f |
| turbo-cache-control | no-preview |
| go-import | github.com/githubflow/githubflow.github.io git https://github.com/githubflow/githubflow.github.io.git |
| octolytics-dimension-user_id | 6180246 |
| octolytics-dimension-user_login | githubflow |
| octolytics-dimension-repository_id | 15169897 |
| octolytics-dimension-repository_nwo | githubflow/githubflow.github.io |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 15169897 |
| octolytics-dimension-repository_network_root_nwo | githubflow/githubflow.github.io |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b3b5633a74535d9c23385512d534c66c8fde1907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width