René's URL Explorer Experiment


Title: Make sure events are unhooked when we're disposing so they don't leak by shana · Pull Request #615 · github-for-unity/Unity · GitHub

Open Graph Title: Make sure events are unhooked when we're disposing so they don't leak by shana · Pull Request #615 · github-for-unity/Unity

X Title: Make sure events are unhooked when we're disposing so they don't leak by shana · Pull Request #615 · github-for-unity/Unity

Description: Most of our objects are singletons that live through the lifetime of the process (the lifetime being the time between Unity reloading domains whenever it recompiles or the user enters play mode), we never really worry much about unhooking events to allow objects to be GC'd and to not raise events on objects that are dead. In our tests, however, that's a problem, since we're not reloading the domain and killing all the things between one test and the other, which means events can definitely leak and may cause problems. This makes sure we break event loops so that tests don't trample all over each other. It's not a thorough audit of everything that we need to dispose, but it's a start.

Open Graph Description: Most of our objects are singletons that live through the lifetime of the process (the lifetime being the time between Unity reloading domains whenever it recompiles or the user enters play mode), w...

X Description: Most of our objects are singletons that live through the lifetime of the process (the lifetime being the time between Unity reloading domains whenever it recompiles or the user enters play mode), w...

Opengraph URL: https://github.com/github-for-unity/Unity/pull/615

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d49a8d3-126f-d850-fc32-e35b6bd1025e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDE0:14F601:C4D00E:FD6383:6B00EB8D
html-safe-nonceb423aaea30b98e3399ecfb07fead8431bf58c4054cb439b9541d42c0665753ca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREUwOjE0RjYwMTpDNEQwMEU6RkQ2MzgzOjZCMDBFQjhEIiwidmlzaXRvcl9pZCI6IjczMjU5MzM5OTkyNzkzNjkxMDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd258aecc506d1742a1bdc149a0f8fb14d488ddb97ac51c9904cc7e554c8bff04
hovercard-subject-tagpull_request:173839912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github-for-unity/Unity/pull/615/files
twitter:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
og:image:altMost of our objects are singletons that live through the lifetime of the process (the lifetime being the time between Unity reloading domains whenever it recompiles or the user enters play mode), w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git
octolytics-dimension-user_id28719038
octolytics-dimension-user_logingithub-for-unity
octolytics-dimension-repository_id94770860
octolytics-dimension-repository_nwogithub-for-unity/Unity
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94770860
octolytics-dimension-repository_network_root_nwogithub-for-unity/Unity
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github-for-unity/Unity/pull/615/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F615%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F615%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github-for-unity%2FUnity
Reloadhttps://github.com/github-for-unity/Unity/pull/615/files
Reloadhttps://github.com/github-for-unity/Unity/pull/615/files
Reloadhttps://github.com/github-for-unity/Unity/pull/615/files
github-for-unityhttps://github.com/github-for-unity
Unityhttps://github.com/github-for-unity/Unity
Codehttps://github.com/github-for-unity/Unity
Issues10 (10)https://github.com/github-for-unity/Unity/issues
Pull requestshttps://github.com/github-for-unity/Unity/pulls
Actionshttps://github.com/github-for-unity/Unity/actions
Projectshttps://github.com/github-for-unity/Unity/projects
Wikihttps://github.com/github-for-unity/Unity/wiki
Security and qualityhttps://github.com/github-for-unity/Unity/security
Insightshttps://github.com/github-for-unity/Unity/insights
shanahttps://github.com/shana
1.0rc/masterhttps://github.com/github-for-unity/Unity/tree/1.0rc/master
1.0rc/fixes/dispose-of-thingshttps://github.com/github-for-unity/Unity/tree/1.0rc/fixes/dispose-of-things
Conversation 0 https://github.com/github-for-unity/Unity/pull/615
Commits 2 https://github.com/github-for-unity/Unity/pull/615/commits
Checks 0 https://github.com/github-for-unity/Unity/pull/615/checks
Files changed https://github.com/github-for-unity/Unity/pull/615/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/615/files
Make sure events are unhooked when we're disposing so they don't leak https://github.com/github-for-unity/Unity/pull/615/files#top
Show all changes 2 commits https://github.com/github-for-unity/Unity/pull/615/files
c39873d Make sure events are unhooked when we're disposing so they don't leak shana Mar 8, 2018 https://github.com/github-for-unity/Unity/pull/615/commits/c39873d32ec5d1346ebbac27dd9ee1a368174a70
187662d Merge branch '1.0rc/master' into 1.0rc/fixes/dispose-of-things shana Mar 8, 2018 https://github.com/github-for-unity/Unity/pull/615/commits/187662d81676b642217c31e5462e9a46f20e8642
Clear filters https://github.com/github-for-unity/Unity/pull/615/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/615/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/615/files
CacheContainer.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
CacheInterfaces.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-9fa66e1e1cb52f7245f3dfddf9eff393d89618ec9acfdd3d0aaf2b34c1556f2f
RepositoryWatcher.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-cb05fd3c6e43aa4b9ae5e92099cfaa2a015416d9b2fefcb0075d56abc6be8e96
IRepository.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-915f510dcaa95621fb4bc95c0ed696cf6070cf45f76ad6c74450b233e1f92a67
Repository.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
RepositoryManager.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
ApplicationCache.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
BaseIntegrationTest.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-0e35e892d135f78cc75ec6293282cbbdac612922c951652a6849927d3334dd85
CachingClasses.cs https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
src/GitHub.Api/Cache/CacheContainer.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Cache/CacheContainer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
https://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
https://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
https://github.com/github-for-unity/Unity/pull/615/files#diff-863344bf4c805ba160c6aff1d10a3bfa7e8c6631d736bdc0c0b00cdaf45d9b67
src/GitHub.Api/Cache/CacheInterfaces.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-9fa66e1e1cb52f7245f3dfddf9eff393d89618ec9acfdd3d0aaf2b34c1556f2f
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Cache/CacheInterfaces.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-9fa66e1e1cb52f7245f3dfddf9eff393d89618ec9acfdd3d0aaf2b34c1556f2f
https://github.com/github-for-unity/Unity/pull/615/files#diff-9fa66e1e1cb52f7245f3dfddf9eff393d89618ec9acfdd3d0aaf2b34c1556f2f
https://github.com/github-for-unity/Unity/pull/615/files#diff-9fa66e1e1cb52f7245f3dfddf9eff393d89618ec9acfdd3d0aaf2b34c1556f2f
src/GitHub.Api/Events/RepositoryWatcher.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-cb05fd3c6e43aa4b9ae5e92099cfaa2a015416d9b2fefcb0075d56abc6be8e96
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Events/RepositoryWatcher.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-cb05fd3c6e43aa4b9ae5e92099cfaa2a015416d9b2fefcb0075d56abc6be8e96
https://github.com/github-for-unity/Unity/pull/615/files#diff-cb05fd3c6e43aa4b9ae5e92099cfaa2a015416d9b2fefcb0075d56abc6be8e96
src/GitHub.Api/Git/IRepository.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-915f510dcaa95621fb4bc95c0ed696cf6070cf45f76ad6c74450b233e1f92a67
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Git/IRepository.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-915f510dcaa95621fb4bc95c0ed696cf6070cf45f76ad6c74450b233e1f92a67
https://github.com/github-for-unity/Unity/pull/615/files#diff-915f510dcaa95621fb4bc95c0ed696cf6070cf45f76ad6c74450b233e1f92a67
src/GitHub.Api/Git/Repository.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Git/Repository.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
https://github.com/github-for-unity/Unity/pull/615/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
src/GitHub.Api/Git/RepositoryManager.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/GitHub.Api/Git/RepositoryManager.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
https://github.com/github-for-unity/Unity/pull/615/files#diff-b20b0d0664c3f5f535489bf923fceeb1a30b78fcd7dc3604139c71a04dfda864
src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/UnityExtension/Assets/Editor/GitHub.Unity/ApplicationCache.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
https://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
https://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
https://github.com/github-for-unity/Unity/pull/615/files#diff-ac28a962e72a755892ebb0dbc5b0c896e91cf9815d429b300357f8e50e405d86
src/tests/IntegrationTests/BaseIntegrationTest.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-0e35e892d135f78cc75ec6293282cbbdac612922c951652a6849927d3334dd85
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/tests/IntegrationTests/BaseIntegrationTest.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-0e35e892d135f78cc75ec6293282cbbdac612922c951652a6849927d3334dd85
https://github.com/github-for-unity/Unity/pull/615/files#diff-0e35e892d135f78cc75ec6293282cbbdac612922c951652a6849927d3334dd85
src/tests/IntegrationTests/CachingClasses.cshttps://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
View file https://github.com/github-for-unity/Unity/blob/187662d81676b642217c31e5462e9a46f20e8642/src/tests/IntegrationTests/CachingClasses.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/615/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
https://github.com/github-for-unity/Unity/pull/615/files#diff-e4f0a651c1db44860822baab30387166378303d390178735f22444933a5c514a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.