René's URL Explorer Experiment


Title: Throw if the manager isn't ready so that windows use their cached data instead by shana · Pull Request #333 · github-for-unity/Unity · GitHub

Open Graph Title: Throw if the manager isn't ready so that windows use their cached data instead by shana · Pull Request #333 · github-for-unity/Unity

X Title: Throw if the manager isn't ready so that windows use their cached data instead by shana · Pull Request #333 · github-for-unity/Unity

Description: If let's say the history view is open when Unity reloads the domain, it will call Repository.Log, which might happen before the RepositoryManager is actually initialized, which would make the Log method return an empty list, and so the history view would wipe out its serialized data and show an empty list until everything else came up. We want to keep showing the serialized UI until we get information otherwise, so if there's no repository manager we really want to throw to make sure the task chain fails.

Open Graph Description: If let's say the history view is open when Unity reloads the domain, it will call Repository.Log, which might happen before the RepositoryManager is actually initialized, which would make the L...

X Description: If let's say the history view is open when Unity reloads the domain, it will call Repository.Log, which might happen before the RepositoryManager is actually initialized, which would make t...

Opengraph URL: https://github.com/github-for-unity/Unity/pull/333

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14272a10-f590-c88d-9eeb-dd19b2651bad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BC2:37820D:A685D9:E02229:6B00E1AB
html-safe-nonce27aad3f74e48e5c475f404762b5854a134a06e7ab23ea6b1ef82c1189375b52a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkMyOjM3ODIwRDpBNjg1RDk6RTAyMjI5OjZCMDBFMUFCIiwidmlzaXRvcl9pZCI6IjM3NzgwMzI3NDM1MTQ5NTYyMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace8595da390e5c3d693a1895cc1327f1e3ab7dbd0d53be03cffa4b46816aee0cb
hovercard-subject-tagpull_request:142137312
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github-for-unity/Unity/pull/333/files
twitter:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
og:image:altIf let's say the history view is open when Unity reloads the domain, it will call Repository.Log, which might happen before the RepositoryManager is actually initialized, which would make the L...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git
octolytics-dimension-user_id28719038
octolytics-dimension-user_logingithub-for-unity
octolytics-dimension-repository_id94770860
octolytics-dimension-repository_nwogithub-for-unity/Unity
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94770860
octolytics-dimension-repository_network_root_nwogithub-for-unity/Unity
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github-for-unity/Unity/pull/333/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F333%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F333%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github-for-unity%2FUnity
Reloadhttps://github.com/github-for-unity/Unity/pull/333/files
Reloadhttps://github.com/github-for-unity/Unity/pull/333/files
Reloadhttps://github.com/github-for-unity/Unity/pull/333/files
github-for-unityhttps://github.com/github-for-unity
Unityhttps://github.com/github-for-unity/Unity
Codehttps://github.com/github-for-unity/Unity
Issues10 (10)https://github.com/github-for-unity/Unity/issues
Pull requestshttps://github.com/github-for-unity/Unity/pulls
Actionshttps://github.com/github-for-unity/Unity/actions
Projectshttps://github.com/github-for-unity/Unity/projects
Wikihttps://github.com/github-for-unity/Unity/wiki
Security and qualityhttps://github.com/github-for-unity/Unity/security
Insightshttps://github.com/github-for-unity/Unity/insights
StanleyGoldmanhttps://github.com/StanleyGoldman
masterhttps://github.com/github-for-unity/Unity/tree/master
fixes/we-like-exceptionshttps://github.com/github-for-unity/Unity/tree/fixes/we-like-exceptions
Conversation 1 https://github.com/github-for-unity/Unity/pull/333
Commits 4 https://github.com/github-for-unity/Unity/pull/333/commits
Checks 0 https://github.com/github-for-unity/Unity/pull/333/checks
Files changed https://github.com/github-for-unity/Unity/pull/333/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/333/files
Throw if the manager isn't ready so that windows use their cached data instead https://github.com/github-for-unity/Unity/pull/333/files#top
Show all changes 4 commits https://github.com/github-for-unity/Unity/pull/333/files
02b2b9e Throw if the manager isn't ready so that windows use their cached dat… shana Sep 20, 2017 https://github.com/github-for-unity/Unity/pull/333/commits/02b2b9ea0ee063cf3c1ed529e2d8c2695f349241
dd21f71 We probably want to fail listing locks too shana Sep 20, 2017 https://github.com/github-for-unity/Unity/pull/333/commits/dd21f7118d2daf4e412f8d6ab9ca67c0a8116015
f28a3d2 Merge branch 'master' into fixes/we-like-exceptions shana Oct 19, 2017 https://github.com/github-for-unity/Unity/pull/333/commits/f28a3d292cc12864c9d6d6035eb65bf70475d4ff
9fddb07 Merge branch 'master' into fixes/we-like-exceptions StanleyGoldman Oct 19, 2017 https://github.com/github-for-unity/Unity/pull/333/commits/9fddb073d5577a5cfd3001b2daec272b4ccfcf8a
Clear filters https://github.com/github-for-unity/Unity/pull/333/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/333/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/333/files
Repository.cs https://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
TaskHelpers.cs https://github.com/github-for-unity/Unity/pull/333/files#diff-26fa6cb79992436ac40ce31adc6dd9d121cfe496dd08d2afa17f50b6c5622565
src/GitHub.Api/Git/Repository.cshttps://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
View file https://github.com/github-for-unity/Unity/blob/9fddb073d5577a5cfd3001b2daec272b4ccfcf8a/src/GitHub.Api/Git/Repository.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/333/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
https://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
https://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
https://github.com/github-for-unity/Unity/pull/333/files#diff-6e20b8b4752d9ef90a049bd3e68a964539e21791650f537ea99e0ec044a85321
src/GitHub.Api/Helpers/TaskHelpers.cshttps://github.com/github-for-unity/Unity/pull/333/files#diff-26fa6cb79992436ac40ce31adc6dd9d121cfe496dd08d2afa17f50b6c5622565
View file https://github.com/github-for-unity/Unity/blob/9fddb073d5577a5cfd3001b2daec272b4ccfcf8a/src/GitHub.Api/Helpers/TaskHelpers.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/333/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/333/files#diff-26fa6cb79992436ac40ce31adc6dd9d121cfe496dd08d2afa17f50b6c5622565
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.