René's URL Explorer Experiment


Title: Tweaking the popup window refactor by shana · Pull Request #290 · github-for-unity/Unity · GitHub

Open Graph Title: Tweaking the popup window refactor by shana · Pull Request #290 · github-for-unity/Unity

X Title: Tweaking the popup window refactor by shana · Pull Request #290 · github-for-unity/Unity

Description: Add a loading view and make it so the PopupWindow always has an active view and there's no null checks. Maybe we can use the loading view to show a loading animation and replace it with the real view when it's done? This might not be feasible in the current model given that we only call OnGUI on the active view, but those null checks are giving me the creeps tbh, we should always be showing something on screen - at most we just use the loading view as an empty view to transition into other views perhaps? Up for debate :P

Open Graph Description: Add a loading view and make it so the PopupWindow always has an active view and there's no null checks. Maybe we can use the loading view to show a loading animation and replace it with the rea...

X Description: Add a loading view and make it so the PopupWindow always has an active view and there's no null checks. Maybe we can use the loading view to show a loading animation and replace it with the...

Opengraph URL: https://github.com/github-for-unity/Unity/pull/290

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ca3c5ca3-fd00-7f35-ceaf-12bc556c84e0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id950E:91CF4:585154:770514:6B00CF7E
html-safe-noncee5bf0c46bbe4d41b00873c5d366a4ad69c18663172cf4f8ae70be70b6e5e939c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTBFOjkxQ0Y0OjU4NTE1NDo3NzA1MTQ6NkIwMENGN0UiLCJ2aXNpdG9yX2lkIjoiNjE2NjY4MDc0MjIxNTYwMjA0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95e9abf6f4efd7b9d8b1929c054a5826c1f99efcd3b80473e45f5c2a5c5c9c4a
hovercard-subject-tagpull_request:139611780
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github-for-unity/Unity/pull/290/files
twitter:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/310137?s=400&v=4
og:image:altAdd a loading view and make it so the PopupWindow always has an active view and there's no null checks. Maybe we can use the loading view to show a loading animation and replace it with the rea...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git
octolytics-dimension-user_id28719038
octolytics-dimension-user_logingithub-for-unity
octolytics-dimension-repository_id94770860
octolytics-dimension-repository_nwogithub-for-unity/Unity
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94770860
octolytics-dimension-repository_network_root_nwogithub-for-unity/Unity
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github-for-unity/Unity/pull/290/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F290%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F290%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github-for-unity%2FUnity
Reloadhttps://github.com/github-for-unity/Unity/pull/290/files
Reloadhttps://github.com/github-for-unity/Unity/pull/290/files
Reloadhttps://github.com/github-for-unity/Unity/pull/290/files
github-for-unityhttps://github.com/github-for-unity
Unityhttps://github.com/github-for-unity/Unity
Codehttps://github.com/github-for-unity/Unity
Issues10 (10)https://github.com/github-for-unity/Unity/issues
Pull requestshttps://github.com/github-for-unity/Unity/pulls
Actionshttps://github.com/github-for-unity/Unity/actions
Projectshttps://github.com/github-for-unity/Unity/projects
Wikihttps://github.com/github-for-unity/Unity/wiki
Security and qualityhttps://github.com/github-for-unity/Unity/security
Insightshttps://github.com/github-for-unity/Unity/insights
StanleyGoldmanhttps://github.com/StanleyGoldman
fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/tree/fixes/popup-window-refactor
fixes/popup-window-refactor-tweakshttps://github.com/github-for-unity/Unity/tree/fixes/popup-window-refactor-tweaks
Conversation 0 https://github.com/github-for-unity/Unity/pull/290
Commits 2 https://github.com/github-for-unity/Unity/pull/290/commits
Checks 0 https://github.com/github-for-unity/Unity/pull/290/checks
Files changed https://github.com/github-for-unity/Unity/pull/290/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/290/files
Tweaking the popup window refactor https://github.com/github-for-unity/Unity/pull/290/files#top
Show all changes 2 commits https://github.com/github-for-unity/Unity/pull/290/files
db49ddd OCD braces cleanup shana Sep 6, 2017 https://github.com/github-for-unity/Unity/pull/290/commits/db49ddd4bf37c0bc625a394aa5d7f3bbfee3e5d4
63b7c92 Add a loading view and make it so the PopupWindow always has an activ… shana Sep 6, 2017 https://github.com/github-for-unity/Unity/pull/290/commits/63b7c9271514193cc2ac12b4d3028a6d8091ee63
Clear filters https://github.com/github-for-unity/Unity/pull/290/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/290/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/290/files
GitHub.Unity.csproj https://github.com/github-for-unity/Unity/pull/290/files#diff-95b36e58cca339cf6da5c51f2172c2c950e7c47b6e8a45687779b091e415652c
BaseWindow.cs https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
LoadingView.cs https://github.com/github-for-unity/Unity/pull/290/files#diff-3563aeca8ead329b4702d9ea28f5189d0be7a427701ff2d9befae313a87c98df
PopupWindow.cs https://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csprojhttps://github.com/github-for-unity/Unity/pull/290/files#diff-95b36e58cca339cf6da5c51f2172c2c950e7c47b6e8a45687779b091e415652c
View file https://github.com/github-for-unity/Unity/blob/63b7c9271514193cc2ac12b4d3028a6d8091ee63/src/UnityExtension/Assets/Editor/GitHub.Unity/GitHub.Unity.csproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/290/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/290/files#diff-95b36e58cca339cf6da5c51f2172c2c950e7c47b6e8a45687779b091e415652c
https://github.com/github-for-unity/Unity/pull/290/files#diff-95b36e58cca339cf6da5c51f2172c2c950e7c47b6e8a45687779b091e415652c
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cshttps://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
View file https://github.com/github-for-unity/Unity/blob/63b7c9271514193cc2ac12b4d3028a6d8091ee63/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/290/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
https://github.com/github-for-unity/Unity/pull/290/files#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LoadingView.cshttps://github.com/github-for-unity/Unity/pull/290/files#diff-3563aeca8ead329b4702d9ea28f5189d0be7a427701ff2d9befae313a87c98df
View file https://github.com/github-for-unity/Unity/blob/63b7c9271514193cc2ac12b4d3028a6d8091ee63/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LoadingView.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/290/{{ revealButtonHref }}
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cshttps://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
View file https://github.com/github-for-unity/Unity/blob/63b7c9271514193cc2ac12b4d3028a6d8091ee63/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/290/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
https://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
https://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
https://github.com/github-for-unity/Unity/pull/290/files#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.