René's URL Explorer Experiment


Title: Refactoring popups to use the same window class by StanleyGoldman · Pull Request #194 · github-for-unity/Unity · GitHub

Open Graph Title: Refactoring popups to use the same window class by StanleyGoldman · Pull Request #194 · github-for-unity/Unity

X Title: Refactoring popups to use the same window class by StanleyGoldman · Pull Request #194 · github-for-unity/Unity

Description: GitHub for Unity. Contribute to github-for-unity/Unity development by creating an account on GitHub.

Opengraph URL: https://github.com/github-for-unity/Unity/pull/194

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b8a3fb6-dec8-7456-2a13-64d410a8e58b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id893A:1A2DA6:D23728:120B218:6B00B4FA
html-safe-noncea4c1bdec51b105964d7bd1e838b673f8dddaba70eafa67fc95dfcc8e46584252
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTNBOjFBMkRBNjpEMjM3Mjg6MTIwQjIxODo2QjAwQjRGQSIsInZpc2l0b3JfaWQiOiI1MDA2OTEzMjk1OTYyMTI1NTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac73f2f8400ad75b48eabc55d08e3ae02864d12ffc61933852edbd74fd0d131087
hovercard-subject-tagpull_request:135845395
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/github-for-unity/Unity/194/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57c28320b39913350440b27a365b3a043f367ab4ff02ade1e56f89cadcaabc68/github-for-unity/Unity/pull/194
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57c28320b39913350440b27a365b3a043f367ab4ff02ade1e56f89cadcaabc68/github-for-unity/Unity/pull/194
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameStanleyGoldman
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-cache
go-importgithub.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git
octolytics-dimension-user_id28719038
octolytics-dimension-user_logingithub-for-unity
octolytics-dimension-repository_id94770860
octolytics-dimension-repository_nwogithub-for-unity/Unity
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94770860
octolytics-dimension-repository_network_root_nwogithub-for-unity/Unity
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/github-for-unity/Unity/pull/194#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F194
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F194
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=github-for-unity%2FUnity
Reloadhttps://github.com/github-for-unity/Unity/pull/194
Reloadhttps://github.com/github-for-unity/Unity/pull/194
Reloadhttps://github.com/github-for-unity/Unity/pull/194
github-for-unityhttps://github.com/github-for-unity
Unityhttps://github.com/github-for-unity/Unity
Codehttps://github.com/github-for-unity/Unity
Issues10 (10)https://github.com/github-for-unity/Unity/issues
Pull requestshttps://github.com/github-for-unity/Unity/pulls
Actionshttps://github.com/github-for-unity/Unity/actions
Projectshttps://github.com/github-for-unity/Unity/projects
Wikihttps://github.com/github-for-unity/Unity/wiki
Security and qualityhttps://github.com/github-for-unity/Unity/security
Insightshttps://github.com/github-for-unity/Unity/insights
https://github.com/github-for-unity/Unity
StanleyGoldmanhttps://github.com/StanleyGoldman
masterhttps://github.com/github-for-unity/Unity/tree/master
fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/tree/fixes/popup-window-refactor
Conversationhttps://github.com/github-for-unity/Unity/pull/194
Commits29 (29)https://github.com/github-for-unity/Unity/pull/194/commits
Checkshttps://github.com/github-for-unity/Unity/pull/194/checks
Files changedhttps://github.com/github-for-unity/Unity/pull/194/files
Refactoring popups to use the same window classhttps://github.com/github-for-unity/Unity/pull/194#top
StanleyGoldmanhttps://github.com/StanleyGoldman
masterhttps://github.com/github-for-unity/Unity/tree/master
fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/tree/fixes/popup-window-refactor
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#issue-250375650
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
August 15, 2017 12:29https://github.com/github-for-unity/Unity/pull/194#commits-pushed-cef5971
https://github.com/StanleyGoldman
First draft at switching to a consolidated PopupWindowhttps://github.com/github-for-unity/Unity/pull/194/commits/cef5971e67c68038f4d65c5db546c2d92f102859
cef5971https://github.com/github-for-unity/Unity/pull/194/commits/cef5971e67c68038f4d65c5db546c2d92f102859
https://github.com/StanleyGoldman
Initializing PopupWindow properlyhttps://github.com/github-for-unity/Unity/pull/194/commits/74cb09434b57b6eedb3325bc8eb47d6e07c078ee
74cb094https://github.com/github-for-unity/Unity/pull/194/commits/74cb09434b57b6eedb3325bc8eb47d6e07c078ee
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
work-in-progress https://github.com/github-for-unity/Unity/issues?q=state%3Aopen%20label%3Awork-in-progress
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#event-1206820595
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
shanahttps://github.com/shana
August 15, 2017 17:04https://github.com/github-for-unity/Unity/pull/194#event-1206820601
StanleyGoldmanhttps://github.com/StanleyGoldman
August 15, 2017 15:01https://github.com/github-for-unity/Unity/pull/194#commits-pushed-41336f2
https://github.com/StanleyGoldman
Adding serializable fields; Adding enum to control displayed Subviewhttps://github.com/github-for-unity/Unity/pull/194/commits/41336f29ed6a547d0c25d602bcd56ae242e7b6a3
41336f2https://github.com/github-for-unity/Unity/pull/194/commits/41336f29ed6a547d0c25d602bcd56ae242e7b6a3
https://github.com/StanleyGoldman
Moving values to constants and virtual methodshttps://github.com/github-for-unity/Unity/pull/194/commits/675ed5c776964f62662f83a883d660c5e87a849b
675ed5chttps://github.com/github-for-unity/Unity/pull/194/commits/675ed5c776964f62662f83a883d660c5e87a849b
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
ready-for-review https://github.com/github-for-unity/Unity/issues?q=state%3Aopen%20label%3Aready-for-review
work-in-progress https://github.com/github-for-unity/Unity/issues?q=state%3Aopen%20label%3Awork-in-progress
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#event-1207098580
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/5c5e2569ccc5edda89b0858564cc5b817c97ca92
5c5e256https://github.com/github-for-unity/Unity/pull/194/commits/5c5e2569ccc5edda89b0858564cc5b817c97ca92
https://github.com/shana
shanahttps://github.com/shana
Aug 15, 2017 https://github.com/github-for-unity/Unity/pull/194#pullrequestreview-56487443
View reviewed changes https://github.com/github-for-unity/Unity/pull/194/files/5c5e2569ccc5edda89b0858564cc5b817c97ca92
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cshttps://github.com/github-for-unity/Unity/pull/194/files/5c5e2569ccc5edda89b0858564cc5b817c97ca92#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
shanahttps://github.com/shana
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133319245
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 16, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133463062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cshttps://github.com/github-for-unity/Unity/pull/194/files/5c5e2569ccc5edda89b0858564cc5b817c97ca92#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
shanahttps://github.com/shana
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133320091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 16, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133461654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PUblishView.cshttps://github.com/github-for-unity/Unity/pull/194/files/5c5e2569ccc5edda89b0858564cc5b817c97ca92#diff-df14a938ba106ff5fc5f681622dd1cef48cf5405e2a66e945c9b17a7e1c4c45d
shanahttps://github.com/shana
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133320723
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 16, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133462362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 18, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133943386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Window.cshttps://github.com/github-for-unity/Unity/pull/194/files/5c5e2569ccc5edda89b0858564cc5b817c97ca92#diff-db39ffa9a290cb01b9bfbc2e8e6ab60b51aed0620a0c53848b81b7a001e6d9bd
shanahttps://github.com/shana
Aug 15, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133321156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 16, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r133465630
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
August 16, 2017 10:15https://github.com/github-for-unity/Unity/pull/194#commits-pushed-86ac212
https://github.com/StanleyGoldman
Setting activeSubview when ActivePopupView is sethttps://github.com/github-for-unity/Unity/pull/194/commits/86ac2129ae1dab25a2ca5c4fb4563d4d95ffc4e1
86ac212https://github.com/github-for-unity/Unity/pull/194/commits/86ac2129ae1dab25a2ca5c4fb4563d4d95ffc4e1
https://github.com/StanleyGoldman
Running Resharpers reformathttps://github.com/github-for-unity/Unity/pull/194/commits/d9bede381eae6be9f7f95bdb35425ae56b9541dc
d9bede3https://github.com/github-for-unity/Unity/pull/194/commits/d9bede381eae6be9f7f95bdb35425ae56b9541dc
https://github.com/StanleyGoldman
Return PopupWindow from Open method; Being sure to call InitializeWin…https://github.com/github-for-unity/Unity/pull/194/commits/c08159cc69682bf8f0abd450ab6e07ceb69df190
c08159chttps://github.com/github-for-unity/Unity/pull/194/commits/c08159cc69682bf8f0abd450ab6e07ceb69df190
https://github.com/StanleyGoldman
Renaming filehttps://github.com/github-for-unity/Unity/pull/194/commits/032c331628d0179a3890b5c33e8d46b2711527e5
032c331https://github.com/github-for-unity/Unity/pull/194/commits/032c331628d0179a3890b5c33e8d46b2711527e5
https://github.com/StanleyGoldman
Fixing spacinghttps://github.com/github-for-unity/Unity/pull/194/commits/ade0baeeed933840c62f30b27aef236a2783ef11
ade0baehttps://github.com/github-for-unity/Unity/pull/194/commits/ade0baeeed933840c62f30b27aef236a2783ef11
https://github.com/shana
Use setters instead of virtual propertieshttps://github.com/github-for-unity/Unity/pull/194/commits/b3c3ec5a16768ae17f0b769a6f36a29a906b9936
b3c3ec5https://github.com/github-for-unity/Unity/pull/194/commits/b3c3ec5a16768ae17f0b769a6f36a29a906b9936
https://github.com/shana
Make type and property names clearerhttps://github.com/github-for-unity/Unity/pull/194/commits/3bbb2e13eab15f15db3bee97d915e896eabc3800
3bbb2e1https://github.com/github-for-unity/Unity/pull/194/commits/3bbb2e13eab15f15db3bee97d915e896eabc3800
https://github.com/shana
shanahttps://github.com/shana
force-pushedhttps://github.com/github-for-unity/Unity/compare/8e4a4704ab6037ba4ff568ce76bb85e348dd4b68..3bbb2e13eab15f15db3bee97d915e896eabc3800
8e4a470https://github.com/github-for-unity/Unity/commit/8e4a4704ab6037ba4ff568ce76bb85e348dd4b68
3bbb2e1https://github.com/github-for-unity/Unity/commit/3bbb2e13eab15f15db3bee97d915e896eabc3800
Compare https://github.com/github-for-unity/Unity/compare/8e4a4704ab6037ba4ff568ce76bb85e348dd4b68..3bbb2e13eab15f15db3bee97d915e896eabc3800
August 18, 2017 17:40https://github.com/github-for-unity/Unity/pull/194#event-1212288714
https://github.com/shana
shanahttps://github.com/shana
Aug 18, 2017 https://github.com/github-for-unity/Unity/pull/194#pullrequestreview-57267087
View reviewed changes https://github.com/github-for-unity/Unity/pull/194/files/3bbb2e13eab15f15db3bee97d915e896eabc3800
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cshttps://github.com/github-for-unity/Unity/pull/194/files/3bbb2e13eab15f15db3bee97d915e896eabc3800#diff-3d859c2d531e6f9f7c8e58eded376be936dcaaabfc5367c0446229f2c7f94b4f
shanahttps://github.com/shana
Aug 18, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r134015959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 18, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r134047873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cshttps://github.com/github-for-unity/Unity/blob/d4121b20ae7e218650a31016b4f7944cc8fa095d/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/PopupWindow.cs#L86-L90
d4121b2https://github.com/github-for-unity/Unity/commit/d4121b20ae7e218650a31016b4f7944cc8fa095d
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
August 18, 2017 15:54https://github.com/github-for-unity/Unity/pull/194#commits-pushed-ab20b12
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/ab20b121ef980c63ecf45725bb4281433c6a5b26
ab20b12https://github.com/github-for-unity/Unity/pull/194/commits/ab20b121ef980c63ecf45725bb4281433c6a5b26
https://github.com/StanleyGoldman
Clearing onClose and Raising it before opening a windowhttps://github.com/github-for-unity/Unity/pull/194/commits/69fd05364cf8856f4053aec06690b2444a4f9612
69fd053https://github.com/github-for-unity/Unity/pull/194/commits/69fd05364cf8856f4053aec06690b2444a4f9612
https://github.com/StanleyGoldman
Making the open method call InitializeWindowhttps://github.com/github-for-unity/Unity/pull/194/commits/8d9c2781cae933b261b5bdd6281c27c5d041c233
8d9c278https://github.com/github-for-unity/Unity/pull/194/commits/8d9c2781cae933b261b5bdd6281c27c5d041c233
https://github.com/StanleyGoldman
Calling Initialize before Showhttps://github.com/github-for-unity/Unity/pull/194/commits/7f38f3331a363d54b4e5aa73dfd3efff83d2e086
7f38f33https://github.com/github-for-unity/Unity/pull/194/commits/7f38f3331a363d54b4e5aa73dfd3efff83d2e086
https://github.com/StanleyGoldman
Better controlling when OnClose is clearedhttps://github.com/github-for-unity/Unity/pull/194/commits/d4121b20ae7e218650a31016b4f7944cc8fa095d
d4121b2https://github.com/github-for-unity/Unity/pull/194/commits/d4121b20ae7e218650a31016b4f7944cc8fa095d
https://github.com/shana
shanahttps://github.com/shana
Aug 22, 2017 https://github.com/github-for-unity/Unity/pull/194#pullrequestreview-57845057
View reviewed changes https://github.com/github-for-unity/Unity/pull/194/files/d4121b20ae7e218650a31016b4f7944cc8fa095d
src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BaseWindow.cshttps://github.com/github-for-unity/Unity/pull/194/files/d4121b20ae7e218650a31016b4f7944cc8fa095d#diff-79a49fdb253509018b5f39d680aa0d7a58826743efd907e5a93a5b51b685b365
shanahttps://github.com/shana
Aug 22, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r134541500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
shanahttps://github.com/shana
Aug 22, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r134576669
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
StanleyGoldmanhttps://github.com/StanleyGoldman
Aug 22, 2017https://github.com/github-for-unity/Unity/pull/194#discussion_r134579873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
https://github.com/shana
shanahttps://github.com/shana
Aug 22, 2017 https://github.com/github-for-unity/Unity/pull/194#pullrequestreview-57845591
View reviewed changes https://github.com/github-for-unity/Unity/pull/194/files/d4121b20ae7e218650a31016b4f7944cc8fa095d
StanleyGoldmanhttps://github.com/StanleyGoldman
August 22, 2017 15:25https://github.com/github-for-unity/Unity/pull/194#commits-pushed-2a25c70
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/2a25c704e57fc2111d9abeb70869c39806823e9b
2a25c70https://github.com/github-for-unity/Unity/pull/194/commits/2a25c704e57fc2111d9abeb70869c39806823e9b
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/cef3e453dddda25be68a241ee6b150ae37598b88
cef3e45https://github.com/github-for-unity/Unity/pull/194/commits/cef3e453dddda25be68a241ee6b150ae37598b88
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/3b13a84b1e7cc789ef11d83c9cb4b114a80a0074
3b13a84https://github.com/github-for-unity/Unity/pull/194/commits/3b13a84b1e7cc789ef11d83c9cb4b114a80a0074
https://github.com/StanleyGoldman
Moving OnClose event down to PopupWindowhttps://github.com/github-for-unity/Unity/pull/194/commits/a5bc9e24e88e534ab4497e0e57ad69a13eed8e03
a5bc9e2https://github.com/github-for-unity/Unity/pull/194/commits/a5bc9e24e88e534ab4497e0e57ad69a13eed8e03
StanleyGoldmanhttps://github.com/StanleyGoldman
August 25, 2017 11:13https://github.com/github-for-unity/Unity/pull/194#commits-pushed-ca95c0f
https://github.com/StanleyGoldman
Missing null checkhttps://github.com/github-for-unity/Unity/pull/194/commits/ca95c0f99c52a8a870639fa7d7738f7da2b03e41
ca95c0fhttps://github.com/github-for-unity/Unity/pull/194/commits/ca95c0f99c52a8a870639fa7d7738f7da2b03e41
https://github.com/StanleyGoldman
Last fixes for PopupWindowhttps://github.com/github-for-unity/Unity/pull/194/commits/fdc35bae0178b0bc3a0cc1e315b0745097f6d52e
fdc35bahttps://github.com/github-for-unity/Unity/pull/194/commits/fdc35bae0178b0bc3a0cc1e315b0745097f6d52e
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/2b9206eaf7b8fb656e0ee235cb8f0695700ca8d3
2b9206ehttps://github.com/github-for-unity/Unity/pull/194/commits/2b9206eaf7b8fb656e0ee235cb8f0695700ca8d3
A dedicated view to initialize the project #252 https://github.com/github-for-unity/Unity/pull/252
Adding functionality to configure git exec, name and email before project init #261 https://github.com/github-for-unity/Unity/pull/261
StanleyGoldmanhttps://github.com/StanleyGoldman
September 2, 2017 11:47https://github.com/github-for-unity/Unity/pull/194#commits-pushed-48a9e05
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/48a9e05088000db1d4027a4610236651d2522f60
48a9e05https://github.com/github-for-unity/Unity/pull/194/commits/48a9e05088000db1d4027a4610236651d2522f60
https://github.com/shana
OCD braces cleanuphttps://github.com/github-for-unity/Unity/pull/194/commits/db49ddd4bf37c0bc625a394aa5d7f3bbfee3e5d4
db49dddhttps://github.com/github-for-unity/Unity/pull/194/commits/db49ddd4bf37c0bc625a394aa5d7f3bbfee3e5d4
https://github.com/shana
Add a loading view and make it so the PopupWindow always has an activ…https://github.com/github-for-unity/Unity/pull/194/commits/63b7c9271514193cc2ac12b4d3028a6d8091ee63
63b7c92https://github.com/github-for-unity/Unity/pull/194/commits/63b7c9271514193cc2ac12b4d3028a6d8091ee63
https://github.com/StanleyGoldman
Merge pull requesthttps://github.com/github-for-unity/Unity/pull/194/commits/490f6db13c129a22fb887440cf87a4c973104882
#290https://github.com/github-for-unity/Unity/pull/290
from github-for-unity/fixes/popup-window-refa…https://github.com/github-for-unity/Unity/pull/194/commits/490f6db13c129a22fb887440cf87a4c973104882
490f6dbhttps://github.com/github-for-unity/Unity/pull/194/commits/490f6db13c129a22fb887440cf87a4c973104882
https://github.com/StanleyGoldman
Merge branch 'master' into fixes/popup-window-refactorhttps://github.com/github-for-unity/Unity/pull/194/commits/7105dec82d2847db0de3e093959efffd60d23e35
7105dechttps://github.com/github-for-unity/Unity/pull/194/commits/7105dec82d2847db0de3e093959efffd60d23e35
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
7294e09https://github.com/github-for-unity/Unity/commit/7294e09b612452d6c1b681f8209a25e805111904
Sep 6, 2017https://github.com/github-for-unity/Unity/pull/194#event-1237243168
https://github.com/StanleyGoldman
StanleyGoldmanhttps://github.com/StanleyGoldman
September 6, 2017 16:56https://github.com/github-for-unity/Unity/pull/194#event-1237243248
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F194
https://github.com/shana
shana https://github.com/shana
https://github.com/github-for-unity/Unity/pull/194/files/d4121b20ae7e218650a31016b4f7944cc8fa095d
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
ready-for-review https://github.com/github-for-unity/Unity/issues?q=state%3Aopen%20label%3Aready-for-review
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/194
https://github.com/StanleyGoldman
https://github.com/shana
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.