René's URL Explorer Experiment


Title: Fix to improve performance of ChangesTreeView by StanleyGoldman · Pull Request #119 · github-for-unity/Unity · GitHub

Open Graph Title: Fix to improve performance of ChangesTreeView by StanleyGoldman · Pull Request #119 · github-for-unity/Unity

X Title: Fix to improve performance of ChangesTreeView by StanleyGoldman · Pull Request #119 · github-for-unity/Unity

Description: Attempted #23 performance test used pumps two sequences into TreeBuilder.BuildTreeRoot(): Simple Test a. The first sequence contains 200 GitStatusEntry objects. There are 10 folders, with 10 files and 10 meta files. a. The second sequence contains 300 GitStatusEntry objects. Out of the original dataset every other file is retained. a. There are 10 folders, with 5 files and 5 meta files. a. Half of the original files can be considered "removed". a. An additional 10 folders, with 10 files and 10 meta files. Advanced Test a. The first sequence contains 800 GitStatusEntry objects. There are 20 folders, with 20 files and 20 meta files. a. The second sequence contains 1200 GitStatusEntry objects. Out of the original dataset every other file is retained. a. There are 10 folders, with 10 files and 10 meta files. a. Half of the original files can be considered "removed". a. An additional 20 folders, with 20 files and 20 meta files. Method Mean Error StdDev Basic Test - Currently 70.71 ms 1.3993 ms 1.3743 ms Basic Test - PR 26.77 ms 0.6483 ms 0.6657 ms Heavy Test - Currently 754.46 ms 6.6629 ms 5.9064 ms Heavy Test - PR 110.11 ms 2.1563 ms 2.2143 ms This branch will let you reproduce the performance test framework: https://github.com/github-for-unity/Unity/tree/fixes/changes-view-performance-proof Run the PerformanceTest project un-attached in Release mode. It will take approx 8-9 minutes to complete. Overall the PR starts at a third of the time of the current code base, and the amount of time it takes to execute grows bu half of the current code base. Depends on: #120 #121 #133

Open Graph Description: Attempted #23 performance test used pumps two sequences into TreeBuilder.BuildTreeRoot(): Simple Test a. The first sequence contains 200 GitStatusEntry objects. There are 10 folders, with 10 file...

X Description: Attempted #23 performance test used pumps two sequences into TreeBuilder.BuildTreeRoot(): Simple Test a. The first sequence contains 200 GitStatusEntry objects. There are 10 folders, with 10 file...

Opengraph URL: https://github.com/github-for-unity/Unity/pull/119

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5c024d55-6fbf-d9e9-9060-0a2bcf128a7d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC5C:38C5CF:929A1D:BEB810:6B00DCCC
html-safe-nonce5e6545f87f509c2e6cc1ffc45969e72a699f05f3b76885d84af8b6a53f884e4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzVDOjM4QzVDRjo5MjlBMUQ6QkVCODEwOjZCMDBEQ0NDIiwidmlzaXRvcl9pZCI6IjUwMzIwODU0ODA4MDg3MDExMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0b3127bddf776b9782674ae619f2acf01ad615cf967acfcc8b931d6fe8c6b72f
hovercard-subject-tagpull_request:129931172
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/github-for-unity/Unity/pull/119/files
twitter:imagehttps://avatars.githubusercontent.com/u/417571?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/417571?s=400&v=4
og:image:altAttempted #23 performance test used pumps two sequences into TreeBuilder.BuildTreeRoot(): Simple Test a. The first sequence contains 200 GitStatusEntry objects. There are 10 folders, with 10 file...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git
octolytics-dimension-user_id28719038
octolytics-dimension-user_logingithub-for-unity
octolytics-dimension-repository_id94770860
octolytics-dimension-repository_nwogithub-for-unity/Unity
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94770860
octolytics-dimension-repository_network_root_nwogithub-for-unity/Unity
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/github-for-unity/Unity/pull/119/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F119%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgithub-for-unity%2FUnity%2Fpull%2F119%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=github-for-unity%2FUnity
Reloadhttps://github.com/github-for-unity/Unity/pull/119/files
Reloadhttps://github.com/github-for-unity/Unity/pull/119/files
Reloadhttps://github.com/github-for-unity/Unity/pull/119/files
github-for-unityhttps://github.com/github-for-unity
Unityhttps://github.com/github-for-unity/Unity
Codehttps://github.com/github-for-unity/Unity
Issues10 (10)https://github.com/github-for-unity/Unity/issues
Pull requestshttps://github.com/github-for-unity/Unity/pulls
Actionshttps://github.com/github-for-unity/Unity/actions
Projectshttps://github.com/github-for-unity/Unity/projects
Wikihttps://github.com/github-for-unity/Unity/wiki
Security and qualityhttps://github.com/github-for-unity/Unity/security
Insightshttps://github.com/github-for-unity/Unity/insights
StanleyGoldmanhttps://github.com/StanleyGoldman
masterhttps://github.com/github-for-unity/Unity/tree/master
fixes/changes-view-performancehttps://github.com/github-for-unity/Unity/tree/fixes/changes-view-performance
Conversation 3 https://github.com/github-for-unity/Unity/pull/119
Commits 9 https://github.com/github-for-unity/Unity/pull/119/commits
Checks 0 https://github.com/github-for-unity/Unity/pull/119/checks
Files changed https://github.com/github-for-unity/Unity/pull/119/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/119/files
Fix to improve performance of ChangesTreeView https://github.com/github-for-unity/Unity/pull/119/files#top
Show all changes 9 commits https://github.com/github-for-unity/Unity/pull/119/files
7a5c16d NPath optimization when looking for the search label StanleyGoldman Jul 11, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/7a5c16db84eac0d9714a1e9a8828986fd6c2975d
5871a87 Using a HashSet at the right time. StanleyGoldman Jul 11, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/5871a87aa52c927318dd25ef9218ca67e282b6b7
e5e1e31 Another HashSet to the rescue StanleyGoldman Jul 11, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/e5e1e317ac5f4b501d4bbfd0adc61adb1c39d62f
0e5f48b Merge branch 'fixes/changes-view-refactoring' into fixes/changes-view… StanleyGoldman Jul 11, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/0e5f48bd0043d9ec9f65ceb921189ef583b276bf
81ae6b2 A slight performance improvement StanleyGoldman Jul 13, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/81ae6b24c8448b246d32fd3cee1851882a7166f2
6c09be8 Merge branch 'fixes/changes-view-refactoring' into fixes/changes-view… StanleyGoldman Jul 13, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/6c09be83475c48e896bdc59fe1b2a7c9502e95a3
b26560b Merge branch 'fixes/changes-view-refactoring' into fixes/changes-view… StanleyGoldman Jul 13, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/b26560bffc4eee7b045d4bc07ebb8563a21bff59
e3456fe Merge branch 'fixes/changes-view-refactoring' into fixes/changes-view… StanleyGoldman Jul 13, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/e3456fe6350fee407fa1f18e9b7ca0e265aa9265
cb54c5e Merge branch 'master' into fixes/changes-view-performance StanleyGoldman Jul 31, 2017 https://github.com/github-for-unity/Unity/pull/119/commits/cb54c5e9d965288f1765ff6ec61443675e204c07
Clear filters https://github.com/github-for-unity/Unity/pull/119/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/119/files
Please reload this pagehttps://github.com/github-for-unity/Unity/pull/119/files
src/GitHub.Api/UI/TreeBuilder.cshttps://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
View file https://github.com/github-for-unity/Unity/blob/cb54c5e9d965288f1765ff6ec61443675e204c07/src/GitHub.Api/UI/TreeBuilder.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/github-for-unity/Unity/pull/119/{{ revealButtonHref }}
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com/github-for-unity/Unity/pull/119/files#diff-a6bfc283d1b69603843b0fbbd9a43d99a3b936184224cd23258286aa34f53b1e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.