Title: Discrepancy in events raised by RepositoryWatcher · Issue #421 · github-for-unity/Unity · GitHub
Open Graph Title: Discrepancy in events raised by RepositoryWatcher · Issue #421 · github-for-unity/Unity
X Title: Discrepancy in events raised by RepositoryWatcher · Issue #421 · github-for-unity/Unity
Description: On some workstations the action of git commit is producing a different output in the RepositoryWatcher. Executing the integration test ShouldAddAndCommitAllFiles from #418 demonstrates the issue more closely. Workstations seem consistent...
Open Graph Description: On some workstations the action of git commit is producing a different output in the RepositoryWatcher. Executing the integration test ShouldAddAndCommitAllFiles from #418 demonstrates the issue mo...
X Description: On some workstations the action of git commit is producing a different output in the RepositoryWatcher. Executing the integration test ShouldAddAndCommitAllFiles from #418 demonstrates the issue mo...
Opengraph URL: https://github.com/github-for-unity/Unity/issues/421
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Discrepancy in events raised by RepositoryWatcher","articleBody":"On some workstations the action of `git commit` is producing a different output in the `RepositoryWatcher`.\r\nExecuting the integration test `ShouldAddAndCommitAllFiles` from #418 demonstrates the issue more closely.\r\n\r\nWorkstations seem consistent in their ability to reproduce the issue or not.\r\nI have one workstation where this works and one where it does not.\r\n\r\nThis log shows what we expect:\r\n```\r\n17:52:20.600 PM TRACE [ 9] \u003cGitClient> Add all files\r\n17:52:20.609 PM TRACE [ 9] \u003cGitClient> Commit\r\n17:52:20.625 PM TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:True\r\n17:52:20.633 PM TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: True\r\n17:52:20.777 PM TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:False\r\n17:52:20.783 PM TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: False\r\n17:52:20.789 PM TRACE [15] \u003cRepositoryWatcher> Handling 57 Events\r\n17:52:20.800 PM TRACE [15] \u003cRepositoryWatcher> IndexChanged\r\n17:52:20.806 PM TRACE [15] \u003cRepositoryWatcher> LocalBranchChanged: master\r\n17:52:20.812 PM TRACE [15] \u003cIRepositoryManagerListener> OnLocalBranchUpdated Name:master\r\n17:52:20.817 PM TRACE [15] \u003cRepositoryWatcher> Processed 2 Events\r\n17:52:20.831 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n17:52:20.839 PM TRACE [ 4] \u003cRepositoryWatcher> Stopping watcher\r\n17:52:20.845 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n17:52:20.852 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n17:52:20.859 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n```\r\n\r\nIn error scenarios this is what we receive:\r\n```\r\n18:34:55.346 PM TRACE [ 9] \u003cGitClient> Add all files\r\n18:34:55.355 PM TRACE [ 9] \u003cGitClient> Commit\r\n18:34:55.368 PM TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:True\r\n18:34:55.377 PM TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: True\r\n18:34:55.576 PM TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:False\r\n18:34:55.580 PM TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: False\r\n18:34:55.586 PM TRACE [15] \u003cRepositoryWatcher> Handling 62 Events\r\n18:34:55.594 PM TRACE [15] \u003cRepositoryWatcher> IndexChanged\r\n18:34:55.598 PM TRACE [15] \u003cRepositoryWatcher> LocalBranchCreated: master\r\n18:34:55.604 PM TRACE [15] \u003cIRepositoryManagerListener> OnLocalBranchAdded Name:master\r\n18:34:55.608 PM TRACE [15] \u003cRepositoryWatcher> LocalBranchDeleted: master\r\n18:34:55.613 PM TRACE [15] \u003cIRepositoryManagerListener> OnLocalBranchRemoved Name:master\r\n18:34:55.617 PM TRACE [15] \u003cRepositoryWatcher> Processed 3 Events\r\n18:34:55.658 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n18:34:55.664 PM TRACE [ 4] \u003cRepositoryWatcher> Stopping watcher\r\n18:34:55.674 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n18:34:55.683 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n18:34:55.689 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n```\r\n\r\nThis issue existed before the batching changes made to the `FileWatcher`.\r\n\r\nhttps://ci.appveyor.com/project/github-windows/unity/build/1912.releases/0.21/artifacts\r\n```\r\n170921-16:51:09 TRACE [ 7] \u003cGitClient> Add all files\r\n170921-16:51:09 TRACE [ 7] \u003cGitClient> Commit\r\n170921-16:51:09 TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:True\r\n170921-16:51:09 TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: True\r\n170921-16:51:09 TRACE [15] \u003cRepositoryManager> IsBusyChanged Value:False\r\n170921-16:51:09 TRACE [15] \u003cIRepositoryManagerListener> OnIsBusyChanged: False\r\n170921-16:51:09 TRACE [15] \u003cRepositoryWatcher> Handling 55 Events\r\n170921-16:51:09 TRACE [15] \u003cRepositoryWatcher> LocalBranchChanged: master\r\n170921-16:51:09 TRACE [15] \u003cRepositoryManager> Updating Git Status\r\n170921-16:51:09 TRACE [15] \u003cGitClient> Status\r\n170921-16:51:09 TRACE [15] \u003cRepositoryWatcher> IndexChanged\r\n170921-16:51:09 TRACE [15] \u003cRepositoryWatcher> Processed 2 Events\r\n170921-16:51:09 TRACE [ 7] \u003cRepositoryManager> Stop\r\n170921-16:51:09 TRACE [ 7] \u003cRepositoryWatcher> Stopping watcher\r\n170921-16:51:09 TRACE [ 7] \u003cRepositoryManager> Stop\r\n170921-16:51:09 WARN [ 7] \u003cRepositoryWatcher> Watcher already stopped\r\n170921-16:51:09 WARN [ 7] \u003cRepositoryWatcher> Watcher already stopped\r\n```\r\n\r\nRunning the same integration test from 0.21 locally results in the following\r\n```\r\n18:50:28.474 PM TRACE [ 4] \u003cGitClient> Add all files\r\n18:50:28.483 PM TRACE [ 4] \u003cGitClient> Commit\r\n18:50:28.492 PM TRACE [11] \u003cRepositoryManager> IsBusyChanged Value:True\r\n18:50:28.497 PM TRACE [11] \u003cIRepositoryManagerListener> OnIsBusyChanged: True\r\n18:50:28.767 PM TRACE [11] \u003cRepositoryManager> IsBusyChanged Value:False\r\n18:50:28.772 PM TRACE [11] \u003cIRepositoryManagerListener> OnIsBusyChanged: False\r\n18:50:28.782 PM TRACE [11] \u003cRepositoryWatcher> Handling 62 Events\r\n18:50:28.789 PM TRACE [11] \u003cRepositoryWatcher> LocalBranchDeleted: master\r\n18:50:28.796 PM TRACE [11] \u003cIRepositoryManagerListener> OnLocalBranchListChanged\r\n18:50:28.803 PM TRACE [11] \u003cRepositoryWatcher> LocalBranchCreated: master\r\n18:50:28.822 PM TRACE [11] \u003cIRepositoryManagerListener> OnLocalBranchListChanged\r\n18:50:28.828 PM TRACE [11] \u003cRepositoryWatcher> IndexChanged\r\n18:50:28.834 PM TRACE [11] \u003cRepositoryWatcher> Processed 3 Events\r\n18:50:28.871 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n18:50:28.877 PM TRACE [ 4] \u003cRepositoryWatcher> Stopping watcher\r\n18:50:28.884 PM TRACE [ 4] \u003cRepositoryManager> Stop\r\n18:50:28.890 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n18:50:28.895 PM WARN [ 4] \u003cRepositoryWatcher> Watcher already stopped\r\n```\r\n\r\nDue to the chain of events that follow the `ChangesView` does not refresh after a `git commit` and the branch `master` disappears.\r\n","author":{"url":"https://github.com/StanleyGoldman","@type":"Person","name":"StanleyGoldman"},"datePublished":"2017-11-08T23:58:15Z","url":"https://github.com/github-for-unity/Unity/issues/421"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:028651f4-bea1-23c6-02b6-bf9863d519a5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE0E:3D8CBB:2DF699:3E17AB:6B00C368 |
| html-safe-nonce | e566b4b834f6e91ba4ad82cd948f7456091f38b0eaff6050da95f3e704ed471c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTBFOjNEOENCQjoyREY2OTk6M0UxN0FCOjZCMDBDMzY4IiwidmlzaXRvcl9pZCI6IjQ5NjE1MjkwNjgwMzUwMzE5MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2acda33b69fd91834ab4487606e32dbaa30b37e1a254e4662977f35c11276b10 |
| hovercard-subject-tag | issue:272393220 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github-for-unity/Unity/421/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3477d2bb03429f0d377fd6532bf43116a2a967eee582c4cf4557626f97c5b4e8/github-for-unity/Unity/issues/421 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3477d2bb03429f0d377fd6532bf43116a2a967eee582c4cf4557626f97c5b4e8/github-for-unity/Unity/issues/421 |
| og:image:alt | On some workstations the action of git commit is producing a different output in the RepositoryWatcher. Executing the integration test ShouldAddAndCommitAllFiles from #418 demonstrates the issue mo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | StanleyGoldman |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-preview |
| go-import | github.com/github-for-unity/Unity git https://github.com/github-for-unity/Unity.git |
| octolytics-dimension-user_id | 28719038 |
| octolytics-dimension-user_login | github-for-unity |
| octolytics-dimension-repository_id | 94770860 |
| octolytics-dimension-repository_nwo | github-for-unity/Unity |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 94770860 |
| octolytics-dimension-repository_network_root_nwo | github-for-unity/Unity |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width