Title: arch: Teams adapter breaking async factory change — migration guide + token security review · Issue #862 · github/squad · GitHub
Open Graph Title: arch: Teams adapter breaking async factory change — migration guide + token security review · Issue #862 · github/squad
X Title: arch: Teams adapter breaking async factory change — migration guide + token security review · Issue #862 · github/squad
Description: Problem Breaking change: PR #768 changed \createCommunicationAdapter\ from sync to async with no migration guide or deprecation period. Security gaps identified: Module-level cached auth token — no tenant isolation No revoke/logout mecha...
Open Graph Description: Problem Breaking change: PR #768 changed \createCommunicationAdapter\ from sync to async with no migration guide or deprecation period. Security gaps identified: Module-level cached auth token — no...
X Description: Problem Breaking change: PR #768 changed \createCommunicationAdapter\ from sync to async with no migration guide or deprecation period. Security gaps identified: Module-level cached auth token — no...
Opengraph URL: https://github.com/github/squad/issues/862
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"arch: Teams adapter breaking async factory change — migration guide + token security review","articleBody":"## Problem\n\n**Breaking change:** PR #768 changed \\createCommunicationAdapter\\ from sync to async with no migration guide or deprecation period.\n\n**Security gaps identified:**\n1. Module-level cached auth token — no tenant isolation\n2. No revoke/logout mechanism — tokens persist indefinitely\n3. No device-code auth timeout guard — could hang indefinitely on failed auth flow\n4. Token not cleared on error — stale/invalid token reused\n\n## Impact\n\n- Existing code calling \\createCommunicationAdapter\\ synchronously will break\n- Teams adapter could authenticate as wrong tenant in multi-tenant deployments\n- Hung auth flows with no timeout could freeze the CLI\n- Logout not possible without restarting the process\n\n## Proposed solution\n\n1. **Migration guide**: Document breaking change, provide examples of async/await migration, suggest codemods or deprecation warnings\n2. **Token security**:\n - Tenant-scoped token cache (isolate by tenant ID)\n - Explicit revoke() method for logout\n - Device-code timeout guard (e.g., 15min max)\n - Clear token on auth error, not reuse\n\n3. **Testing**: Multi-tenant scenarios, timeout conditions, token lifecycle\n\n## Success criteria\n\n- [ ] Migration guide published\n- [ ] Token cache is tenant-scoped\n- [ ] Logout (revoke) mechanism implemented\n- [ ] Device-code flow has timeout guard\n- [ ] Stale tokens are not reused","author":{"url":"https://github.com/diberry","@type":"Person","name":"diberry"},"datePublished":"2026-04-05T19:24:45Z","url":"https://github.com/github/squad/issues/862"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ba49a08c-ef3c-23c7-965f-5a203203c1fa |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9EC0:7A60E:1F56F0D:2829E0B:6B016045 |
| html-safe-nonce | a5155818f483f63cde124788f61f48ec9cdba681373972b92a9ad0ac7a09293b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUMwOjdBNjBFOjFGNTZGMEQ6MjgyOUUwQjo2QjAxNjA0NSIsInZpc2l0b3JfaWQiOiIxOTQ0NjkyNzEwMTcwNTE3NTczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5297c83effb527686aa62c9dac9c1a10e62b7f283a7a5e367fb718b73ffe7f2a |
| hovercard-subject-tag | issue:4208395048 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/github/squad/862/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0747732fc5290811daa019571d9243e7c7d50aee0d8e15f44dde6206fc7fc6d0/github/squad/issues/862 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0747732fc5290811daa019571d9243e7c7d50aee0d8e15f44dde6206fc7fc6d0/github/squad/issues/862 |
| og:image:alt | Problem Breaking change: PR #768 changed \createCommunicationAdapter\ from sync to async with no migration guide or deprecation period. Security gaps identified: Module-level cached auth token — no... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | diberry |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/github/squad git https://github.com/github/squad.git |
| octolytics-dimension-user_id | 9919 |
| octolytics-dimension-user_login | github |
| octolytics-dimension-repository_id | 1151205052 |
| octolytics-dimension-repository_nwo | github/squad |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1151205052 |
| octolytics-dimension-repository_network_root_nwo | github/squad |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width